Issue with Dropbox images

[oneclickdev]

try to add link on image shared with Dropbox and you will see empty/broken image (i.e. https://www.dropbox.com/s/hjt4l2ufqtrzzmj/Screenshot%202015-11-26%2017.43.39.png?dl=0)

basecamp works fine with such shares..

let me know if I can assist with that issue somehow (check for redirects from dropbox or what do you think could be an issue?)

[JohnMcLear]

The regex for parsing images will need modifying, I'm available as a gun for hire if you can't figure it out

[oneclickdev]

great. thanks for a quick answer and support :)

but, as I see regexp works just fine:
https://www.dropbox.com/s/3j88ohy4j6edqau/Screenshot%202015-11-26%2018.57.21.png?dl=0

may it be some kind of redirect or headers from Dropbox?
here is what etherpad puts in content:
https://www.dropbox.com/s/4pddk8se2mjrgg7/Screenshot%202015-11-26%2018.59.53.png?dl=0

[JohnMcLear]

*shrugs, I don't really care much about supporting propitiatory third party services for free, if I did that for each plugin I maintained I'd get nothing done. Sorry but if you want me to look into this you are going to need to contract me or get Dropbox to...

[oneclickdev]

oh, I see. that's not a problem then. thanks a lot for you answers.

I will let you know If figure out how to fix it.

thanks again.

[oneclickdev]

I found the solution here:
http://stackoverflow.com/questions/23408261/image-not-being-retrieved-from-dropbox

will try to apply it later if you don't mind..

[JohnMcLear]

Go for it :)

[oneclickdev]

I'm unable to make a request for some reason:
https://www.dropbox.com/s/hnccdpgr7fg7kvu/Screenshot%202015-11-26%2019.33.05.png?dl=0

but here is the solution :)

you should do this:

diff --cc static/js/index.js
index 85842cf,f3c9021..0000000
--- a/static/js/index.js
+++ b/static/js/index.js
@@@ -14,15 -14,11 +14,23 @@@ exports.aceCreateDomLine = function(nam
        return space + "image image_" + image;
      });

++<<<<<<< HEAD
 +    // make it work for Dropbox (solution from here: http://stackoverflow.com/questions/23408261/image-not-being-retrieved-from-dropbox )
 +    src = src.replace(/^(http(s)?\:\/\/(www.)?dropbox.com\/)/i, "https://dl.dropboxusercontent.com/");
 +
 +    // Note the additional span wrapper here is required to stop errors if someone types text after an image url
 +    return [{
 +      cls: cls,
 +      extraOpenTags: '<span style="display:block;"><img src="' + src + '" style="max-width:100%" /></span>',
 +      extraCloseTags:''
 +    }];
++=======
+    return [{
+      cls: cls,
+      extraOpenTags: '<img src="' + src + '" style="max-width:100%" /><br/>',
+      extraCloseTags:''
+    }];
++>>>>>>> parent of 185b052... fix typing after image
    }
  }
</pre>