Commit 1f27d1a
committed
Finish P0.2e cluster forcedotcom#6 (part 2): photo test fix + OpenID baseline
Two test-only resolutions plus a baseline decision, all triaged against the
pre-migration oracle (unmigrated ObjC at merge-base 6ed0ab4).
- SFUserAccountPhotoTests.testPhotoWithoutCompletionBlock: the migration changed
the assertion from the ObjC original's XCTAssertNotNil(user.photo) to
XCTAssertTrue over a reference-equality poll (user.photo == testPhoto). The
`photo` getter re-decodes from disk into a NEW UIImage when _photo is nil
(byte-faithful to ObjC SFUserAccount.m:170-185), so ref-equality never
converges and the poll times out. Restored the ObjC assertion semantics
(wait for the async setPhoto to settle, then assert final state). Both photo
tests pass. Test-only; production unchanged.
- SalesforceOAuthUnitTests/testCredentialsCoding: already green (resolved by the
cluster forcedotcom#1 init?(coder:) decode fix, deae6b0); confirmed by run. No change.
- SFSDKAuthUtilTests.testOpenIDToken: baselined as pre-existing/old-refresh-flow,
NOT a migration regression. A 3-way oracle comparison proved it: the same
intermittent setUp auth-refresh hang (listener status stuck 'waiting' -> 30s
timeout, callback never fires) reproduces in the UNMIGRATED ObjC at our
merge-base 6ed0ab4, while current dev -- which carries upstream's new token
refresh coordinator (PR forcedotcom#4087 / 8f597c9) ~155 commits ahead -- runs 9/9
green. So it is an old-refresh-flow defect upstream already fixed, independent
of the ObjC->Swift migration. Likely refresh-token rotation. Will be
superseded when the refresh-coordinator work is pulled via the port queue.
Baseline entries added with rationale (anti-laundering: not migration-caused).1 parent 280f13d commit 1f27d1a
3 files changed
Lines changed: 47 additions & 4 deletions
File tree
- .claude
- libs/SalesforceSDKCore/SalesforceSDKCoreTests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
66 | 82 | | |
67 | 83 | | |
68 | 84 | | |
| |||
218 | 234 | | |
219 | 235 | | |
220 | 236 | | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
221 | 260 | | |
222 | 261 | | |
223 | 262 | | |
| |||
Lines changed: 7 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
48 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
49 | 53 | | |
50 | 54 | | |
51 | 55 | | |
52 | 56 | | |
53 | | - | |
54 | | - | |
| 57 | + | |
55 | 58 | | |
56 | 59 | | |
57 | 60 | | |
| |||
0 commit comments