Skip to content

fix: verify readiness bot lint detection#39

Closed
Joibel wants to merge 2 commits into
mainfrom
test-flight-lint
Closed

fix: verify readiness bot lint detection#39
Joibel wants to merge 2 commits into
mainfrom
test-flight-lint

Conversation

@Joibel

@Joibel Joibel commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Motivation

Test flight for the PR readiness helper: this PR deliberately introduces a lint failure (an unused function) to verify the bot surfaces the Lint check with actionable guidance.

Modifications

Added an unused private function to util/expand/expand.go. It compiles and is gofmt-clean, so only the unused linter should fail.

Verification

Watching the PR Readiness Helper workflow's dry-run step summary on this PR.

Documentation

Not needed — throwaway test PR in a fork.

AI

This test PR was prepared with Claude Code.

Joibel and others added 2 commits June 5, 2026 15:27
Fork-only commit so the PR readiness helper does not skip test PRs
opened by the fork owner during the dry-run test flight.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Alan Clucas <alan@clucas.org>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Alan Clucas <alan@clucas.org>
@Joibel
Joibel force-pushed the main branch 3 times, most recently from 06fbc92 to a7c89b3 Compare June 5, 2026 16:00
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

👋 PR readiness check

Thanks for your contribution! A few automated checks need attention before a maintainer reviews — these are all things you can fix yourself:

  • Lint — Run make pre-commit -B locally to auto-fix most lint issues, then commit and push the result. (log)

🤖 Automated PR-readiness helper — it re-checks each time CI finishes. Unit/E2E test results are not covered here. Questions? See the contributing guide or ask a maintainer.

@Joibel

Joibel commented Jun 29, 2026

Copy link
Copy Markdown
Owner Author

Closing — test artifact from the PR readiness helper dry-run flight. The feature is merged upstream (argoproj#16231).

@Joibel Joibel closed this Jun 29, 2026
@Joibel
Joibel deleted the test-flight-lint branch June 29, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant