Add autodocs for submodules and libraries#2967
Closed
gdalle wants to merge 1 commit into
Closed
Conversation
Member
|
@gdalle you can put |
Contributor
Author
|
Oops my bad! I put it in the second commit, hope it is enough |
Contributor
Author
|
It seems the test suite still ran despite the following commits including "[only docs]". Does this guideline only apply to the very first commit? Should I start a new PR? |
Member
|
Could you squash and repush with only docs in the command line? It can be a
bit finicky
…On Thu, Nov 13, 2025 at 7:59 AM Guillaume Dalle ***@***.***> wrote:
*gdalle* left a comment (JuliaGPU/CUDA.jl#2967)
<#2967 (comment)>
It seems the test suite still ran despite the following commits including
"[only docs]". Does this guideline only apply to the very first commit?
Should I start a new PR?
—
Reply to this email directly, view it on GitHub
<#2967 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGKJY6VEVNFKBVOTRUKYY334QT5TAVCNFSM6AAAAACL5YTGKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKMRVHA3DQMZWHE>
.
You are receiving this because you commented.Message ID: <JuliaGPU/CUDA.
***@***.***>
|
Contributor
Author
|
I tried but it seems to be running anyway? Should I open a new PR? |
Member
|
I mean if the docs build succeeds, I'm happy to merge. We can just let it run for now tbh. |
Contributor
Author
|
I'd love to learn what went wrong for next time though |
Contributor
Author
|
Sorry I couldn't test the docs build locally, I don't have an NVIDIA GPU |
Contributor
Author
|
Closed in favor of #2972 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time I check out cuSPARSE I have to go to the source file to figure out what's inside
CuSparseMatrixCSR. This PR is a first step that displays all the docstrings of the libraries and submodules, so that once we actually write them they will appear on the website.Feel free to reject or modify if you don't think that's a good idea, especially if it reveals/defines "public" API that you don't want to commit to.