Conversation
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/lib/cusolver/linalg.jl b/lib/cusolver/linalg.jl
index 074094dab..97ef0a25e 100644
--- a/lib/cusolver/linalg.jl
+++ b/lib/cusolver/linalg.jl
@@ -167,7 +167,7 @@ end
for wrap_T in (:Hermitian, :Symmetric)
@eval begin
- function Base.log(A::$wrap_T{T, <:StridedCuMatrix}) where {T<:BlasReal}
+ function Base.log(A::$wrap_T{T, <:StridedCuMatrix}) where {T <: BlasReal}
F = eigen(A)
if all(λ -> λ ≥ 0, F.values)
retmat = (F.vectors * Diagonal(log.(F.values))) * F.vectors'
@@ -178,7 +178,7 @@ for wrap_T in (:Hermitian, :Symmetric)
end
end
end
-function Base.log(A::Hermitian{T, <:StridedCuMatrix{T}}) where {T<:Complex}
+function Base.log(A::Hermitian{T, <:StridedCuMatrix{T}}) where {T <: Complex}
F = eigen(A)
if all(λ -> λ ≥ 0, F.values)
retmat = (F.vectors * Diagonal(log.(F.values))) * F.vectors' |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2993 +/- ##
==========================================
- Coverage 89.23% 89.21% -0.02%
==========================================
Files 148 148
Lines 12935 12947 +12
==========================================
+ Hits 11542 11551 +9
- Misses 1393 1396 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AntonOresten
pushed a commit
to MurrellGroup/CUDA.jl
that referenced
this pull request
Dec 13, 2025
* Support log for Hermitian CuMatrix * Fix collection to host * Fix ambiguities
michel2323
pushed a commit
to michel2323/CUDA.jl
that referenced
this pull request
Dec 23, 2025
* Support log for Hermitian CuMatrix * Fix collection to host * Fix ambiguities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off the latest LinearAlgebra.jl, which we can use for nightly, but not older versions of Julia