Add unsigned integer support

Author: tamasgal

src/bootstrap.jl

@@ -413,7 +413,7 @@ function unpack(io, tkey::TKey, refs::Dict{Int32, Any}, T::Type{TLeafG})
     T(;fields...)
 end
 
-primitivetype(l::TLeafG) = Int64
+primitivetype(l::TLeafG) = l.fIsUnsigned ? UInt64 : Int64
 
 # FIXME this should be generated and inherited from TLeaf
 Base.@kwdef struct TLeafO
@@ -518,7 +518,7 @@ function unpack(io, tkey::TKey, refs::Dict{Int32, Any}, T::Type{TLeafB})
     T(;fields...)
 end
 
-primitivetype(l::TLeafB) = UInt8
+primitivetype(l::TLeafB) = l.fIsUnsigned ? UInt8 : Int8
 # FIXME this should be generated and inherited from TLeaf
 Base.@kwdef struct TLeafD
     # from TNamed

test/issues.jl

@@ -150,3 +150,17 @@ end
     df = LazyTree(UnROOT.samplefile("TLeafC_pr342.root"), "G4Sim")
     @test all(df.Process[1:10] .== ["Radioactivation", "msc", "eIoni", "Transportation", "ionIoni", "Radioactivation", "msc", "eIoni", "ionIoni", "Radioactivation"])
 end
+
+@testset "Unsigned integer branches (TLeafB/S/I/L with fIsUnsigned)" begin
+    f = UnROOT.samplefile("unsigned_integers.root")
+    t = LazyTree(f, "tree")
+    @test eltype(t.b_uint8)  === UInt8
+    @test eltype(t.b_uint16) === UInt16
+    @test eltype(t.b_uint32) === UInt32
+    @test eltype(t.b_uint64) === UInt64
+    @test t.b_uint8  == UInt8[ 200,  255, 1]
+    @test t.b_uint16 == UInt16[60000, 65535, 1]
+    @test t.b_uint32 == UInt32[4000000000, 4294967295, 1]
+    @test t.b_uint64 == UInt64[18000000000000000000, 18446744073709551615, 1]
+    close(f)
+end

test/samples/unsigned_integers.py

@@ -0,0 +1,42 @@
+"""
+Generate a ROOT file with branches of all unsigned integer types.
+Used by UnROOT.jl tests to verify correct unsigned type reading.
+
+Run with:
+    python unsigned_integers.py
+or:
+    root -l -q unsigned_integers.py
+"""
+from array import array
+import ROOT as r
+
+f = r.TFile("unsigned_integers.root", "recreate")
+t = r.TTree("tree", "Tree with all unsigned integer types")
+
+b_uint8  = array('B', [0])
+b_uint16 = array('H', [0])
+b_uint32 = array('I', [0])
+b_uint64 = array('Q', [0])
+
+# type codes: b=UChar_t, s=UShort_t, i=UInt_t, l=ULong64_t
+t.Branch("b_uint8",  b_uint8,  "b_uint8/b")
+t.Branch("b_uint16", b_uint16, "b_uint16/s")
+t.Branch("b_uint32", b_uint32, "b_uint32/i")
+t.Branch("b_uint64", b_uint64, "b_uint64/l")
+
+rows = [
+    (200,  60000, 4000000000, 18000000000000000000),
+    (255,  65535, 4294967295, 18446744073709551615),
+    (1,    1,     1,          1),
+]
+
+for u8, u16, u32, u64 in rows:
+    b_uint8[0]  = u8
+    b_uint16[0] = u16
+    b_uint32[0] = u32
+    b_uint64[0] = u64
+    t.Fill()
+
+t.Write()
+f.Close()
+print("Written unsigned_integers.root")