TH1_3 not defined

[PatriceLebrun]

I use for the first time and I try to read a TH1F histogram produced with GEANT4
But I got the following issue:

julia> f = ROOTFile("/Users/lebrun/Desktop/dedx2COMET.root")
ROOTFile with 1 entry and 53 streamers.
/Users/lebrun/Desktop/dedx2COMET.root
└─ h1 (TH1D)

julia> f["h1"]
ERROR: UndefVarError: TH1_3 not defined

Did I make a trivial error ?

[Moelf]

UnROOT.jl/src/bootstrap.jl

Lines 79 to 85 in 7d37122

	abstract type TH1 <: ROOTStreamedObject end
	struct TH1_8 <: TH1 end
	function readfields!(io, fields, T::Type{TH1_8}) end
	abstract type TH2 <: ROOTStreamedObject end
	struct TH2_4 <: TH2 end
	function readfields!(io, fields, T::Type{TH2_4}) end

I think we just don't have bootstrap for that type here

[Moelf]

idk how this works, looks like it does literally nothing, but if you want, try adding these two lines

 struct TH1_3 <: TH1 end 
 function readfields!(io, fields, T::Type{TH1_3}) end 

[PatriceLebrun]

I added the two lines from Moelf in bootstrap.jl which fixed this issue but I need to do the same sort of thing for many other types (TAxis_ , TAttAxis_ TNamed_ , ...) and at the end I got the following error:
ERROR: Object 'UnROOT.TAttAxis' has 40 bytes; expected 3180234308

(geant4-v11.0.1 , OS: Ubuntu 20.04.4 LTS)

[Moelf]

can you send an example file?

[PatriceLebrun]

Hi Jerry, Here is this very simple root file having only one TH1D histogram which I can’t read with UnROOT

…

Le 11 mai 2022 à 17:33, Jerry Ling ***@***.***> a écrit : can you send an example file? — Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKNFOYO5JTEIRLMGXPFAQP3VJPHL5ANCNFSM5VSACI5A>. You are receiving this because you authored the thread.

[Moelf]

sorry I can't see your file

[PatriceLebrun]

What do you mean by you can’t see the file ? I attached it again in this email.

…

Le 11 mai 2022 à 19:50, Jerry Ling ***@***.***> a écrit : sorry I can't see your file — Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKNFOYNCWXTOLJS3AGG6NXTVJPXNJANCNFSM5VSACI5A>. You are receiving this because you authored the thread.

[Moelf]

you're not sending email to me directly, see: #168

[PatriceLebrun]

Here is the file concerned

dedx2COMET.root.gz

[PatriceLebrun]

Oups sorry. I just send a .gz file

…

Le 11 mai 2022 à 20:03, Jerry Ling ***@***.***> a écrit : you're not sending email to me directly, see: #168 <#168> — Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKNFOYIZKBWUTD66RTGCEYDVJPY6DANCNFSM5VSACI5A>. You are receiving this because you authored the thread.

[Moelf]

looks like this is the difference between

# this issue
In [3]: f = up.open("./dedx2COMET.root")

In [4]: f.keys()
Out[4]: ['h1;1']

In [5]: f["h1"]
Out[5]: <TH1D (version 1) at 0x7f07b281ce20>

In [6]: f["h1"]
Out[6]: <TH1D (version 1) at 0x7f07b281ce20>

# what UnROOT.jl knows how to handle
In [4]: f["myTH1D"]
Out[4]: <TH1D (version 2) at 0x7fa9a22892b0>

I don't have experience in hunting down different internal version of ROOT object, asking @tamasgal

[aminnj]

In case it helps, you could try to copy the current structs and modify them based on these differences

root [27] TH1::Class()->GetStreamerInfo(3)->ls()

StreamerInfo for class: TH1, version=3, checksum=0x5668b3d7
  TNamed         BASE            offset=  0 type=67 The basis for a named object (name, title)
  TAttLine       BASE            offset= 64 type= 0 Line attributes
  TAttFill       BASE            offset= 80 type= 0 Fill area attributes
  TAttMarker     BASE            offset= 96 type= 0 Marker attributes
  Int_t          fNcells         offset=112 type= 3 number of bins(1D), cells (2D) +U/Overflows
  TAxis          fXaxis          offset=120 type=61 X axis descriptor
  TAxis          fYaxis          offset=336 type=61 Y axis descriptor
  TAxis          fZaxis          offset=552 type=61 Z axis descriptor
  Short_t        fBarOffset      offset=768 type= 2 (1000*offset) for bar charts or legos
  Short_t        fBarWidth       offset=770 type= 2 (1000*width) for bar charts or legos
  Stat_t         fEntries        offset=776 type= 8 Number of entries
  Stat_t         fTsumw          offset=784 type= 8 Total Sum of weights
  Stat_t         fTsumw2         offset=792 type= 8 Total Sum of squares of weights
  Stat_t         fTsumwx         offset=800 type= 8 Total Sum of weight*X
  Stat_t         fTsumwx2        offset=808 type= 8 Total Sum of weight*X*X
  Double_t       fMaximum        offset=816 type= 8 Maximum value for plotting
  Double_t       fMinimum        offset=824 type= 8 Minimum value for plotting
  Double_t       fNormFactor     offset=832 type= 8 Normalization factor
  TArrayD        fContour        offset=840 type=62 Array to display contour levels
  TArrayD        fSumw2          offset=864 type=62 Array of sum of squares of weights
  TString        fOption         offset=888 type=65 histogram options
  TList*         fFunctions      offset=912 type=63 ->Pointer to list of functions (fits and user)
   i= 0, TNamed          type= 67, offset=  0, len=1, method=0
   i= 1, TAttLine        type=  0, offset= 64, len=1, method=0
   i= 2, TAttFill        type=  0, offset= 80, len=1, method=0
   i= 3, TAttMarker      type=  0, offset= 96, len=1, method=0
   i= 4, fNcells         type=  3, offset=112, len=1, method=0
   i= 5, fXaxis          type= 61, offset=120, len=1, method=0
   i= 6, fYaxis          type= 61, offset=336, len=1, method=0
   i= 7, fZaxis          type= 61, offset=552, len=1, method=0
   i= 8, fBarOffset      type= 22, offset=768, len=2, method=0 [optimized]
   i= 9, fEntries        type= 28, offset=776, len=8, method=0 [optimized]
   i=10, fContour        type= 62, offset=840, len=1, method=0
   i=11, fSumw2          type= 62, offset=864, len=1, method=0
   i=12, fOption         type= 65, offset=888, len=1, method=0
   i=13, fFunctions      type= 63, offset=912, len=1, method=0

root [28] TH1::Class()->GetStreamerInfo(8)->ls()

StreamerInfo for class: TH1, version=8, checksum=0x1c3740c4
  TNamed         BASE            offset=  0 type=67 The basis for a named object (name, title)
  TAttLine       BASE            offset= 64 type= 0 Line attributes
  TAttFill       BASE            offset= 80 type= 0 Fill area attributes
  TAttMarker     BASE            offset= 96 type= 0 Marker attributes
  int            fNcells         offset=112 type= 3 number of bins(1D), cells (2D) +U/Overflows
  TAxis          fXaxis          offset=120 type=61 X axis descriptor
  TAxis          fYaxis          offset=336 type=61 Y axis descriptor
  TAxis          fZaxis          offset=552 type=61 Z axis descriptor
  short          fBarOffset      offset=768 type= 2 (1000*offset) for bar charts or legos
  short          fBarWidth       offset=770 type= 2 (1000*width) for bar charts or legos
  double         fEntries        offset=776 type= 8 Number of entries
  double         fTsumw          offset=784 type= 8 Total Sum of weights
  double         fTsumw2         offset=792 type= 8 Total Sum of squares of weights
  double         fTsumwx         offset=800 type= 8 Total Sum of weight*X
  double         fTsumwx2        offset=808 type= 8 Total Sum of weight*X*X
  double         fMaximum        offset=816 type= 8 Maximum value for plotting
  double         fMinimum        offset=824 type= 8 Minimum value for plotting
  double         fNormFactor     offset=832 type= 8 Normalization factor
  TArrayD        fContour        offset=840 type=62 Array to display contour levels
  TArrayD        fSumw2          offset=864 type=62 Array of sum of squares of weights
  TString        fOption         offset=888 type=65 histogram options
  TList*         fFunctions      offset=912 type=63 ->Pointer to list of functions (fits and user)
  int            fBufferSize     offset=920 type= 6 fBuffer size
  double*        fBuffer         offset=928 type=48 [fBufferSize] entry buffer
  TH1::EBinErrorOpt fBinStatErrOpt  offset=968 type= 3 option for bin statistical errors
  TH1::EStatOverflows fStatOverflows  offset=972 type= 3 per object flag to use under/overflows in statistics
   i= 0, TNamed          type= 67, offset=  0, len=1, method=0
   i= 1, TAttLine        type=  0, offset= 64, len=1, method=0
   i= 2, TAttFill        type=  0, offset= 80, len=1, method=0
   i= 3, TAttMarker      type=  0, offset= 96, len=1, method=0
   i= 4, fNcells         type=  3, offset=112, len=1, method=0
   i= 5, fXaxis          type= 61, offset=120, len=1, method=0
   i= 6, fYaxis          type= 61, offset=336, len=1, method=0
   i= 7, fZaxis          type= 61, offset=552, len=1, method=0
   i= 8, fBarOffset      type= 22, offset=768, len=2, method=0 [optimized]
   i= 9, fEntries        type= 28, offset=776, len=8, method=0 [optimized]
   i=10, fContour        type= 62, offset=840, len=1, method=0
   i=11, fSumw2          type= 62, offset=864, len=1, method=0
   i=12, fOption         type= 65, offset=888, len=1, method=0
   i=13, fFunctions      type= 63, offset=912, len=1, method=0
   i=14, fBufferSize     type=  6, offset=920, len=1, method=84435080
   i=15, fBuffer         type= 48, offset=928, len=1, method=920
   i=16, fBinStatErrOpt  type= 23, offset=968, len=2, method=0 [optimized]

and similar for TAxis 6 vs 10. I didn't get further than that because of an EOF error :(

[MTerwissen]

I'm currently experiencing the same situation with TH1_6 not defined and wanted to check if there has been any progress / new input regarding this.
As above just copy pasting the struct for TAxis gives me an EOF error as well, I've attached the .root file as a .zip just in case.
DataSample_search.zip

[Moelf]

Can you easily check how old those root files are? I feel like we must haven't experience this because we have been testing with new files

[MTerwissen]

They are at least from 2013 since they are part of the supplementary material of a statistics book we are working with that got published in that year I can ask if there's a more exact date but I doubt it, so your guess is likely correct since you mentionted most tests were made with NanoAOD files.