only call sizeof on isbits types (#275)

* only call sizeof on isbits

* test broadcast over strings

* Update src/broadcast.jl

Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>

---------

Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>

Author: rafaqz

src/broadcast.jl

@@ -70,15 +70,19 @@ function common_chunks(s, args...)
     all(ar -> isa(eachchunk(ar), GridChunks), chunkedarrays) ||
         error("Currently only chunks of type GridChunks can be merged by broadcast")
     if isempty(chunkedarrays)
-        totalsize = sum(sizeof ∘ eltype, args)
-        return estimate_chunksize(s, totalsize)
+        # Estimate chunk size for isbits
+        if all(map(isbits ∘ eltype, args))
+            return estimate_chunksize(s)
+        else # Otherwise just use one huge chunk, we dont know what the object is
+            return GridChunks(s, s)
+        end
     elseif length(chunkedarrays) == 1
         return eachchunk(only(chunkedarrays))
     else
         allchunks = collect(map(eachchunk, chunkedarrays))
         tt = ntuple(N) do n
             csnow = filter(allchunks) do cs
-            ndims(cs) >= n && first(first(cs.chunks[n])) < last(last(cs.chunks[n]))
+                ndims(cs) >= n && first(first(cs.chunks[n])) < last(last(cs.chunks[n]))
             end
             isempty(csnow) && return RegularChunks(1, 0, s[n])
 

test/runtests.jl

@@ -1168,6 +1168,12 @@ end
     @inferred DiskArrays.DiskIndex(a_view6, (1:1, 1:1, 1:1, 1:1, 1:1, 1:1), DiskArrays.NoBatch()) #DiskArrays.DiskIndex
 end
 
+
+@testset "test broadcast over strings" begin
+    a = UnchunkedDiskArray(["a", "b", "c"])
+    @test all(a .== ["a", "b", "c"])
+end
+                
 @testset "mockchunks" begin
     a =UnchunkedDiskArray(rand(10,10))
     chunks = DiskArrays.RegularChunks.((5,5), (0,0), (10,10))