Ensure compilation happens after logging starts

[timholy]

If compilation of the workload happens before the logging system is
initialized, many CodeInstances may be missed. This exploits
Core.@latestworld to prevent inference from proceeding into the
workload. It removes the @force_compile, which introduces
some risk that even the workload will be interpreted.

Also wraps the @setup_workload block with a let.

Fixes #17
Fixes #26
Fixes #37
Closes #40
Closes JuliaLang/julia#57957

CC @vtjnash

[timholy]

Weird. Those tests pass locally for me. I'm guessing it's a coverage thing.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.81%. Comparing base (1e738ac) to head (e5ec2f6).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files           3        3           
  Lines          77       77           
=======================================
  Hits           63       63           
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[KristofferC]

Is there something that can be backported to a pre-1.12+ julia PrecompileTools version so that the compile fixes are also available there?

[timholy]

No, Core.@invokelatest was only added in Julia 1.12. EDIT: although it's possible that hiding the ccall behind a @noinline could help a bit.

[KristofferC]

Core.@latestworld I guess we mean.

although it's possible that hiding the ccall behind a @noinline could help a bit.

Or maybe @invokelatest tag_newly_inferred_enable()... I'm just throwing out stuff

[timholy]

Yes I meant Core.@latestworld, sorry. I (strongly) doubt the @invokelatest would help.

[timholy]

I could add a branch for pre-Julia 1.12 to make it easier to continue to support older releases. Since this repo is JuliaLang, any preferred naming convention? If not I may use before-julia-1.12.

[vtjnash]

Before v1.12, you could conditionally define something like macro latestworld() esc(Expr(:toplevel, nothing)) end to attempt to influence the heuristics (or perhaps Expr(:copyast, nothing) if forced toplevel is too strong)