AnnotatedString rendering seems buggy on 1.14 (vs 1.13)

[KristofferC]

Below might only repro if there is a colorscheme used that has rainbow brackets non-default. I'll update with something that should probably work everywhere.

julia> str = Base.AnnotatedString{String}("foo [endz] bar", [(5:5, :face, :julia_rainbow_bracket_1), (10:10, :face, :julia_rainbow_bracket_1)]);

1.13:

1.14:

Potentially #60212 which would suggest JuliaLang/StyledStrings.jl@9bb8ffd but this is purely guess work.

[fingolfin]

ping @tecosaur

[KristofferC]

Here is a simpler example (from the docs):

julia> StyledStrings.withfaces(:yellow => StyledStrings.Face(foreground=:red), :green => :blue) do
           println(stdout, styled"{yellow:red} and {green:blue} mixed make {magenta:purple}")
       end

[tecosaur]

Thanks for the ping, I'll take a look at what's going on.

[KristofferC]

Bump. Should we revert JuliaLang/StyledStrings.jl@9bb8ffd for now @tecosaur?

[tecosaur]

That could be done as a stop-gap, but it seems worth noting that I am unable to reproduce these issues with #60527, which is the conclusion of what this work was getting us partway to.

The large PR to StyledStrings that pulls in (JuliaLang/StyledStrings.jl#131) is still in-flight. Cody has expressed an interest in reviewing it some time next week, and I'm interested in hearing his thoughts since in large part the design was developed through conversations I had with Cody. Max has given half of it a look in the meantime, and it did seem sensible to him at least.

Based on this, I'd be inclined to see if JuliaLang/StyledStrings.jl#131 then #60527 are merged next week, and if not revert JuliaLang/StyledStrings.jl@9bb8ffd for the interim.

How does that sound to you?

[KristofferC]

How does that sound to you?

It sounds like this is still bugged after months. Can we just revert / fix the problem..?

[tecosaur]

Yep, let's just do that for now.

[KristofferC]

I looked into this a bit more and this happens because I had a custom faces.toml with some faces set to "default". JuliaLang/StyledStrings.jl@9bb8ffd changed from looking at color.value === :default to looking at color.value === :foreground and color.value === :background. Is my faces.toml faulty or how should it be done?