solvers / codecov ++

Author: kellertuer

src/plans/count.jl

@@ -60,7 +60,7 @@ function ManifoldCountObjective(
 end
 # Store the undecorated type of the input is decorated
 function ManifoldCountObjective(
-        ::AbstractManifold, objective::O, counts::Dict{Symbol, I}
+        objective::O, counts::Dict{Symbol, I}
     ) where {
         E <: AbstractEvaluationType,
         I <: Union{<:Integer, AbstractVector{<:Integer}},

src/solvers/quasi_Newton.jl

@@ -134,12 +134,12 @@ function get_message(qns::QuasiNewtonState)
     return d
 end
 function Base.show(io::IO, qns::QuasiNewtonState)
-    print(io, "QuasiNewtonState(;")
-    print(io, "direction_update = $(qns.direction_update), ")
-    print(io, "p = ", qns.p, ", p_old = ", qns.p_old, ", η = ", qns.η, ", X = ", qns.X, ", sk = ", qns.sk, ", yk = ", qns.yk, ", ")
+    print(io, "QuasiNewtonState(; ")
+    print(io, "direction_update = ", qns.direction_update, ", p = ", qns.p, ", p_old = ", qns.p_old)
+    print(io, ", η = ", qns.η, ", X = ", qns.X, ", sk = ", qns.sk, ", yk = ", qns.yk, ", ")
     print(io, "nondescent_direction_behavior = ", qns.nondescent_direction_behavior, ", nondescent_direction_value = ", qns.nondescent_direction_value, ", ")
     print(io, "preconditioner = ", qns.preconditioner, ", retraction_method = ", qns.retraction_method, ", stepsize = ", qns.stepsize, ", ")
-    print(io, "stopping_criertion = ". qns.stop, ", X_old = ", qns.X_old, ", vector_transport_method = ", qns.vector_transport_method)
+    print(io, "stopping_critertion = ", qns.stop, ", X_old = ", qns.X_old, ", vector_transport_method = ", qns.vector_transport_method)
     return print(io, ")")
 end
 function status_summary(qns::QuasiNewtonState; context::Symbol = :default)

test/solvers/test_convex_bundle_method.jl

@@ -41,6 +41,8 @@ using Manopt: estimate_sectional_curvature
         stepsize = Manopt.DomainBackTrackingStepsize(M; contraction_factor = 0.975),
         stopping_criterion = StopAfterIteration(200),
     )
+    # A state can not be created with just a manifold and a substate, then the problem is missing
+    @test_throws ErrorException ConvexBundleMethodState(M, Manopt.Test.DummyState())
     @test get_iterate(cbms) == p0
     cbms.X = [1.0, 0.0, 0.0, 0.0, 0.0]
 

test/solvers/test_quasi_Newton.jl

@@ -57,13 +57,8 @@ end
         @test norm(x_lrbfgs - x_solution) ≈ 0 atol = 10.0^(-14)
         # with State
         lrbfgs_s = quasi_Newton(
-            M,
-            f,
-            grad_f,
-            p;
-            stopping_criterion = StopWhenGradientNormLess(10^(-6)),
-            return_state = true,
-            debug = [],
+            M, f, grad_f, p;
+            stopping_criterion = StopWhenGradientNormLess(10^(-6)), return_state = true, debug = [],
         )
         # Verify that Newton update direction works also allocating
         dmp = DefaultManoptProblem(M, ManifoldGradientObjective(f, grad_f))
@@ -76,6 +71,7 @@ end
             Manopt.status_summary(lrbfgs_s; context = :default),
             "# Solver state for `Manopt.jl`s Quasi Newton Method\n"
         )
+        @test startswith(repr(lrbfgs_s), "QuasiNewtonState(; ")
         @test get_last_stepsize(dmp, lrbfgs_s, lrbfgs_s.stepsize) > 0
         @test Manopt.get_iterate(lrbfgs_s) == x_lrbfgs
         set_gradient!(lrbfgs_s, M, p, grad_f(M, p))