Skip to content

Commit 4176eb3

Browse files
committed
fix CG test, add some type constraints for clarity
1 parent 3526605 commit 4176eb3

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/plans/stepsize/stepsize.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,11 +74,11 @@ mutable struct ArmijoLinesearchStepsize{TRM <: AbstractRetractionMethod, P, I, F
7474
initial_guess::IGF = ArmijoInitialGuess(),
7575
retraction_method::TRM = default_retraction_method(M),
7676
stop_when_stepsize_less::F = 0.0,
77-
stop_when_stepsize_exceeds = max_stepsize(M),
77+
stop_when_stepsize_exceeds::Real = max_stepsize(M),
7878
stop_increasing_at_step::I = 100,
7979
stop_decreasing_at_step::I = 1000,
8080
sufficient_decrease = 0.1,
81-
) where {TRM, P, I, F, IGF, DF, IF}
81+
) where {TRM <: AbstractRetractionMethod, P, I, F <: Real, IGF <: AbstractInitialLinesearchGuess, DF, IF}
8282
msgs = (;
8383
non_descent_direction = StepsizeMessage{F, F}(),
8484
stop_decreasing = StepsizeMessage{Int, F}(),

test/solvers/test_conjugate_gradient.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ using LinearAlgebra: Diagonal, dot, eigvals, eigvecs
327327

328328
stopping_criterion = StopAfterIteration(30)
329329
get_stepsize() = Manopt.ArmijoLinesearchStepsize(
330-
M; initial_stepsize = 1.0, initial_guess = (args...) -> 1.0
330+
M; initial_stepsize = 1.0, initial_guess = Manopt.ConstantInitialGuess(1.0)
331331
)
332332

333333
p1 = conjugate_gradient_descent(

0 commit comments

Comments
 (0)