Skip to content

Commit 569a69c

Browse files
Apply suggestions from code review
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
1 parent 2aedfb2 commit 569a69c

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

Changelog.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ We also unified a few of the internal solver state constructors.
2626
* In the [Riemannian Levenberg Marquardt algorithm](https://manoptjl.org/stable/solvers/LevenbergMarquardt/)t the `η` parameter has been renamed to `candidate_acceptance_threshold`, `β` to `damping_increase_factor` and `β_reduction` to `damping_reduction_factor`. (#617)
2727
* the constructor for the [Levenberg-Marquardt state](https://manoptjl.org/stable/solvers/LevenbergMarquardt/#Manopt.LevenbergMarquardtState) has been unified with the remaining states, to take the `sub_problem` and `sub_state` arguments as second and third positional arguments, respectively. (#617)
2828
* the keyword `initial_jacobian_f` within `LevenbergMarquardt` is unified in naming to the residual values vector and called `initial_jacobian_matrices`. If you call `LevenbergMarquardt` with a single vector component, also a single matrix is allowed. (#617)
29-
* an internal field of the solver state of Levenberg-Marqwuardt was called `jacobian_f` the same as the functions whose result it meant to cache if applicable. To distinguish both, the field is now called `jacobian_matrices`. (#617)
29+
* an internal field of the solver state of Levenberg-Marquardt was called `jacobian_f` the same as the functions whose result it meant to cache if applicable. To distinguish both, the field is now called `jacobian_matrices`. (#617)
3030
* title of "How to define the cost in the embedding" tutorial (#615)
3131

3232
### Fixed

docs/src/notation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ with the following additional parts.
1010
| ``\mathcal{A}, \mathcal{L}`` | linear operators, usually on tangent spaces | | |
1111
| ``\mathcal{C}`` | a (geodesically) convex set | | |
1212
| ``\operatorname*{arg\,min}_v`` | argument/variable ``v`` of a function ``f`` where a local or global minimum is attained | |
13-
| ``k`` | the current iterate | ``i`` | the goal is to unify this to `k` |
13+
| ``k`` | the current iteration | ``i`` | the goal is to unify this to `k` |
1414
| ```` | The [Levi-Cevita connection](https://en.wikipedia.org/wiki/Levi-Civita_connection) | | |

0 commit comments

Comments
 (0)