Cast max_stepsize in Mesh Adaptive Direct Seach (#526) (#527)

* Cast max_stepsize in Mesh Adaptive Direct Seach (#526)
* Format code and update Changelog.md
* Update test/solvers/test_mesh_adaptive_direct_search.jl
* Update Manifolds.jl dependency to v11.0.2

---------

Co-authored-by: Ronny Bergmann <git@ronnybergmann.net>

Author: sblelong

Changelog.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * fixed a few typos in the documentation strings of a few solvers.
 * fixed a typo in the documentation of `LevenbergMarquardt`.
 * fixed a bug in an internal tex command to print sums in the documentation.
+* fixed the use of `mesh_adaptive_direct_search` on manifolds with irrational injectivity radius.
 * improved the `CONTRIBUTING.md` to reflect the new code formatter we use, as mentioned in (#527).
 
 ## [0.5.25] October 9, 2025

Project.toml

@@ -50,7 +50,7 @@ LRUCache = "1.4"
 LineSearches = "7.2.0"
 LinearAlgebra = "1.10"
 ManifoldDiff = "0.3.8, 0.4"
-Manifolds = "0.10, 0.11"
+Manifolds = "0.11.2"
 ManifoldsBase = "1.1, 2"
 Markdown = "1.10"
 Plots = "1.30"

src/solvers/mesh_adaptive_direct_search.jl

@@ -96,7 +96,7 @@ function mesh_adaptive_direct_search!(
         p;
         mesh_basis = mesh_basis,
         scale_mesh = scale_mesh,
-        max_stepsize = max_stepsize,
+        max_stepsize = oftype(scale_mesh, max_stepsize),
         stopping_criterion = stopping_criterion,
         retraction_method = retraction_method,
         vector_transport_method = vector_transport_method,

test/solvers/test_mesh_adaptive_direct_search.jl

@@ -34,4 +34,14 @@ using Manifolds, Manopt, Test, LinearAlgebra, Random
     p_s2 = mesh_adaptive_direct_search!(M2, f2, p1; scale_mesh = 0.1)
     @test isapprox(M, p_s2, p1)
     @test distance(M2, p_s2, W2) < 1.0e-7
+    #
+    #
+    # An example on a sphere (to ensure type coherence between injectivity radii)
+    M3 = Sphere(2)
+    f3(M, p) = sum(p)
+    p2 = [-1.0, 0.0, 0.0]
+    s3 = mesh_adaptive_direct_search(M3, f3, p2; return_state = true)
+    p3 = get_solver_result(s3)
+    @test f3(M3, p3) < f3(M3, p2)
+    @test is_point(M3, p3; error = :error)
 end