unify tests.

Author: kellertuer

src/plans/stopping_criterion.jl

@@ -528,7 +528,7 @@ function get_reason(c::StopWhenRelativeAPosterioriCostChangeLessOrEqual)
     end
     return ""
 end
-function status_summary(c::StopWhenRelativeAPosterioriCostChangeLessOrEqual; context::Symbol = short)
+function status_summary(c::StopWhenRelativeAPosterioriCostChangeLessOrEqual; context::Symbol = :default)
     (context == :short) && return repr(c)
     has_stopped = (c.at_iteration >= 0)
     s = has_stopped ? "reached" : "not reached"

test/plans/test_stopping_criteria.jl

@@ -403,15 +403,18 @@ end
         @test sc(prob, s, 2)
         @test length(get_reason(sc)) > 0
         @test startswith(
-            to_display_string(sc),
-            "StopWhenRelativeAPosterioriCostChangeLessOrEqual with threshold",
+            Manopt.status_summary(sc),
+            "A stopping criterion to stop when the relative posteriori cost change is less than",
         )
-        @test startswith(Manopt.status_summary(sc), "(fₖ- fₖ₊₁)/max(|fₖ|, |fₖ₊₁|, 1) = ")
+        @test startswith(Manopt.status_summary(sc; context = :inline), "(fₖ- fₖ₊₁)/max(|fₖ|, |fₖ₊₁|, 1) = ")
         @test !Manopt.indicates_convergence(sc)
     end
 
     @testset "StopWhenProjectedNegativeGradientNormLess" begin
         sc = StopWhenProjectedNegativeGradientNormLess(1.0e-10)
+        @test startswith(repr(sc), "StopWhenProjectedNegativeGradientNormLess(")
+        @test startswith(Manopt.status_summary(sc), "A StoppingCriterion to stop when the negative projected gradient norm is less than")
+
         M = Hyperrectangle([1.0], [2.0])
         prob = DefaultManoptProblem(
             M, ManifoldGradientObjective((M, x) -> x^2, x -> 2x)

test/solvers/test_quasi_Newton_box.jl

@@ -315,12 +315,6 @@ using RecursiveArrayTools
         p_opt = quasi_Newton(M, f, grad_f, p0; stopping_criterion = StopWhenProjectedNegativeGradientNormLess(1.0e-6) | StopAfterIteration(100))
         @test distance(M, p_opt, ArrayPartition(px, [0 2; 0 0])) < 0.1
     end
-
-    @testset "Specialised Stopping criteria" begin
-        sc = StopWhenProjectedNegativeGradientNormLess(1.0e-9)
-        @test startswith(repr(sc), "StopWhenProjectedNegativeGradientNormLess(1.0e-9")
-        @test startswith(Manopt.status_summary(sc), "A StoppingCriterion to stop when the negative projected gradient norm is less than")
-    end
 end
 
 @testset "MaxStepsizeInDirection" begin