Remove limits_box (#1261)

Author: pkofod

src/multivariate/solvers/constrained/fminbox.jl

@@ -145,27 +145,6 @@ function NLSolversBase.value_jvp!(obj::BarrierWrapper, x, v)
     return obj.Ftotal, JVPtotal
 end
 
-function limits_box(
-    x::AbstractArray{T},
-    d::AbstractArray{T},
-    l::AbstractArray{T},
-    u::AbstractArray{T},
-) where {T}
-    alphamax = convert(T, Inf)
-    @inbounds for i in eachindex(x)
-        if d[i] < 0
-            alphamax = min(alphamax, ((l[i] - x[i]) + eps(l[i])) / d[i])
-        elseif d[i] > 0
-            alphamax = min(alphamax, ((u[i] - x[i]) - eps(u[i])) / d[i])
-        end
-    end
-    epsilon = eps(max(alphamax, one(T)))
-    if !isinf(alphamax) && alphamax > epsilon
-        alphamax -= epsilon
-    end
-    return alphamax
-end
-
 # Default preconditioner for box-constrained optimization
 # This creates the inverse Hessian of the barrier penalty
 function precondprepbox!(P, x, l, u, dfbox)

src/multivariate/solvers/first_order/cg.jl

@@ -38,9 +38,8 @@
 #   exterior points. It's just more efficient if you know the
 #   maximum, because you don't have to test values that won't
 #   work.) The maximum should be specified as the largest value for
-#   which a finite value will be returned.  See, e.g., limits_box
-#   below.  The default value for alphamax is Inf. See alphamaxfunc
-#   for cgdescent and alphamax for linesearch_hz.
+#   which a finite value will be returned. The default value for
+#   alphamax is Inf.
 
 struct ConjugateGradient{Tf,T,Tprep,IL,L} <: FirstOrderOptimizer
     eta::Tf