fix: temp patch for value after error

Author: pankgeorg

renderer/components/PlutoOutput.tsx

@@ -12,6 +12,7 @@ import {
   setup_mathjax,
   useState,
   useErrorBoundary,
+  useMemo,
 } from "@plutojl/rainbow/ui";
 import { type RendererContext } from "vscode-notebook-renderer";
 
@@ -85,7 +86,35 @@ export function PlutoOutput({ state, context }: PlutoOutputProps) {
     });
     return () => d?.dispose();
   }, [state.cell_id, context]);
+
+  const OUTPUT = useMemo(() => {
+    // This is probably a bug in the immer bundling; the mime edits don't propagate ;/
+    // TODO: @pankgeorg investigate pls
+    const fixedMime =
+      localState.output.mime === "application/vnd.pluto.stacktrace+object" &&
+      (typeof localState.output.body !== "object" ||
+        !("stacktrace" in localState.output.body))
+        ? "text/plain"
+        : localState.output.mime;
+    if (localState.output?.mime)
+      return html`<${OutputBody}
+    persist_js_state="${localState.output.persist_js_state}"
+    body="${localState.output?.body}"
+    mime="${fixedMime}"
+    sanitize_html="${false /* Maybe reconsider */}"
+  ></${OutputBody}>`;
+    return "Loading...";
+  }, [
+    localState,
+    localState.cell_id,
+    localState.output.mime,
+    localState.output.body,
+    localState.running,
+    localState.errored,
+  ]);
+
   if (error) {
+    console.error(error);
     return html`<div onclick=${resetError}>
       An error occured. Click <button onClick=${resetError}>here</button> to
       reset the view
@@ -108,14 +137,7 @@ export function PlutoOutput({ state, context }: PlutoOutputProps) {
         ></progress>
       </div>`
     : null}
-  ${localState.output?.mime
-    ? html`<${OutputBody}
-    persist_js_state="${localState.output.persist_js_state}"
-    body="${localState.output?.body}"
-    mime="${localState.output?.mime}"
-    sanitize_html="${false /* Maybe reconsider */}"
-  ></${OutputBody}>`
-    : "Loading..."}
+  ${OUTPUT}
   ${terminal?.length
     ? html`<details>
           <summary>stdout</summary>

src/controller.ts

@@ -383,12 +383,31 @@ export class PlutoNotebookController {
     //   );
     // }
   }
+  private updateAllCellsFromState = (
+    notebook: vscode.NotebookDocument,
+    update: UpdateEvent
+  ) => {
+    // Optimistically send data. May be ignored.
+    // If not ignored, this makes sure logs, stdout and progress
+    // is communicated
+    const fullNotebookState = update.notebook;
+    Object.entries(fullNotebookState?.cell_results ?? {}).forEach(
+      ([cell_id, state]) => {
+        this.sendMessageToRenderer(notebook, {
+          type: "setState",
+          state,
+          cell_id,
+        });
+      }
+    );
+  };
 
   /**
    * Handles streaming updates from the Pluto worker via patches.
    */
   private onPlutoNotebookUpdate = (notebook: vscode.NotebookDocument) => {
     return (event: UpdateEvent) => {
+      console.log({ event });
       try {
         const patches = event.data?.patches as Patch[] | undefined;
         const fullNotebookState = event.notebook;
@@ -399,7 +418,7 @@ export class PlutoNotebookController {
           );
           return;
         }
-
+        let anyWeird = false;
         for (const patch of patches) {
           const path = patch.path;
           const [action, ...rest] = path;
@@ -462,12 +481,18 @@ export class PlutoNotebookController {
             case "last_save_time":
               break;
             default:
+              anyWeird = true;
               this.outputChannel.appendLine(
                 `[UNHANDLED]  ${patch.path.join(".")} action ${patch.op}`
               );
           }
         }
+        if (anyWeird) {
+          console.log("Not sure if all ok, updating everything");
+          this.updateAllCellsFromState(notebook, event);
+        }
       } catch (e: unknown) {
+        this.updateAllCellsFromState(notebook, event);
         this.outputChannel.appendLine(
           `Failed to process patch update: ${
             e instanceof Error ? e.message : String(e)

src/serializer.ts

@@ -30,7 +30,6 @@ export class PlutoNotebookSerializer implements vscode.NotebookSerializer {
         pluto_notebook_id: parsed.notebook_id,
         pluto_version: parsed.pluto_version,
       };
-
       return notebookData;
     } catch (error) {
       // Fallback: treat as single code cell if parsing fails