`detect_piracies` misses some cases

[timholy]

The following is an example of piracy, but it is not caught by test_piracies:

julia> using TestEnv; TestEnv.activate(); cd("test")

julia> using Aqua

julia> module Pirate
       using IntervalSets

       Base.:+(iv::ClosedInterval, n::Real) = minimum(iv) + n .. maximum(iv) + n
       end
Main.Pirate

julia> Aqua.test_piracies(Pirate)
Test Passed

julia> using IntervalSets

julia> (1 .. 3) + 2
3 .. 5

[timholy]

Because ClosedInterval{T} = Interval{:closed, :closed, T}, this turns out to be a side effect of how Symbols are handled:

Aqua.jl/src/piracies.jl

Lines 59 to 86 in cdc679f

	# Symbols can be used as type params - we assume these are unique and not
	# piracy. This implies that we have
	#
	# julia> Aqua.Piracy.is_foreign(1, Base.PkgId(Aqua))
	# true
	#
	# julia> Aqua.Piracy.is_foreign(:hello, Base.PkgId(Aqua))
	# false
	#
	# and thus
	#
	# julia> Aqua.Piracy.is_foreign(Val{1}, Base.PkgId(Aqua))
	# true
	#
	# julia> Aqua.Piracy.is_foreign(Val{:hello}, Base.PkgId(Aqua))
	# false
	#
	# Admittedly, this asymmetry is rather worrisome. We do need to treat 1 foreign
	# to consider `Vector{Char}` (i.e., `Array{Char,1}`) foreign. This may suggest
	# to treat the `Symbol` type foreign as well. However, it means that we treat
	# definition such as
	#
	# ForeignModule.api_function(::Val{:MyPackageName}) = ...
	#
	# as a type piracy even if this is actually the intended use-case (which is not
	# a crazy API). The symbol name may also come from `gensym`. Since the aim of
	# `Aqua.test_piracies` is to detect only "obvious" piracies, let us play on the
	# safe side.

I would argue there is a cleaner solution: if that type and symbol combination appears in the "owning" module, it's piracy. Val{:MyPackageName} could not appear in ForeignModule so this would exempt that from piracy.