Merge PR #1071: role-aware navigation and protected route guards

Resolve ENV_VARIABLE_MATRIX by keeping main matrix format and adding VITE_ADMIN_WALLETS; combine ProtectedRoute/role routing with main App routes.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Junirezz

docs/ENV_VARIABLE_MATRIX.md

@@ -447,6 +447,14 @@ Note: Any `VITE_FF_*` variable is dynamically read via `import.meta.env["VITE_FF
 
 ---
 
+## 35a. Frontend — Role-Based Navigation
+
+| Variable | Default | Req. | Description | Source |
+|---|---|---|---|---|
+| `VITE_ADMIN_WALLETS` | _(empty)_ | ⬜ optional | Comma-separated wallet addresses granted the admin nav link and `/admin` route. Not a security boundary — ships in the client bundle | `frontend/src/lib/roles.ts` |
+
+---
+
 ## 36. Frontend — Sentry Error Monitoring
 
 | Variable | Default | Req. | Description | Source |

frontend/.env.example

@@ -6,6 +6,13 @@ VITE_STELLAR_NETWORK_PASSPHRASE=Test SDF Network ; September 2015
 VITE_VAULT_CONTRACT_ID=
 VITE_FF_ANALYTICS_PAGE=true
 
+# Comma-separated wallet addresses granted the "admin" role in the frontend
+# nav/route guards (see frontend/src/lib/roles.ts). Optional – leave blank to
+# disable the admin console for all wallets. Not a security boundary: this
+# ships in the client bundle, so privileged backend actions must still be
+# authorized server-side.
+VITE_ADMIN_WALLETS=
+
 # Sentry Error Monitoring (optional – leave blank to disable)
 VITE_SENTRY_DSN=
 SENTRY_AUTH_TOKEN=

frontend/.env.local.example

@@ -16,6 +16,9 @@ VITE_FF_DEBUG_MODE=true
 # Backend API URL - LOCAL
 VITE_API_BASE_URL=http://localhost:3000
 
+# Admin role allowlist - LOCAL (comma-separated wallet addresses)
+VITE_ADMIN_WALLETS=
+
 # Optional: Sentry Configuration - LOCAL (leave VITE_SENTRY_DSN blank to disable)
 # VITE_SENTRY_DSN=
 # SENTRY_AUTH_TOKEN=

frontend/.env.production.example

@@ -19,6 +19,10 @@ VITE_FF_DEBUG_MODE=false
 # Backend API URL - PRODUCTION
 VITE_API_BASE_URL=https://api.yieldvault.finance
 
+# Admin role allowlist - PRODUCTION (comma-separated wallet addresses)
+# CRITICAL: Only list wallets that should see the /admin console and nav link.
+VITE_ADMIN_WALLETS=
+
 # Sentry Configuration - PRODUCTION
 # CRITICAL: Use production Sentry DSN
 VITE_SENTRY_DSN=https://your-sentry-dsn@sentry.io/project-id

frontend/ROLE_BASED_NAVIGATION.md

@@ -0,0 +1,68 @@
+# Role-Based Navigation & Route Guards
+
+The app resolves a lightweight client-side `UserRole` from the connected
+wallet address and uses it to (a) show or hide navigation links and (b)
+gate routes that shouldn't be reachable by everyone.
+
+> [!IMPORTANT]
+> This is a UI convenience layer, **not** a security boundary. The admin
+> wallet allowlist ships in the client bundle, so any privileged action it
+> gates must still be authorized server-side (see
+> `backend/src/middleware/rbac.ts` for the real RBAC enforcement on admin
+> API endpoints).
+
+## Roles
+
+| Role | Resolved when | Notes |
+| :--- | :--- | :--- |
+| `guest` | No wallet connected | Default state before `WalletConnect` succeeds. |
+| `investor` | Wallet connected, not on the admin list | Normal vault user. |
+| `admin` | Wallet connected and address is in `VITE_ADMIN_WALLETS` | Sees the Admin nav link and can reach `/admin`. |
+
+Role resolution lives in `src/lib/roles.ts`:
+
+```ts
+import { resolveUserRole } from "./lib/roles";
+
+const role = resolveUserRole(walletAddress); // "guest" | "investor" | "admin"
+```
+
+`VITE_ADMIN_WALLETS` is a comma-separated list of Stellar wallet addresses
+(case-insensitive, whitespace-trimmed). Leave it blank to disable the admin
+role for everyone. See `.env.example` and `docs/ENV_VARIABLE_MATRIX.md`.
+
+## Nav Visibility
+
+`App.tsx` computes `role` from the connected wallet and passes it to
+`<Navbar role={role} />`. `Navbar` only renders the Admin link (desktop,
+mobile, and dropdown menus) when `role === "admin"`; every other existing
+link is unaffected.
+
+## Route Guards
+
+`<ProtectedRoute>` (`src/components/ProtectedRoute.tsx`) wraps a route
+element and redirects (via `<Navigate replace>`) when the current role
+isn't in the `allow` list:
+
+```tsx
+<Route
+  path="/admin"
+  element={
+    <ProtectedRoute role={role} allow={["admin"]}>
+      <Admin walletAddress={walletAddress} />
+    </ProtectedRoute>
+  }
+/>
+```
+
+- `redirectTo` defaults to `/` and can be overridden per route.
+- The attempted path is passed through `location.state.from` so a future
+  redirect target (e.g. after connecting a wallet) can restore it.
+
+## Adding a New Gated Route
+
+1. Add the role(s) allowed to `allow` when declaring the `<Route>` in `App.tsx`.
+2. If the route should also be hidden from nav for disallowed roles, gate the
+   `NavLink` in `Navbar.tsx` on `role` the same way the Admin link is gated.
+3. Add/extend tests in `src/lib/roles.test.ts` and
+   `src/components/ProtectedRoute.test.tsx` for new role combinations.

frontend/src/App.tsx

@@ -1,4 +1,4 @@
-import { lazy, Suspense, useCallback, useEffect, useState } from "react";
+import { lazy, Suspense, useCallback, useEffect, useMemo, useState } from "react";
 import { Navigate, Route, Routes, useLocation, useNavigate } from "react-router-dom";
 import * as Sentry from "@sentry/react";
 import Navbar from "./components/Navbar";
@@ -42,10 +42,13 @@ import OfflineBanner from "./components/OfflineBanner";
 import HighLatencyBanner from "./components/HighLatencyBanner";
 import { useVault, VaultProvider } from "./context/VaultContext";
 import { usePageViewTracking } from "./hooks/useAnalytics";
+import { ProtectedRoute } from "./components/ProtectedRoute";
+import { resolveUserRole } from "./lib/roles";
 
 const SentryRoutes = Sentry.withSentryReactRouterV6Routing(Routes);
 
 const TransactionReceipt = lazy(() => import("./pages/TransactionReceipt"));
+const Admin = lazy(() => import("./pages/Admin"));
 
 // Removed simple fallback in favor of components/ErrorFallback
 
@@ -59,6 +62,7 @@ function AppContent() {
   const { data: usdcBalance = 0 } = useUsdcBalance(walletAddress);
   const { data: xlmBalance = 0 } = useXlmBalance(walletAddress);
   const { tvl } = useVault();
+  const role = useMemo(() => resolveUserRole(walletAddress), [walletAddress]);
 
   useEffect(() => {
     if ((window as Window & { Cypress?: unknown }).Cypress) {
@@ -154,6 +158,7 @@ function AppContent() {
             usdcBalance={usdcBalance}
             onConnect={handleConnect}
             onDisconnect={handleDisconnect}
+            role={role}
           />
           <main id="main-content" className="container app-main" style={{ marginTop: "100px", paddingBottom: "60px" }}>
             <Suspense fallback={<RouteLoadingFallback />}>
@@ -189,6 +194,14 @@ function AppContent() {
                 <Route path="/receipt/:txHash" element={<TransactionReceipt />} />
                 <Route path="/settings" element={<LazySettings />} />
                 <Route path="/ui-kit" element={<LazyUIPreview />} />
+                <Route
+                  path="/admin"
+                  element={
+                    <ProtectedRoute role={role} allow={["admin"]}>
+                      <Admin walletAddress={walletAddress} />
+                    </ProtectedRoute>
+                  }
+                />
                 <Route path="*" element={<Navigate to="/" replace />} />
               </SentryRoutes>
             </Suspense>

frontend/src/components/Navbar.test.tsx

@@ -108,4 +108,74 @@ describe('Navbar', () => {
 
         expect(screen.getAllByText(/testnet|mainnet/i)[0]).toBeInTheDocument();
     });
+
+    it('does not show the Admin link by default (guest role)', () => {
+        render(
+            <MemoryRouter>
+                <QueryClientProvider client={queryClient}>
+                    <PreferencesProvider>
+                        <ToastProvider>
+                        <ThemeProvider>
+                            <Navbar
+                                walletAddress={null}
+                                onConnect={mockOnConnect}
+                                onDisconnect={mockOnDisconnect}
+                            />
+                        </ThemeProvider>
+                    </ToastProvider>
+                </PreferencesProvider>
+            </QueryClientProvider>
+            </MemoryRouter>
+        );
+
+        expect(screen.queryByText('Admin')).not.toBeInTheDocument();
+    });
+
+    it('shows the Admin link when role is admin', () => {
+        const fullAddress = 'GABC1234567890123456789012345678901234567890123456789012';
+        render(
+            <MemoryRouter>
+                <QueryClientProvider client={queryClient}>
+                    <PreferencesProvider>
+                        <ToastProvider>
+                        <ThemeProvider>
+                            <Navbar
+                                walletAddress={fullAddress}
+                                onConnect={mockOnConnect}
+                                onDisconnect={mockOnDisconnect}
+                                role="admin"
+                            />
+                        </ThemeProvider>
+                    </ToastProvider>
+                </PreferencesProvider>
+            </QueryClientProvider>
+            </MemoryRouter>
+        );
+
+        expect(screen.getAllByText('Admin')[0]).toBeInTheDocument();
+    });
+
+    it('does not show the Admin link for a connected investor wallet', () => {
+        const fullAddress = 'GABC1234567890123456789012345678901234567890123456789012';
+        render(
+            <MemoryRouter>
+                <QueryClientProvider client={queryClient}>
+                    <PreferencesProvider>
+                        <ToastProvider>
+                        <ThemeProvider>
+                            <Navbar
+                                walletAddress={fullAddress}
+                                onConnect={mockOnConnect}
+                                onDisconnect={mockOnDisconnect}
+                                role="investor"
+                            />
+                        </ThemeProvider>
+                    </ToastProvider>
+                </PreferencesProvider>
+            </QueryClientProvider>
+            </MemoryRouter>
+        );
+
+        expect(screen.queryByText('Admin')).not.toBeInTheDocument();
+    });
 });

frontend/src/components/Navbar.tsx

@@ -12,6 +12,7 @@ import { useWalletNetwork } from "../hooks/useWalletNetwork";
 import Badge from "./Badge";
 import { usePendingTransactionCount } from "../hooks/usePendingTransactionCount";
 import { getRoutePrefetchHandlers } from "../lib/routePrefetch";
+import type { UserRole } from "../lib/roles";
 
 interface NavbarProps {
   currentPath?: "/" | "/analytics" | "/portfolio";
@@ -20,13 +21,15 @@ interface NavbarProps {
   usdcBalance?: number;
   onConnect: (address: string) => void;
   onDisconnect: (reason?: DisconnectReason) => void;
+  role?: UserRole;
 }
 
 const Navbar: FC<NavbarProps> = ({
   walletAddress,
   usdcBalance = 0,
   onConnect,
   onDisconnect,
+  role = "guest",
 }) => {
   const { t } = useTranslation();
   const { walletNetwork, expectedNetwork } = useWalletNetwork(walletAddress);
@@ -131,6 +134,11 @@ const Navbar: FC<NavbarProps> = ({
                 </Badge>
               )}
             </NavLink>
+            {role === "admin" && (
+              <NavLink to="/admin" className="nav-link">
+                {t("nav.admin")}
+              </NavLink>
+            )}
           </div>
         </div>
 
@@ -214,6 +222,11 @@ const Navbar: FC<NavbarProps> = ({
               </Badge>
             )}
           </NavLink>
+          {role === "admin" && (
+            <NavLink to="/admin" onClick={() => setIsMobileMenuOpen(false)}>
+              {t("nav.admin")}
+            </NavLink>
+          )}
 
           <div className="flex items-center justify-between" style={{ marginTop: "24px" }}>
             <ThemeToggle />
@@ -245,6 +258,11 @@ const Navbar: FC<NavbarProps> = ({
               </Badge>
             )}
           </NavLink>
+          {role === "admin" && (
+            <NavLink to="/admin" role="menuitem" onClick={() => setMenuOpen(false)}>
+              {t("nav.admin")}
+            </NavLink>
+          )}
         </div>
       )}
     </nav>

frontend/src/components/ProtectedRoute.test.tsx

@@ -0,0 +1,61 @@
+import { render, screen } from "@testing-library/react";
+import { describe, expect, it } from "vitest";
+import { MemoryRouter, Route, Routes } from "react-router-dom";
+import { ProtectedRoute } from "./ProtectedRoute";
+
+function renderGuarded(role: "guest" | "investor" | "admin") {
+  return render(
+    <MemoryRouter initialEntries={["/admin"]}>
+      <Routes>
+        <Route
+          path="/admin"
+          element={
+            <ProtectedRoute role={role} allow={["admin"]}>
+              <div data-testid="admin-page">Admin Page</div>
+            </ProtectedRoute>
+          }
+        />
+        <Route path="/" element={<div data-testid="home-page">Home</div>} />
+      </Routes>
+    </MemoryRouter>,
+  );
+}
+
+describe("ProtectedRoute", () => {
+  it("renders the protected content when the role is allowed", () => {
+    renderGuarded("admin");
+    expect(screen.getByTestId("admin-page")).toBeInTheDocument();
+  });
+
+  it("redirects to the default path when the role is not allowed", () => {
+    renderGuarded("investor");
+    expect(screen.queryByTestId("admin-page")).not.toBeInTheDocument();
+    expect(screen.getByTestId("home-page")).toBeInTheDocument();
+  });
+
+  it("redirects guests away from the protected route", () => {
+    renderGuarded("guest");
+    expect(screen.queryByTestId("admin-page")).not.toBeInTheDocument();
+    expect(screen.getByTestId("home-page")).toBeInTheDocument();
+  });
+
+  it("redirects to a custom path when provided", () => {
+    render(
+      <MemoryRouter initialEntries={["/admin"]}>
+        <Routes>
+          <Route
+            path="/admin"
+            element={
+              <ProtectedRoute role="guest" allow={["admin"]} redirectTo="/portfolio">
+                <div data-testid="admin-page">Admin Page</div>
+              </ProtectedRoute>
+            }
+          />
+          <Route path="/portfolio" element={<div data-testid="portfolio-page">Portfolio</div>} />
+        </Routes>
+      </MemoryRouter>,
+    );
+
+    expect(screen.getByTestId("portfolio-page")).toBeInTheDocument();
+  });
+});

frontend/src/components/ProtectedRoute.tsx

@@ -0,0 +1,32 @@
+import React from "react";
+import { Navigate, useLocation } from "react-router-dom";
+import { roleAllows, type UserRole } from "../lib/roles";
+
+interface ProtectedRouteProps {
+  role: UserRole;
+  allow: readonly UserRole[];
+  redirectTo?: string;
+  children: React.ReactNode;
+}
+
+/**
+ * Route guard that redirects away when the current role isn't in `allow`.
+ * The attempted path is passed along in location state so the redirect
+ * target can restore it later (e.g. after connecting a wallet).
+ */
+export const ProtectedRoute: React.FC<ProtectedRouteProps> = ({
+  role,
+  allow,
+  redirectTo = "/",
+  children,
+}) => {
+  const location = useLocation();
+
+  if (!roleAllows(role, allow)) {
+    return <Navigate to={redirectTo} replace state={{ from: location.pathname }} />;
+  }
+
+  return <>{children}</>;
+};
+
+export default ProtectedRoute;