Merge pull request gastownhall#21 from gastownhall/fix/profile-stamp-count-mismatch-complete

fix: distinguish GitHub assessments from Wasteland stamps on profile

Author: julianknutsen

README.md

@@ -134,7 +134,7 @@ The web UI provides:
   config, sync upstream.
 - **Profiles** — look up developer character sheets from the-pile. Search by
   handle or name, view skills, value dimensions, notable projects, and
-  reputation stamps. Navigate to `/profile` for search or
+  GitHub assessments. Navigate to `/profile` for search or
   `/profile/<handle>` for a direct lookup.
 - **Command palette** — press `Cmd+K` (or `Ctrl+K`) to navigate, create
   items, or view keyboard shortcuts.

cmd/wl/cmd_profile.go

@@ -19,7 +19,7 @@ func newProfileCmd(stdout, stderr io.Writer) *cobra.Command {
 		Long: `Look up a developer's character sheet from hop/the-pile.
 
 Shows identity, skills (languages, domains, capabilities), notable projects,
-and value dimensions assembled from boot blocks and reputation stamps.
+and value dimensions assembled from boot blocks and GitHub assessments.
 
 EXAMPLES:
   wl profile torvalds            # Show Torvalds' profile
@@ -163,8 +163,8 @@ func runProfile(_ *cobra.Command, stdout, _ io.Writer, handle string) error {
 	}
 
 	// Stats footer
-	fmt.Fprintf(stdout, "Stamps: %d  Total stars: %d  Repos: %d\n",
-		profile.StampCount, profile.TotalStars, profile.TotalRepos)
+	fmt.Fprintf(stdout, "Assessments: %d  Total stars: %d  Repos: %d\n",
+		profile.AssessmentCount, profile.TotalStars, profile.TotalRepos)
 
 	return nil
 }

internal/api/pile_handlers_test.go

@@ -101,6 +101,9 @@ func TestHandleProfile_Success(t *testing.T) {
 	if profile.Handle != "test" {
 		t.Errorf("handle = %q, want test", profile.Handle)
 	}
+	if profile.AssessmentCount != 0 {
+		t.Errorf("assessment_count = %d, want 0", profile.AssessmentCount)
+	}
 }
 
 func TestHandleProfileSearch_LimitClamped(t *testing.T) {

internal/pile/profile.go

@@ -32,8 +32,9 @@ type Profile struct {
 	Reliability float64 `json:"reliability"`
 	Creativity  float64 `json:"creativity"`
 
-	// Aggregated from stamps
-	StampCount   int          `json:"stamp_count"`
+	// Aggregated from the-pile stamps (GitHub analysis, NOT wasteland reputation)
+	AssessmentCount int `json:"assessment_count"`
+
 	Languages    []SkillEntry `json:"languages,omitempty"`
 	Domains      []SkillEntry `json:"domains,omitempty"`
 	Capabilities []SkillEntry `json:"capabilities,omitempty"`
@@ -119,7 +120,7 @@ func QueryProfile(p RowQuerier, handle string) (*Profile, error) {
 		return nil, fmt.Errorf("querying stamps: %w", err)
 	}
 
-	profile.StampCount = len(stampRows)
+	profile.AssessmentCount = len(stampRows)
 	parseStamps(stampRows, profile)
 
 	return profile, nil

internal/pile/profile_test.go

@@ -94,6 +94,41 @@ func TestQueryProfile_Success(t *testing.T) {
 	if profile.Quality < 4.5 {
 		t.Errorf("quality = %f, want >= 4.5 (0.95 * 5)", profile.Quality)
 	}
+	// Empty stamp rows → AssessmentCount should be 0
+	if profile.AssessmentCount != 0 {
+		t.Errorf("AssessmentCount = %d, want 0 (no stamp rows)", profile.AssessmentCount)
+	}
+}
+
+func TestQueryProfile_WithStamps(t *testing.T) {
+	sheetJSON, _ := json.Marshal(map[string]any{
+		"identity":         map[string]any{"display_name": "Test"},
+		"value_dimensions": map[string]any{"quality": 0.5},
+	})
+
+	q := &fakeQuerier{rows: map[string][]map[string]any{
+		"SELECT handle": {
+			{
+				"handle":     "test",
+				"source":     "github",
+				"sheet_json": string(sheetJSON),
+				"confidence": "0.8",
+				"created_at": "2024-01-01",
+			},
+		},
+		"SELECT skill_tags": {
+			{"skill_tags": `["go"]`, "valence": `{"quality":4,"reliability":3,"creativity":2}`, "confidence": "0.9", "message": "Strong Go skills"},
+			{"skill_tags": `["python"]`, "valence": `{"quality":3,"reliability":4,"creativity":3}`, "confidence": "0.8", "message": "Python experience"},
+		},
+	}}
+
+	profile, err := QueryProfile(q, "test")
+	if err != nil {
+		t.Fatalf("unexpected error: %v", err)
+	}
+	if profile.AssessmentCount != 2 {
+		t.Errorf("AssessmentCount = %d, want 2", profile.AssessmentCount)
+	}
 }
 
 func TestSearchProfiles(t *testing.T) {

web/src/api/types.ts

@@ -243,7 +243,7 @@ export interface ProfileResponse {
   quality: number;
   reliability: number;
   creativity: number;
-  stamp_count: number;
+  assessment_count: number;
   languages?: ProfileSkillEntry[];
   domains?: ProfileSkillEntry[];
   capabilities?: ProfileSkillEntry[];

web/src/components/ProfileView.module.css

@@ -73,6 +73,20 @@
   background-color: var(--green);
 }
 
+.assessmentBadge {
+  display: inline-block;
+  padding: 2px 8px;
+  border-radius: 4px;
+  font-size: 0.75rem;
+  font-weight: 600;
+  text-transform: uppercase;
+  letter-spacing: 0.03em;
+  color: var(--fg);
+  background-color: var(--surface);
+  border: 1px solid var(--border);
+  cursor: help;
+}
+
 .unverifiedNote {
   font-size: 0.75rem;
   color: var(--dim);

web/src/components/ProfileView.tsx

@@ -64,12 +64,15 @@ export function ProfileView() {
           <span className={styles.confidence} title="How confident the system is in this profile data">
             {(data.confidence * 100).toFixed(0)}% confidence
           </span>
-          {data.stamp_count > 0 && (
-            <span className={styles.verifiedBadge}>
-              {data.stamp_count} {data.stamp_count === 1 ? "stamp" : "stamps"} earned
+          {data.assessment_count > 0 && (
+            <span
+              className={styles.assessmentBadge}
+              title="Skill assessments from GitHub profile analysis — not Wasteland reputation stamps"
+            >
+              {data.assessment_count} {data.assessment_count === 1 ? "assessment" : "assessments"}
             </span>
           )}
-          {data.stamp_count === 0 && <span className={styles.unverifiedNote}>No Wasteland stamps yet</span>}
+          {data.assessment_count === 0 && <span className={styles.unverifiedNote}>No assessments yet</span>}
         </div>
       </div>