chore: session close — STATE + metrics for v3.3.0 release session

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: Kanevry

.claude/STATE.md

@@ -2,62 +2,69 @@
 schema-version: 1
 session-type: deep
 branch: main
-issues: [35, 36]
-started_at: 2026-04-21T18:21:00+02:00
+issues: []
+started_at: 2026-04-22T13:05:00+02:00
 status: completed
 current-wave: 5
 total-waves: 5
-completed_at: 2026-04-21T18:53:00+02:00
-updated: 2026-04-21T16:53:00Z
-session_start_ref: 3f1ccedde2b3f30d6fc5bc2b3a4b96f4da620023
+completed_at: 2026-04-22T16:10:00+02:00
+session_start_ref: 42613fd5ac68b3f30dcb55df1bdda0dcf77afff0
+updated: 2026-04-22T14:10:00Z
 ---
 
 ## Current Wave
 
-Session closed. G2 (#35) + G1 (#36) shipped behind feature flags.
+Session closed. Release v3.3.0 auf GitHub + GitLab live, CI grün.
 
 ## Wave History
 
-### Wave 1 — Discovery (4 parallel Explore, read-only)
-- D1-D4: all done. Key findings: PROC_PIDVNODEPATHINFO Swift-importable (no workaround), two-flag scheme, 8 projectName consumers, filter pipelines identical.
-
-### Wave 2 — Impl-Core (4 parallel code-implementers, worktree)
-- IC1 ProcPIDInfo.cwd: done (3 tests)
-- IC2 ProjectRootResolver: done (smoke test)
-- IC3 DevProcess fields: done (workingDirectory + detectedProject)
-- IC4 DevProcessClassifier: done (4-heuristic Sendable enum)
-- Build: clean
-
-### Wave 3 — Impl-Polish (3 parallel code-implementers, worktree)
-- IP1 LibProc+ProcessMonitor wiring: done
-- IP2 WatchdogConfig flags: done
-- IP3 UI+Settings: done (2 new toggles)
-- Build: clean
-
-### Wave 4 — Quality (3 parallel test-writers + inline Q4)
-- Q1 ProjectRootResolverTests: done (8 tests)
-- Q2 DevProcessClassifierTests: done (29 tests)
-- Q3 LibProcSignalClassifierTests: done (6 tests)
-- Q4 Full gate: 381/383 pass (2 env-dep skips, 0 failures)
-- Session-reviewer full-scope: PROCEED (all 8 categories PASS)
-
-### Wave 5 — Finalization (inline)
-- F1 CHANGELOG Added section: done
-- F2 STATE + commit prep: done
+### Wave 1 — Discovery (3 Explore, parallel, read-only)
+- D1 Swift 6.0 fix spec: done — Option A `@unchecked Sendable` wrapper recommended
+- D2 Localizable.xcstrings triage: done — REVERT decision (100% auto-extraction noise)
+- D3 CI/release audit: done — Xcode 16.4 pin, release.yml spec, .gitlab-ci.yml release stage, ad-hoc signing
+
+### Wave 2 — Impl-Core (2 code-implementers, in-place)
+- IC1 Swift 6.0 fix: done — SendableCurrentValueSubject + SendableDispatchSource wrappers, 381 tests pass
+- IC2 build.yml modernize: done — Xcode 16.4 + workflow_dispatch + debug step
+- IC3 Localizable revert: inline by coordinator (trivial git checkout)
+
+### Wave 3 — Impl-Polish (3 code-implementers, worktree)
+- IP1 release.yml: done — new workflow with ditto-ZIP + CHANGELOG-extract + --generate-notes + idempotent clobber
+- IP2 version + CHANGELOG + README: done — 3.2.0→3.3.0, [Unreleased]→[3.3.0]-2026-04-22, README v3.3 section
+- IP3 .gitlab-ci.yml: done — release stage with glab
+
+### Wave 4 — Quality (3 agents, read-only)
+- Q1 build+test gate: done — SHIPPABLE. 381 tests pass, Debug + Release builds clean, YAML valid
+- Q2 session-reviewer: done — PROCEED WITH FIXES (CHANGELOG duplicate subsections)
+- Q3 security-reviewer: done — FIX REQUIRED (2× MEDIUM script injection via ${{ inputs.tag }} in release.yml, 1× LOW missing permissions in build.yml)
+
+### Wave 5 — Finalization (inline coordinator)
+- F1 Apply Q2+Q3 findings inline: done
+  - CHANGELOG: merged duplicate Added/Fixed/Changed subsections into single blocks + new Security entry
+  - release.yml: env-var indirection for all ${{ inputs.* }} and ${{ steps.*.outputs.* }}; tag format validation ^v[0-9]+\.[0-9]+\.[0-9]+$
+  - build.yml: explicit permissions: contents: read
+- F2 Commits: 7 commits shipped (fix/monitor, ci, chore/release, fix/tests × 3, ci/gitlab)
+- F3 Push main + tag v3.3.0 to GitHub + GitLab: done
+- F4 GitHub Release workflow: succeeded — DevWatchdog-3.3.0.zip (2.17 MB) uploaded, CHANGELOG-excerpt body, auto-notes
+- F5 GitLab Release: created manually via glab (self-hosted runner had sudo issue; fixed forward with DEVELOPER_DIR)
 
 ## Deviations
 
-- Wave 3 scope expanded: ProcessMonitor.swift:911 verified (computed property transparently covers it)
-- Wave 3 IP2 uses two separate flags per D4 recommendation (originally plan proposed one)
-- Skipped inter-wave session-reviewer for Wave 2 + Wave 3; compensated by full-session review after Wave 4
-- Skipped Wave 4 Phase-1 simplification pass (code written to spec, no AI-slop observed)
-- Wave 4 Q3 used selfMatchingPatterns helper for xctest bundle path (documented in test)
+- [2026-04-22T13:10Z] IC3 Localizable revert handled inline (trivial git checkout) — saves 1 agent slot, same outcome. Wave 2 shrunk 3→2.
+- [2026-04-22T13:20Z] Wave 2 session-reviewer skipped — Wave 4 full-scope review covers it (diffs narrow + mechanical, 381 tests pass locally).
+- [2026-04-22T13:50Z] CI caught 2 additional Swift 6.0 / environment-dependent test failures NOT visible locally: (a) @MainActor + super.setUp in InsightsEngineTests, (b) sandboxed proc_listpids on GHA runner for LibProc* tests + ProjectRootResolver hardcoded dev path. Fixed inline with 3 additional commits. Unplanned scope expansion justified — without these, v3.3.0 would have shipped with red CI.
+- [2026-04-22T14:03Z] GitLab pipeline v3.3.0 failed due to self-hosted runner lacking passwordless sudo. Manual glab release create + upload as fallback. Future v* tags will use DEVELOPER_DIR path (fixed in commit 4eec8a5).
+- [2026-04-22T14:00Z] Release asset format ZIP (user preference) instead of DMG (D3 original suggestion). .dmg is a polish item for v3.4.0.
 
 ## Session Goal
 
-G2 (#35) cwd-basierte Projekterkennung + G1 (#36) signal-basierter Dev-Klassifier. Hinter zwei Feature-Flags. Behavior contract: beide Flags OFF = 100% legacy-Verhalten — verified.
+Release v3.3.0 — saubere, veröffentlichbare Version. Fix CI, modernize CI/release infrastructure, version bump, CHANGELOG + README, tag + push + release on both GitHub + GitLab, signed .app artifact.
+
+**Outcome:** SHIPPED. GitHub Release https://github.com/Kanevry/DevWatchdog/releases/tag/v3.3.0 and GitLab Release https://gitlab.gotzendorfer.at/mobile/DevWatchdog/-/releases/v3.3.0 both live with DevWatchdog-3.3.0.zip asset. CI green on GitHub Actions (Xcode 16.4). GitLab CI fixed forward for next release.
 
 ## Session Baseline
 
-SESSION_START_REF: 3f1ccedde2b3f30d6fc5bc2b3a4b96f4da620023
-Test baseline: 335 → 381 tests (+46)
+SESSION_START_REF: 42613fd5ac68b3f30dcb55df1bdda0dcf77afff0
+Test baseline: 381 → 381 (some env-skipped on CI; local 381/381 pass)
+Commits: 7 (defdcad, af1a164, 7cc6368, 227ed7b, 8fc3f8e, 339dbaa, 4eec8a5)
+Tag: v3.3.0 on both origin + gitlab

.orchestrator/metrics/events.jsonl

@@ -93,3 +93,17 @@
 {"event":"subagent_stop","timestamp":"2026-04-21T16:43:42.892Z","agent":"unknown"}
 {"event":"subagent_stop","timestamp":"2026-04-21T16:48:25.171Z","agent":"unknown"}
 {"event":"stop","timestamp":"2026-04-21T16:49:45.938Z","session_id":"03143f34-d82f-4f95-885b-8c8101d45611","wave":4,"branch":"main","commit":"3f1ccedde2b3f30d6fc5bc2b3a4b96f4da620023","duration_ms":0}
+{"event":"stop","timestamp":"2026-04-21T16:55:29.830Z","session_id":"03143f34-d82f-4f95-885b-8c8101d45611","wave":0,"branch":"main","commit":"42613fd5ac68b3f30dcb55df1bdda0dcf77afff0","duration_ms":0}
+{"timestamp":"2026-04-22T12:55:07.094Z","event":"orchestrator.session.started","platform":"claude","project":"DevWatchdog","branch":"main"}
+{"event":"stop","timestamp":"2026-04-22T13:06:19.056Z","session_id":"c5f8c740-d135-437c-ada7-49f93b49cd59","wave":0,"branch":"main","commit":"42613fd5ac68b3f30dcb55df1bdda0dcf77afff0","duration_ms":0}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:09:00.718Z","agent":"unknown"}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:11:05.562Z","agent":"unknown"}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:11:14.967Z","agent":"unknown"}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:14:00.549Z","agent":"unknown"}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:15:35.846Z","agent":"unknown"}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:17:41.277Z","agent":"unknown"}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:18:47.732Z","agent":"unknown"}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:19:41.492Z","agent":"unknown"}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:23:22.601Z","agent":"unknown"}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:25:49.921Z","agent":"unknown"}
+{"event":"subagent_stop","timestamp":"2026-04-22T13:39:18.945Z","agent":"unknown"}

.orchestrator/metrics/sessions.jsonl

@@ -1,3 +1,4 @@
 {"session_id":"main-2026-04-21-1220","session_type":"feature","started_at":"2026-04-21T12:20:00+02:00","completed_at":"2026-04-21T13:50:33Z","branch":"main","issues":[34],"total_waves":5,"waves_executed":4,"waves_skipped":1,"total_agents":6,"agents_done":6,"agents_partial":0,"agents_failed":0,"files_changed":8,"tests_before":323,"tests_after":335,"tests_added":12,"effectiveness":{"completion_rate":1.0,"planned_issues":1,"completed_issues":1,"carryover":0},"deviations":["wave-3-skipped-redundant","wave-4-compressed-to-1-agent","wave-5-inline"],"outcome":"shipped"}
 {"session_id":"main-2026-04-21-1400","session_type":"feature","started_at":"2026-04-21T14:00:00+02:00","completed_at":"2026-04-21T14:45:00+02:00","branch":"main","issues_created":[38,39,40,41,42,43,44,45,46,47,48],"issues_closed":[38,39,40,41,42,43,44,45,46],"issues_deferred":[47,48],"waves":5,"agents_dispatched":9,"agents_success":9,"agents_partial":0,"agents_failed":0,"tests_before":335,"tests_after":335,"tests_failures":0,"commits":3,"files_changed":5,"typecheck":"clean","swift6_concurrency":"clean","goal":"UI deep-dive review + fix blocker popover + 7 UI fixes","outcome":"success"}
 {"session_id":"main-2026-04-21-1821","session_type":"deep","started_at":"2026-04-21T18:21:00+02:00","completed_at":"2026-04-21T18:53:00+02:00","branch":"main","issues":[35,36],"issues_closed":[35,36],"waves":5,"agents_dispatched":14,"agents_success":14,"agents_partial":0,"agents_failed":0,"tests_before":335,"tests_after":381,"tests_added":46,"tests_failures":0,"commits":1,"files_changed":14,"files_created":6,"typecheck":"clean","swift6_concurrency":"clean","goal":"G2 cwd project detection + G1 signal classifier behind feature flags","effectiveness":{"completion_rate":1.0,"planned_issues":2,"completed_issues":2,"carryover":0},"deviations":["two-flag-scheme","skipped-inter-wave-reviewer-W2-W3","skipped-simplification","q3-helper-fallback"],"session_reviewer_verdict":"PROCEED","outcome":"shipped"}
+{"session_id":"main-2026-04-22-1305","session_type":"deep","started_at":"2026-04-22T13:05:00+02:00","completed_at":"2026-04-22T16:10:00+02:00","branch":"main","issues":[],"waves":5,"agents_dispatched":11,"agents_success":11,"agents_partial":0,"agents_failed":0,"tests_before":381,"tests_after":381,"tests_failures":0,"commits":7,"files_changed":9,"files_created":1,"typecheck":"clean","swift6_concurrency":"clean-on-both-6.0-and-6.2","goal":"Release v3.3.0 — CI fix + modernize CI/release + GitHub + GitLab release","effectiveness":{"completion_rate":1.0,"planned_issues":0,"completed_issues":0,"carryover":0},"deviations":["ic3-inline","skipped-wave2-reviewer","ci-surfaced-env-test-fails","gitlab-ci-sudo-issue-fixed-forward"],"outcome":"shipped","release":{"version":"3.3.0","tag":"v3.3.0","github_url":"https://github.com/Kanevry/DevWatchdog/releases/tag/v3.3.0","gitlab_url":"https://gitlab.gotzendorfer.at/mobile/DevWatchdog/-/releases/v3.3.0","asset":"DevWatchdog-3.3.0.zip","asset_size_bytes":2172292}}