added check for partial sync

Author: joevanwanzeeleKF

docsource/configuration.md

@@ -17,7 +17,7 @@ In order to enroll certificates the Keyfactor Command server must trust the CA c
 
 ## CA Connection
 
-The certificate used by the gateway for authenticating into the Nexus Certificate Manager will need to be copied to a location on the Gateway Host that is accessble by the gateway service.  The Certificate Path 
+The certificate used by the gateway for authenticating into the Nexus Certificate Manager will need to be copied to a location on the Gateway Host that is accessible by the gateway service.  The Certificate Path 
 
 ## Certificate Template Creation Step
 

nexus-certificate-manager-caplugin/NexusCertManagerCAPlugin.cs

@@ -240,7 +240,7 @@ public async Task<int> Revoke(string caRequestID, string hexSerialNumber, uint r
         }
 
         /// <summary>
-        /// Synchronize gets the list of certs from the CA and updates the status of each known cert to the latest; and adds missing cert info to the database        /// 
+        /// Synchronize gets the list of certs from the CA and updates the status of each known cert to the latest, and adds missing cert info to the database.
         /// </summary>
         /// <param name="blockingBuffer">the database reader, passed by framework</param>
         /// <param name="lastSync">the time of last sync</param>
@@ -254,7 +254,7 @@ public async Task Synchronize(BlockingCollection<AnyCAPluginCertificate> blockin
 
             try
             {
-                // retreive the list of certs from Nexus CM
+                // retrieve the list of certs from Nexus CM
                 _logger.LogTrace("attempting to retrieve the list of cert names from Nexus CM");
                 var certList = await _client.GetCertificateList(null, cancelToken);
                 _logger.LogTrace($"successfully returned {certList.SearchHits} results.");
@@ -361,7 +361,7 @@ public async Task ValidateCAConnectionInfo(Dictionary<string, object> connection
                 try
                 {
                     // see if we can open the file for reading..
-                    using (var fs = new FileStream((string)connectionInfo[Constants.AUTHCERTPATH], FileMode.Open, FileAccess.Read))
+                    using (var _ = new FileStream((string)connectionInfo[Constants.AUTHCERTPATH], FileMode.Open, FileAccess.Read))
                     {
                         // if we get this far, we can
                         _logger.LogTrace($"successfully read the file at path {connectionInfo[Constants.AUTHCERTPATH]}");

nexus-certificate-manager-caplugin/NexusCertManagerClient.cs

@@ -22,7 +22,7 @@ namespace Keyfactor.Extensions.CAPlugin.NexusCertManager
 
     public class NexusCertManagerClient
     {
-        ILogger _logger;
+        private readonly ILogger _logger;
         private RestClient _restClient;
         private string _host;
         private string _authCertPath;
@@ -73,7 +73,7 @@ public NexusCertManagerClient(string hostAndPort, string authCertPath, string au
             {
                 _logger.LogTrace("getting first available proc name for pkcs10 to submit with request..");
                 var procs = await GetProceduresByMediaType(Constants.MEDIATYPE_PKCS10);
-                procname = procs?.First();
+                procname = procs?.FirstOrDefault();
                 if (!string.IsNullOrEmpty(procname))
                 {
                     req.AddParameter("procname", procname);
@@ -91,7 +91,7 @@ public NexusCertManagerClient(string hostAndPort, string authCertPath, string au
                 var response = await _restClient.ExecuteAsync(req, ct);
                 _logger.LogTrace($"response status code: {response.StatusCode}");
                 _logger.LogTrace($"response content: {response.Content}");
-                _logger.LogTrace($"recieved a response, parsing the result");
+                _logger.LogTrace($"received a response, parsing the result");
                 var result = RestSharpResponseHandler.HandleCertificateBinaryResponse(response);
                 return result;
             }

nexus-certificate-manager-caplugin/models/Helpers.cs

@@ -61,7 +61,7 @@ public static int GetStatusCodeFromNexusCADescription(string status)
                 case "revoked":
                     return (int)EndEntityStatus.REVOKED;
                 default:
-                    return (int)EndEntityStatus.NEW; // set the status to "NEW" for any unknown description; to be evaluated as neededs
+                    return (int)EndEntityStatus.NEW; // set the status to "NEW" for any unknown description; to be evaluated as needed
             }
         }