Skip to content

Commit 9e69335

Browse files
committed
[WB-2340-no-raw-button] Exempt no-raw-button in tests
1 parent e0023c6 commit 9e69335

31 files changed

Lines changed: 199 additions & 295 deletions

File tree

.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ module.exports = {
5454
"no-undef": "off",
5555
"import/no-deprecated": "off",
5656
"@typescript-eslint/no-require-imports": "off",
57+
"@khanacademy/wonder-blocks/no-raw-button": "off",
5758
},
5859
},
5960
{

packages/wonder-blocks-card/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
"@phosphor-icons/core": "catalog:"
3535
},
3636
"devDependencies": {
37-
"@khanacademy/wb-dev-build-settings": "workspace:*",
38-
"@khanacademy/wonder-blocks-button": "workspace:*"
37+
"@khanacademy/wb-dev-build-settings": "workspace:*"
3938
}
4039
}

packages/wonder-blocks-card/src/__tests__/components/card.test.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as React from "react";
22
import {render, screen} from "@testing-library/react";
33
import {userEvent} from "@testing-library/user-event";
44

5-
import Button from "@khanacademy/wonder-blocks-button";
65
import Card from "../../components/card";
76

87
describe("Card", () => {
@@ -266,7 +265,7 @@ describe("Card", () => {
266265
<Card inert testId="card">
267266
<h2>Heading</h2>
268267
<p>Description</p>
269-
<Button>Button</Button>
268+
<button>Button</button>
270269
</Card>,
271270
);
272271

packages/wonder-blocks-clickable/src/components/__tests__/clickable-behavior.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable @khanacademy/wonder-blocks/no-raw-button */
21
// Raw <button> elements here are minimal test fixtures — using WB Button in
32
// unit tests would add unnecessary component coupling and the tests assert
43
// behavior, not design system compliance.

packages/wonder-blocks-clickable/src/components/__tests__/clickable.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable @khanacademy/wonder-blocks/no-raw-button */
21
// Raw <button> elements here are minimal test fixtures — using WB Button in
32
// unit tests would add unnecessary component coupling and the tests assert
43
// behavior, not design system compliance.

packages/wonder-blocks-core/src/util/__tests__/focus.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable @khanacademy/wonder-blocks/no-raw-button */
21
// Raw <button> elements here are minimal test fixtures — using WB Button in
32
// unit tests would add unnecessary component coupling and the tests assert
43
// behavior, not design system compliance.

packages/wonder-blocks-date-picker/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
"temporal-polyfill": "catalog:"
5151
},
5252
"devDependencies": {
53-
"@khanacademy/wonder-blocks-button": "workspace:*",
5453
"@khanacademy/wb-dev-build-settings": "workspace:*"
5554
}
5655
}

packages/wonder-blocks-date-picker/src/components/__tests__/date-picker-input.test.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import {describe, it} from "@jest/globals";
33
import {render, screen} from "@testing-library/react";
44
import userEvent from "@testing-library/user-event";
55
import {Temporal} from "temporal-polyfill";
6-
import Button from "@khanacademy/wonder-blocks-button";
76
import {TemporalLocaleUtils} from "@khanacademy/wonder-blocks-date-picker";
87
import DatePickerInput from "../date-picker-input";
98

@@ -437,15 +436,15 @@ describe("DatePickerInput", () => {
437436
const onChangeSpy = jest.fn();
438437
render(
439438
<>
440-
<Button>Before</Button>
439+
<button>Before</button>
441440
<DatePickerInput
442441
dateFormat="M/D/YYYY"
443442
value="1/1/2026"
444443
parseDate={TemporalLocaleUtils.parseDateToJsDate}
445444
onChange={onChangeSpy}
446445
testId="date-picker-input"
447446
/>
448-
<Button>After</Button>
447+
<button>After</button>
449448
</>,
450449
);
451450

packages/wonder-blocks-date-picker/src/components/__tests__/date-picker.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ describe("DatePicker", () => {
328328
minDate={minDate}
329329
maxDate={maxDate}
330330
/>
331-
<Button>Other element</Button>
331+
<button>Other element</button>
332332
</>,
333333
);
334334
await userEvent.tab();
@@ -354,7 +354,7 @@ describe("DatePicker", () => {
354354
updateDate={jest.fn()}
355355
dateFormat="MMMM D, YYYY"
356356
/>
357-
<Button>Other element</Button>
357+
<button>Other element</button>
358358
</>,
359359
);
360360

@@ -396,7 +396,7 @@ describe("DatePicker", () => {
396396
minDate={minDate}
397397
resetInvalidValueOnBlur={false}
398398
/>
399-
<Button>Other element</Button>
399+
<button>Other element</button>
400400
</>,
401401
);
402402
// Act
@@ -443,7 +443,7 @@ describe("DatePicker", () => {
443443
minDate={minDate}
444444
resetInvalidValueOnBlur={false}
445445
/>
446-
<Button>Other element</Button>
446+
<button>Other element</button>
447447
</>,
448448
);
449449
// Act

packages/wonder-blocks-date-picker/src/components/__tests__/focus-manager.test.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable @khanacademy/wonder-blocks/no-raw-button */
21
// Allowing raw button in inernal utility testing
32
import * as React from "react";
43
import {describe, it} from "@jest/globals";

0 commit comments

Comments
 (0)