Refactor tags, actionbars, auras, chat, unitframes

Multiple small refactors and fixes across the UI:

- Libraries/cargBags: fix tagDisplay logic (handle BAG_UPDATE_DELAYED), correct bag/bank/account free slot calculations, improve currency tag to accept either watched index or currencyID, consolidate currency list build, and replace atlas coins with formatted colored money strings.
- ActionBars: ensure AutoCastOverlay and lossOfControlCooldown are sized/anchored, expose UpdateCastVFX to adjust VFX masks when button size/font changes, set cooldown text font and wire up spell cast animation textures.
- Auras: tidy header/mover calls, comment out unused GetSpellStat, tweak timer/cooldown font and settings, minor formatting/whitespace cleanups.
- Chat: use K.LibEasyMenu create call, compact tooltip line creation, preserve whisper reply behavior and flash/tab logic on received whispers.
- Load_Modules.xml: disable oUF_DebuffHighlight script include.
- Tooltip: show full unit name including server for caster in tooltip.
- UnitFrames: remove a debug print and comment out DebuffHighlight creation for several unit templates (party, party pet, raid, simple party, focus, pet, player, target) to avoid creating overlay textures by default.

Overall these changes improve robustness, visual consistency, and formatting while removing noisy debug and unused highlight layers.

Author: Kkthnx

KkthnxUI/Libraries/cargBags/mixins-add/plugins/tagDisplay.lua

@@ -44,7 +44,8 @@ local cargBags = ns.cargBags
 
 local GetContainerNumFreeSlots = C_Container.GetContainerNumFreeSlots
 
-local tagPool, tagEvents, object = {}, {}
+local tagPool, tagEvents = {}, {}
+local object
 local function tagger(tag, ...)
 	return object.tags[tag] and object.tags[tag](object, ...) or ""
 end
@@ -87,6 +88,7 @@ cargBags:RegisterPlugin("TagDisplay", function(self, tagString, parent)
 	setTagString(plugin, tagString)
 
 	self.implementation:RegisterEvent("BAG_UPDATE", plugin, updater)
+	self.implementation:RegisterEvent("BAG_UPDATE_DELAYED", plugin, updater)
 	return plugin
 end)
 
@@ -100,17 +102,17 @@ end
 -- Tags
 local function GetNumFreeSlots(name)
 	if name == "Bag" then
-		local totalFree, freeSlots, bagFamily = 0
+		local totalFree = 0
 		for i = 0, 4 do -- reagent bank excluded
-			freeSlots, bagFamily = GetContainerNumFreeSlots(i)
+			local freeSlots, bagFamily = GetContainerNumFreeSlots(i)
 			if bagFamily == 0 then
 				totalFree = totalFree + freeSlots
 			end
 		end
 		return totalFree
 	elseif name == "Bank" then
-		local numFreeSlots = 0
-		for bagID = 6, 11 do
+		local numFreeSlots = GetContainerNumFreeSlots(-1)
+		for bagID = 6, 12 do
 			numFreeSlots = numFreeSlots + GetContainerNumFreeSlots(bagID)
 		end
 		return numFreeSlots
@@ -120,7 +122,7 @@ local function GetNumFreeSlots(name)
 		return GetContainerNumFreeSlots(5)
 	elseif name == "Account" then
 		local numFreeSlots = 0
-		for bagID = 12, 16 do
+		for bagID = 13, 17 do
 			numFreeSlots = numFreeSlots + GetContainerNumFreeSlots(bagID)
 		end
 		return numFreeSlots
@@ -142,74 +144,77 @@ tagPool["item"] = function(self, item)
 	end
 end
 
-tagPool["currency"] = function(self, id)
-	local currencyInfo = C_CurrencyInfo.GetBackpackCurrencyInfo(id)
-	if currencyInfo then
-		return currencyInfo.quantity .. createIcon(currencyInfo.iconFileID, self.iconValues)
+tagPool["currency"] = function(self, indexOrCurrencyID)
+	-- Support either an index (as used by GetNumWatchedTokens) or a direct currencyID
+	local info
+	if type(indexOrCurrencyID) == "number" then
+		-- First, try backpack watched token by index
+		if indexOrCurrencyID <= (GetNumWatchedTokens() or 0) then
+			info = C_CurrencyInfo.GetBackpackCurrencyInfo(indexOrCurrencyID)
+		end
+		-- If not found, treat the number as a currencyID
+		if not info then
+			info = C_CurrencyInfo.GetCurrencyInfo(indexOrCurrencyID)
+		end
+	end
+	if not info then
+		return
+	end
+	local name, count, icon = info.name, info.quantity or info.quantityEarnedThisWeek or 0, info.iconFileID
+	if name and count then
+		local iconTexture = "|T" .. icon .. ":13:15:0:0:50:50:4:46:4:46|t "
+		return (iconTexture .. BreakUpLargeNumbers(count))
 	end
 end
 tagEvents["currency"] = { "CURRENCY_DISPLAY_UPDATE" }
 
 tagPool["currencies"] = function(self)
-	local str
-	for i = 1, GetNumWatchedTokens() do
+	local out
+	local watched = GetNumWatchedTokens() or 0
+	for i = 1, watched do
 		local curr = self.tags["currency"](self, i)
 		if curr then
-			str = (str and str .. " " or "") .. curr
+			out = out and (out .. " " .. curr) or curr
 		end
 	end
-	return str
+	return out
 end
 tagEvents["currencies"] = tagEvents["currency"]
 
-local atlasCache = {}
-local function createAtlasCoin(coin)
-	local str = atlasCache[coin]
-	if not str then
-		local info = C_Texture.GetAtlasInfo("coin-" .. coin)
-		local K = _G.KkthnxUI and _G.KkthnxUI[1] or nil
-		if info then
-			str = K and K.GetTextureStrByAtlas and K.GetTextureStrByAtlas(info, 16, 16)
-			atlasCache[coin] = str
-		end
-	end
-	return str
-end
-
 tagPool["money"] = function()
-	local money = GetMoney() or 0
-	local str = ""
-	local gold, silver, copper = floor(money / 1e4), floor(money / 100) % 100, money % 100
+	local coppername = "|cffeda55fc|r"
+	local goldname = "|cffffd700g|r"
+	local silvername = "|cffc7c7cfs|r"
+
+	local amount = GetMoney() or 0
+	local value = abs(amount)
+	local gold = floor(value / 10000)
+	local silver = floor(mod(value / 100, 100))
+	local copper = floor(mod(value, 100))
 
 	if gold > 0 then
-		str = str .. BreakUpLargeNumbers(gold) .. createAtlasCoin("gold") .. " "
-	end
-	if silver > 0 then
-		str = str .. silver .. createAtlasCoin("silver") .. " "
+		return format("%s%s %02d%s %02d%s", BreakUpLargeNumbers(gold), goldname, silver, silvername, copper, coppername)
+	elseif silver > 0 then
+		return format("%d%s %02d%s", silver, silvername, copper, coppername)
+	else
+		return format("%d%s", copper, coppername)
 	end
-	if copper > 0 then
-		str = str .. copper .. createAtlasCoin("copper") .. " "
-	end
-
-	return str
 end
 tagEvents["money"] = { "PLAYER_MONEY" }
 
 tagPool["accountmoney"] = function()
 	local money = C_Bank.FetchDepositedMoney(Enum.BankType.Account) or 0
-	local str = ""
+	local coppername = "|cffeda55fc|r"
+	local goldname = "|cffffd700g|r"
+	local silvername = "|cffc7c7cfs|r"
 	local gold, silver, copper = floor(money / 1e4), floor(money / 100) % 100, money % 100
 
 	if gold > 0 then
-		str = str .. BreakUpLargeNumbers(gold) .. createAtlasCoin("gold") .. " "
-	end
-	if silver > 0 then
-		str = str .. silver .. createAtlasCoin("silver") .. " "
-	end
-	if copper >= 0 then
-		str = str .. copper .. createAtlasCoin("copper") .. " "
+		return format("%s%s %02d%s %02d%s", BreakUpLargeNumbers(gold), goldname, silver, silvername, copper, coppername)
+	elseif silver > 0 then
+		return format("%d%s %02d%s", silver, silvername, copper, coppername)
+	else
+		return format("%d%s", copper, coppername)
 	end
-
-	return str
 end
 tagEvents["accountmoney"] = { "PLAYER_MONEY", "ACCOUNT_MONEY" }

KkthnxUI/Modules/ActionBars/ButtonStyle.lua

@@ -143,6 +143,7 @@ function Module:StyleActionButton(button)
 	local iconMask = button.IconMask
 	local petShine = _G[buttonName .. "Shine"]
 	local autoCastable = button.AutoCastable
+	local autoCastOverlay = button.AutoCastOverlay
 
 	-- NOTE: Hide original Blizzard textures to prevent visual overlaps.
 	if normal then
@@ -188,6 +189,10 @@ function Module:StyleActionButton(button)
 		autoCastable:SetAllPoints()
 	end
 
+	if autoCastOverlay then
+		autoCastOverlay:SetAllPoints()
+	end
+
 	-- REASON: Setup custom icon and background border.
 	if icon then
 		icon:SetAllPoints()
@@ -206,6 +211,12 @@ function Module:StyleActionButton(button)
 	if cooldown then
 		cooldown:SetPoint("TOPLEFT", button, "TOPLEFT", 1, -1)
 		cooldown:SetPoint("BOTTOMRIGHT", button, "BOTTOMRIGHT", -1, 1)
+
+		local region = cooldown:GetRegions()
+		if region and region:IsObjectType("FontString") then
+			region:SetFontObject(Game16FontOutline)
+			button.cooldownText = region
+		end
 	end
 
 	-- NOTE: Apply custom textures for interaction states (Pushed, Checked, Highlight).
@@ -242,6 +253,18 @@ function Module:StyleActionButton(button)
 		hooksecurefunc(hotkey, "SetText", Module.UpdateHotKey)
 	end
 
+	-- Cast VFX
+	local spellCastAnim = button.SpellCastAnimFrame
+	local spellCastFill = spellCastAnim and spellCastAnim.Fill
+	if spellCastFill then
+		spellCastFill.InnerGlowTexture:SetAllPoints(icon)
+		spellCastFill.InnerGlowTexture:SetTexCoord(K.TexCoords[1], K.TexCoords[2], K.TexCoords[3], K.TexCoords[4])
+	end
+
+	if button.lossOfControlCooldown then
+		button.lossOfControlCooldown:SetAllPoints()
+	end
+
 	button.__styled = true
 end
 

KkthnxUI/Modules/ActionBars/Elements/Bars.lua

@@ -53,12 +53,37 @@ function Module:UpdateAllSize()
 	Module:UpdateVehicleButton()
 end
 
+function Module:UpdateCastVFX(button)
+	local buttonWidth, buttonHeight = button:GetSize()
+	local maskWidth, maskHeight = buttonWidth * 1.5, buttonHeight * 1.5
+
+	local spellCastAnim = button.SpellCastAnimFrame
+	if spellCastAnim then
+		local endBurst = spellCastAnim.EndBurst
+		if endBurst then
+			endBurst.EndMask:SetSize(maskWidth, maskHeight)
+		end
+
+		local spellCastFill = spellCastAnim.Fill
+		if spellCastFill then
+			spellCastFill.FillMask:SetSize(maskWidth, maskHeight)
+		end
+	end
+	local interruptDisplay = button.InterruptDisplay
+	local interruptHighlight = interruptDisplay and interruptDisplay.Highlight
+	if interruptHighlight then
+		interruptHighlight.Mask:SetSize(maskWidth, maskHeight)
+	end
+end
+
 -- NOTE: Standardizes font settings across all button text elements.
 function Module:UpdateFontSize(button, fontSize)
 	-- Directly apply the path, new size, and style variables
 	button.Name:SetFont(K.UIFontOutlinePath, fontSize, K.UIFontOutlineStyle)
 	button.Count:SetFont(K.UIFontOutlinePath, fontSize, K.UIFontOutlineStyle)
 	button.HotKey:SetFont(K.UIFontOutlinePath, fontSize, K.UIFontOutlineStyle)
+
+	Module:UpdateCastVFX(button)
 end
 
 -- REASON: Recalculates button positions and frame bounds based on rows and columns.
@@ -222,8 +247,7 @@ end
 
 -- NOTE: Defines the state-switching logic for the main bar (Bar 1) to handle
 -- vehicles, stances, and overriding bars.
-local fullPage =
-	"[bar:6]6;[bar:5]5;[bar:4]4;[bar:3]3;[bar:2]2;[possessbar]16;[overridebar]18;[shapeshift]17;[vehicleui]16;[bonusbar:5]11;[bonusbar:4]10;[bonusbar:3]9;[bonusbar:2]8;[bonusbar:1]7;1"
+local fullPage = "[bar:6]6;[bar:5]5;[bar:4]4;[bar:3]3;[bar:2]2;[possessbar]16;[overridebar]18;[shapeshift]17;[vehicleui]16;[bonusbar:5]11;[bonusbar:4]10;[bonusbar:3]9;[bonusbar:2]8;[bonusbar:1]7;1"
 
 function Module:UpdateBarVisibility()
 	for i = 1, 8 do
@@ -366,8 +390,7 @@ function Module:CreateBars()
 		end
 
 		-- REASON: Bars 2-8 are hidden during special bar states (Vehicles, Override) to avoid clutter.
-		frame.visibility = index == 1 and "[petbattle] hide; show"
-			or "[petbattle][overridebar][vehicleui][possessbar,@vehicle,exists][shapeshift] hide; show"
+		frame.visibility = index == 1 and "[petbattle] hide; show" or "[petbattle][overridebar][vehicleui][possessbar,@vehicle,exists][shapeshift] hide; show"
 
 		frame:SetAttribute(
 			"_onstate-page",

KkthnxUI/Modules/Auras/Core.lua

@@ -110,18 +110,12 @@ function Module:BuildBuffFrame()
 
 	-- REASON: Initialize movers for custom positioning.
 	Module.BuffFrame = Module:CreateAuraHeader("HELPFUL")
-	Module.BuffFrame.mover =
-		K.Mover(Module.BuffFrame, "Buffs", "BuffAnchor", { "TOPRIGHT", _G.Minimap, "TOPLEFT", -6, 0 })
+	Module.BuffFrame.mover = K.Mover(Module.BuffFrame, "Buffs", "BuffAnchor", { "TOPRIGHT", _G.Minimap, "TOPLEFT", -6, 0 })
 	Module.BuffFrame:ClearAllPoints()
 	Module.BuffFrame:SetPoint("TOPRIGHT", Module.BuffFrame.mover)
 
 	Module.DebuffFrame = Module:CreateAuraHeader("HARMFUL")
-	Module.DebuffFrame.mover = K.Mover(
-		Module.DebuffFrame,
-		"Debuffs",
-		"DebuffAnchor",
-		{ "TOPRIGHT", Module.BuffFrame.mover, "BOTTOMRIGHT", 0, -12 }
-	)
+	Module.DebuffFrame.mover = K.Mover(Module.DebuffFrame, "Debuffs", "DebuffAnchor", { "TOPRIGHT", Module.BuffFrame.mover, "BOTTOMRIGHT", 0, -12 })
 	Module.DebuffFrame:ClearAllPoints()
 	Module.DebuffFrame:SetPoint("TOPRIGHT", Module.DebuffFrame.mover)
 end
@@ -194,9 +188,9 @@ function Module:StartAuraTimer(button, timeLeft)
 	Module.UpdateTimer(button, 0)
 end
 
-function Module:GetSpellStat(arg16, arg17, arg18)
-	return (arg16 > 0 and L["Versa"]) or (arg17 > 0 and L["Mastery"]) or (arg18 > 0 and L["Haste"]) or L["Crit"]
-end
+-- function Module:GetSpellStat(arg16, arg17, arg18)
+-- 	return (arg16 > 0 and L["Versa"]) or (arg17 > 0 and L["Mastery"]) or (arg18 > 0 and L["Haste"]) or L["Crit"]
+-- end
 
 function Module:UpdateAuras(button, index)
 	local unit, filter = button.header:GetAttribute("unit"), button.filter
@@ -231,17 +225,14 @@ function Module:UpdateAuras(button, index)
 
 	local count = auraData.applications
 	if K.IsSecretValue(count) then
-		button.count:SetText(
-			C_UnitAuras.GetAuraApplicationDisplayCount(unit, auraData.auraInstanceID, MIN_SPELL_COUNT, MAX_SPELL_COUNT)
-		)
+		button.count:SetText(C_UnitAuras.GetAuraApplicationDisplayCount(unit, auraData.auraInstanceID, MIN_SPELL_COUNT, MAX_SPELL_COUNT))
 	else
 		local hideCount = not count or (count < MIN_SPELL_COUNT or count > MAX_SPELL_COUNT)
 		button.count:SetText(hideCount and "" or count)
 	end
 
 	if filter == "HARMFUL" then
-		local color = C_UnitAuras.GetAuraDispelTypeColor(unit, auraData.auraInstanceID, Module.DispelColorCurve)
-			or FALLBACK_COLOR
+		local color = C_UnitAuras.GetAuraDispelTypeColor(unit, auraData.auraInstanceID, Module.DispelColorCurve) or FALLBACK_COLOR
 		button.KKUI_Border:SetVertexColor(color.r, color.g, color.b)
 	else
 		button.KKUI_Border:SetVertexColor(1, 1, 1)
@@ -372,12 +363,7 @@ function Module:CreateAuraHeader(filter)
 end
 
 function Module:RemoveSpellFromIgnoreList()
-	if
-		IsAltKeyDown()
-		and IsControlKeyDown()
-		and self.spellID
-		and K.GetCharVars().AuraWatchList.IgnoreSpells[self.spellID]
-	then
+	if IsAltKeyDown() and IsControlKeyDown() and self.spellID and K.GetCharVars().AuraWatchList.IgnoreSpells[self.spellID] then
 		K.GetCharVars().AuraWatchList.IgnoreSpells[self.spellID] = nil
 		K.Print(string_format(L["RemoveFromIgnoreList"], "", self.spellID))
 	end
@@ -421,19 +407,20 @@ function Module:CreateAuraIcon(button)
 	button.count:SetFont(select(1, button.count:GetFont()), fontSize, select(3, button.count:GetFont()))
 
 	button.timer = button:CreateFontString(nil, "OVERLAY")
-	button.timer:SetPoint("TOP", button, "BOTTOM", 1, 5)
+	button.timer:SetPoint("TOP", button, "BOTTOM", 1, 2)
 	button.timer:SetFontObject(K.UIFontOutline)
 	button.timer:SetFont(select(1, button.timer:GetFont()), fontSize, select(3, button.timer:GetFont()))
 
 	local cd = CreateFrame("Cooldown", "$parentCooldown", button, "CooldownFrameTemplate")
 	cd:SetReverse(true)
-	--cd:SetEdgeTexture(DB.bgTex)
-	--cd:SetDrawSwipe(C.db["Auras"]["CDAnimation"])
+	cd:SetEdgeTexture("Interface\\Cooldown\\edge")
+	cd:SetDrawSwipe(true) -- We need to push this for config later. FIX ME!
 	cd:SetDrawBling(false)
 	button.Cooldown = cd
 
 	local text = cd:GetRegions()
-	--B.SetFontSize(text, fontSize)
+	text:SetFontObject(K.UIFontOutline)
+	text:SetFont(select(1, button.timer:GetFont()), fontSize, select(3, button.timer:GetFont()))
 	text:ClearAllPoints()
 	text:SetPoint("TOP", button, "BOTTOM", 1, 2)
 	button.CooldownText = text

KkthnxUI/Modules/Chat/Elements/Copy.lua

@@ -384,7 +384,7 @@ function Module:ChatCopy_Create()
 	configBtn:SetScript("OnClick", function(_, btn)
 		if btn == "LeftButton" then
 			PlaySound(111)
-			_G.K.LibEasyMenu.Create(menuList, K.EasyMenu, configBtn, 24, 290, "MENU", 2)
+			K.LibEasyMenu.Create(menuList, K.EasyMenu, configBtn, 24, 290, "MENU", 2)
 		elseif btn == "RightButton" then
 			K.NewGUI:Toggle()
 		end
@@ -443,13 +443,7 @@ function Module:ChatCopy_Create()
 		GameTooltip:ClearLines()
 		GameTooltip:AddLine(string_format("%s %s", _G.FAST, _G.ROLL))
 		GameTooltip:AddLine(" ")
-		GameTooltip:AddDoubleLine(
-			LEFT_BUTTON_STRING .. L["Left Click"],
-			"Roll a random number between 1 and 100",
-			1,
-			1,
-			1
-		)
+		GameTooltip:AddDoubleLine(LEFT_BUTTON_STRING .. L["Left Click"], "Roll a random number between 1 and 100", 1, 1, 1)
 		GameTooltip:AddDoubleLine(RIGHT_BUTTON_STRING .. L["Right Click"], "Guaranteed to roll a perfect 100!", 1, 1, 1)
 		GameTooltip:Show()
 	end)