Skip to content

Commit 2c0e746

Browse files
axelwalterclaude
andcommitted
fix: update tests to filter wildtype transcripts from variant-only assertions
The wildtype transcript yield (ef49d91) causes existing tests to receive an extra unmodified transcript. Filter with `if t.vars` so variant-only test logic is unaffected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 55941c1 commit 2c0e746

2 files changed

Lines changed: 11 additions & 9 deletions

File tree

epytope/test/TestGenerator.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ def test_non_syn_hetero_snp_trans_number(self):
6666
[self.non_syn_hetero_snp, self.non_frame_shift_del, self.syn_homo_snp]
6767

6868
trans = \
69-
[t for t in Generator.generate_transcripts_from_variants(vars_, self.db_adapter, EIdentifierTypes.REFSEQ)]
69+
[t for t in Generator.generate_transcripts_from_variants(vars_, self.db_adapter, EIdentifierTypes.REFSEQ)
70+
if t.vars]
7071

7172
self.assertTrue(len(trans) == 2**sum(not v.isHomozygous for v in vars_))
7273

@@ -85,17 +86,17 @@ def test_simple_incorporation(self):
8586

8687
# INSERTIONS:
8788
dummy_vars = [var_3]
88-
trans = next(Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ))
89+
trans = next(t for t in Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ) if t.vars)
8990
self.assertEqual(str(trans), "AAAAACCTTCCCGGGGG")
9091

9192
# SNPs:
9293
dummy_vars = [var_1]
93-
trans = next(Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ))
94+
trans = next(t for t in Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ) if t.vars)
9495
self.assertEqual(str(trans), "ATAAACCCCCGGGGG")
9596

9697
# DELETIONS:
9798
dummy_vars = [var_4]
98-
trans = next(Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ))
99+
trans = next(t for t in Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ) if t.vars)
99100
self.assertEqual(str(trans), "AAAAAGGGGG")
100101

101102
def test_offset_single(self):
@@ -112,13 +113,13 @@ def test_offset_single(self):
112113

113114
# 1) INS, SNP, DEL
114115
dummy_vars = [var_3, var_7, var_6]
115-
trans = next(Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ))
116+
trans = next(t for t in Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ) if t.vars)
116117

117118
self.assertEqual(str(trans), "AAAAACCTTCTGGGG")
118119

119120
# 2.) INS, DEL, INS
120121
dummy_vars = [var_9, var_4, var_8]
121-
trans = next(Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ))
122+
trans = next(t for t in Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ) if t.vars)
122123
self.assertEqual(str(trans), "AATTAAAGGGGGTTT")
123124

124125
def test_heterozygous_variants(self):
@@ -149,7 +150,7 @@ def test_heterozygous_variants(self):
149150
# 1) INS, SNP, DEL
150151
dummy_vars = [var_10, var_11, var_12]
151152
trans_gener = Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ)
152-
trans = [t for t in trans_gener]
153+
trans = [t for t in trans_gener if t.vars]
153154

154155
trans = list(map(str, trans))
155156

@@ -328,7 +329,7 @@ def test_proteins_from_variants(self):
328329
dummy_vars = [var_10, var_11, var_12]
329330
exp_prot = set(['KFG', 'KNLG', 'KFPPG', 'KNFPRG', 'GFK', 'GGLK', 'GFPPK', 'GFPPK', 'GGFPQK'])
330331
prot = set([str(x) for x in Generator.generate_proteins_from_transcripts(
331-
Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ))]
332+
(t for t in Generator.generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ) if t.vars))]
332333
)
333334
self.assertTrue(len(prot-exp_prot) == 0)
334335
self.assertTrue(len(exp_prot-prot) == 0)

epytope/test/TestProtein.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ def test3_protein_from_variants(self):
7979
dummy_vars = [var_10, var_11, var_12]
8080

8181
proteins = []
82-
t = list(generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ))
82+
t = [trans for trans in generate_transcripts_from_variants(dummy_vars, dummy_db, EIdentifierTypes.REFSEQ)
83+
if trans.vars]
8384
for trans in t:
8485
# check gene id field:
8586
print(trans)

0 commit comments

Comments
 (0)