fix: fixed scan model update issue

Author: GabiCtrlZ

backend/src/routes/scans.js

@@ -1,3 +1,4 @@
+import { Prisma } from '@prisma/client';
 import { Router } from 'express';
 import { prisma } from '../db.js';
 import {
@@ -161,7 +162,10 @@ export async function patchScanIfPresent(tx, scanId, body, { assertAvailable, av
     }
     data.status = status;
     if (status === 'pending' && existing.status !== 'pending') {
-      data.reasoning = null;
+      // Nullable Prisma JSON fields distinguish SQL NULL from the JSON scalar
+      // `null`. Scan reasoning is either an object or SQL NULL; storing a JSON
+      // scalar here breaks engine-side nested warning updates.
+      data.reasoning = Prisma.DbNull;
       data.lastResumedAt = new Date();
     }
   }

backend/test/dataIntegrity.test.js

@@ -1,5 +1,6 @@
 import test from 'node:test';
 import assert from 'node:assert/strict';
+import { Prisma } from '@prisma/client';
 
 import { prismaUniqueConflict } from '../src/app.js';
 import { DEFAULT_WORKFLOW_NAMES } from '../src/lib/defaultWorkflows.js';
@@ -338,7 +339,7 @@ test('failed scans resume through pending and establish a new error-history boun
   assert.equal(result.kind, 'updated');
   assert.equal(calls[0], 'lock');
   assert.equal(calls[1].data.status, 'pending');
-  assert.equal(calls[1].data.reasoning, null);
+  assert.equal(calls[1].data.reasoning, Prisma.DbNull);
   assert.ok(calls[1].data.lastResumedAt instanceof Date);
 });
 

engine/open_kritt_engine/db.py

@@ -497,7 +497,10 @@ def set_scan_storage_warning(
             """
             UPDATE public.scans
             SET reasoning = jsonb_set(
-                    coalesce(reasoning, '{}'::jsonb),
+                    CASE
+                        WHEN jsonb_typeof(reasoning) = 'object' THEN reasoning
+                        ELSE '{}'::jsonb
+                    END,
                     '{storage_warning}',
                     %s::jsonb,
                     true
@@ -519,6 +522,7 @@ def clear_scan_storage_warning(self, conn, scan_id: int) -> bool:
             SET reasoning = nullif(reasoning - 'storage_warning', '{}'::jsonb),
                 updated_at = now()
             WHERE id = %s
+              AND jsonb_typeof(reasoning) = 'object'
               AND reasoning ? 'storage_warning'
             RETURNING id
             """,

engine/tests/test_worker_backoff.py

@@ -350,7 +350,7 @@ def test_worker_clears_storage_warning_before_launching_after_recovery(monkeypat
     assert database.cleared == [58]
 
 
-def test_storage_warning_is_persisted_inside_scan_reasoning():
+def test_storage_warning_is_persisted_inside_object_normalized_scan_reasoning():
     conn = _RecordingConnection(rows=({"id": 58},))
 
     assert Database("").set_scan_storage_warning(
@@ -362,6 +362,8 @@ def test_storage_warning_is_persisted_inside_scan_reasoning():
 
     query, params = conn.calls[0]
     assert "'{storage_warning}'" in query
+    assert "jsonb_typeof(reasoning) = 'object'" in query
+    assert "ELSE '{}'::jsonb" in query
     assert "status IN ('prewarming_cache', 'running', 'post_processing')" in query
     assert params[0].obj["code"] == "low_storage"
     assert params[0].obj["free_bytes"] == 12 * 1024**3
@@ -375,6 +377,7 @@ def test_storage_warning_clear_preserves_other_scan_reasoning():
 
     query, params = conn.calls[0]
     assert "reasoning - 'storage_warning'" in query
+    assert "jsonb_typeof(reasoning) = 'object'" in query
     assert params == (58,)