Inject TpFileParser via DI into BaseStructureExplorer instead of using new

Replace explicit `new TpFileParser()` in BaseStructureExplorer.ExploreTpFile
with constructor-injected instance. The parser is already registered as a
singleton in TestCases/Setup.cs. This aligns with the project's DI
conventions and makes the registration no longer dead code.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: Burgyn

src/TeaPie/StructureExploration/BaseStructureExplorer.cs

@@ -5,12 +5,13 @@
 
 namespace TeaPie.StructureExploration;
 
-internal abstract class BaseStructureExplorer(IPathProvider pathProvider, ILogger logger) : IStructureExplorer
+internal abstract class BaseStructureExplorer(IPathProvider pathProvider, ILogger logger, TpFileParser tpFileParser) : IStructureExplorer
 {
     public const string RemoteFolderName = "~Remote";
     protected string _remoteFolderPath = string.Empty;
 
     protected readonly ILogger _logger = logger;
+    protected readonly TpFileParser _tpFileParser = tpFileParser;
     protected string? _environmentFileName;
     protected string? _initializationScriptName;
     protected IPathProvider _pathProvider = pathProvider;
@@ -86,16 +87,15 @@ protected static void ExploreTestCase(
         }
     }
 
-    protected static void ExploreTpFile(
+    protected void ExploreTpFile(
         string tpFilePath,
         CollectionStructure collectionStructure,
         Folder currentFolder)
     {
         var content = System.IO.File.ReadAllText(tpFilePath);
         var fallbackName = Path.GetFileNameWithoutExtension(tpFilePath);
 
-        var parser = new TpFileParser();
-        var definitions = parser.Parse(content, fallbackName);
+        var definitions = _tpFileParser.Parse(content, fallbackName);
 
         var relativePath = GetRelativePath(currentFolder, Path.GetFileName(tpFilePath));
 

src/TeaPie/StructureExploration/CollectionStructureExplorer.cs

@@ -1,10 +1,12 @@
 using Microsoft.Extensions.Logging;
 using TeaPie.StructureExploration.Paths;
+using TeaPie.TestCases;
 
 namespace TeaPie.StructureExploration;
 
-internal partial class CollectionStructureExplorer(IPathProvider pathProvider, ILogger<CollectionStructureExplorer> logger)
-    : BaseStructureExplorer(pathProvider, logger)
+internal partial class CollectionStructureExplorer(
+    IPathProvider pathProvider, ILogger<CollectionStructureExplorer> logger, TpFileParser tpFileParser)
+    : BaseStructureExplorer(pathProvider, logger, tpFileParser)
 {
     protected override CollectionStructure ExploreStructure(ApplicationContext applicationContext)
     {
@@ -60,7 +62,7 @@ private void ExploreFolder(Folder currentFolder, CollectionStructure collectionS
         ExploreTestCases(collectionStructure, currentFolder, files);
     }
 
-    private static void ExploreTestCases(
+    private void ExploreTestCases(
         CollectionStructure collectionStructure,
         Folder currentFolder,
         IList<string> files)

src/TeaPie/StructureExploration/TestCaseStructureExplorer.cs

@@ -1,10 +1,12 @@
 using Microsoft.Extensions.Logging;
 using TeaPie.StructureExploration.Paths;
+using TeaPie.TestCases;
 
 namespace TeaPie.StructureExploration;
 
-internal partial class TestCaseStructureExplorer(IPathProvider pathProvider, ILogger<TestCaseStructureExplorer> logger)
-    : BaseStructureExplorer(pathProvider, logger)
+internal partial class TestCaseStructureExplorer(
+    IPathProvider pathProvider, ILogger<TestCaseStructureExplorer> logger, TpFileParser tpFileParser)
+    : BaseStructureExplorer(pathProvider, logger, tpFileParser)
 {
     protected override CollectionStructure ExploreStructure(ApplicationContext applicationContext)
     {

tests/TeaPie.Tests/StructureExploration/CollectionStructureExplorerShould.cs

@@ -2,6 +2,7 @@
 using NSubstitute;
 using TeaPie.StructureExploration;
 using TeaPie.StructureExploration.Paths;
+using TeaPie.TestCases;
 using static Xunit.Assert;
 
 namespace TeaPie.Tests.StructureExploration;
@@ -222,5 +223,5 @@ public void PopulateTpDefinitionWithCorrectContent()
     }
 
     private static CollectionStructureExplorer GetStructureExplorer(IPathProvider? pathProvider = null)
-        => new(pathProvider ?? Substitute.For<IPathProvider>(), Substitute.For<ILogger<CollectionStructureExplorer>>());
+        => new(pathProvider ?? Substitute.For<IPathProvider>(), Substitute.For<ILogger<CollectionStructureExplorer>>(), new TpFileParser());
 }

tests/TeaPie.Tests/StructureExploration/TestCaseStructureExplorerShould.cs

@@ -2,6 +2,7 @@
 using NSubstitute;
 using TeaPie.StructureExploration;
 using TeaPie.StructureExploration.Paths;
+using TeaPie.TestCases;
 using static Xunit.Assert;
 
 namespace TeaPie.Tests.StructureExploration;
@@ -153,5 +154,5 @@ public void CreateMultipleTestCasesFromTpFileWithMultipleTestCaseBlocks()
     }
 
     private static TestCaseStructureExplorer GetStructureExplorer(IPathProvider? pathProvider = null)
-        => new(pathProvider ?? Substitute.For<IPathProvider>(), Substitute.For<ILogger<TestCaseStructureExplorer>>());
+        => new(pathProvider ?? Substitute.For<IPathProvider>(), Substitute.For<ILogger<TestCaseStructureExplorer>>(), new TpFileParser());
 }