Fix undefined array key 1 error in sectionsWithAppBlock (#448)

* fix(theme): allow hyphenated schema tags and guard against missing match

* remove unnecessary line

Author: thesunilyadav

src/Services/ThemeHelper.php

@@ -208,10 +208,11 @@ public function sectionsWithAppBlock(array $templateMainSections): array
             $asset = $assetResponse['body']['asset']->toArray();
 
             preg_match('/\{\%\s+schema\s+\%\}([\s\S]*?)\{\%\s+endschema\s+\%\}/m', $asset['value'], $matches);
-            $schema = json_decode($matches[1], true);
-
-            if ($schema && isset($schema['blocks'])) {
-                $acceptsAppBlock = in_array('@app', array_column($schema['blocks'], 'type'));
+            if (!empty($matches) && isset($matches[1])) {
+                $schema = json_decode($matches[1], true);
+                if ($schema && isset($schema['blocks'])) {
+                    $acceptsAppBlock = in_array('@app', array_column($schema['blocks'], 'type'));
+                }
             }
 
             return $acceptsAppBlock ? $file : null;

tests/Services/ThemeHelperTest.php

@@ -127,4 +127,32 @@ public function testSectionsWithAppBlock(): void
 
         $this->assertNotEmpty($sectionsWithApp);
     }
+
+    public function testSectionsWithAppBlockHandlesMissingSchema(): void
+    {
+        // Response stubbing
+        $this->setApiStub();
+        ApiStub::stubResponses([
+            'get_themes',
+            'get_theme_assets',
+            'get_theme_asset_no_schema',
+        ]);
+
+        // Define config to include a template
+        $this->app['config']->set(
+            'shopify-app.theme_support.templates',
+            [
+                'asset',
+            ]
+        );
+
+        // Run extraction
+        $this->helper->extractStoreMainTheme($this->shop->getId());
+        $jsonFiles = $this->helper->templateJSONFiles();
+        $mainSections = $this->helper->mainSections($jsonFiles);
+        $sectionsWithApp = $this->helper->sectionsWithAppBlock($mainSections);
+
+        // Assert no sections are returned and no error occurs
+        $this->assertEmpty($sectionsWithApp);
+    }
 }

tests/fixtures/get_theme_asset_no_schema.json

@@ -0,0 +1,6 @@
+{
+  "asset": {
+      "key": "sections/no-schema.liquid",
+      "value": "<!-- Invalid schema -->"
+    } 
+}