Commit 81a6f9c
authored
fix(core): treat a blank optional integer as missing (oomol-lab#277)
`optionalIntegerOrNull("")` returned `0` rather than `null`, because
`Number("")` is `0` and passes `Number.isInteger`. A blank optional
field reached the provider as a real zero.
```
optionalIntegerOrNull("") before: 0 after: null
optionalIntegerOrNull(" ") before: 0 after: null
```
Blank strings are now reported as missing. That matches the sibling
helpers `integer` and `optionalIntegerLike`, which already exclude an
empty string before parsing. Eight providers read optional integers
through this helper.1 parent 2ca1e8e commit 81a6f9c
2 files changed
Lines changed: 21 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
21 | 36 | | |
22 | 37 | | |
23 | 38 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
391 | 391 | | |
392 | 392 | | |
393 | 393 | | |
394 | | - | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
395 | 399 | | |
396 | 400 | | |
397 | 401 | | |
398 | 402 | | |
399 | 403 | | |
400 | | - | |
| 404 | + | |
401 | 405 | | |
402 | 406 | | |
403 | 407 | | |
| |||
0 commit comments