Skip to content

[Bug]: The should_save parameter in MelonPreferences.CreateCategory doesn't actually do anything. #1156

@iListen2Sound

Description

@iListen2Sound

All of the following criteria must be met

  • All Requirements must be installed.
  • Changed the title so that it doesn't just says "[Bug]: "
  • I have searched the GitHub issues for my bug, even in the closed issues.

All of the following are optional to answer

  • Tried reinstalling the Game.
  • Tried reinstalling MelonLoader.
  • Tried restarting PC.

Describe the issue.

I thought I was doing something wrong but I took a look at preferences.cs in this repo and the parameter doesn't actually go anywhere

        public static MelonPreferences_Category CreateCategory(string identifier, string display_name = null, bool is_hidden = false, bool should_save = true)
        {
            if (string.IsNullOrEmpty(identifier))
                throw new Exception("identifier is null or empty when calling CreateCategory");
            if (display_name == null)
                display_name = identifier;
            MelonPreferences_Category category = GetCategory(identifier);
            if (category != null)
                return category;
            return new MelonPreferences_Category(identifier, display_name, is_hidden);
        }

Did you attach your log file?

Select an option below

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bug / IssueSomething isn't workingImprovementNew feature or requestUser SupportThis post was made to ask about an issue the user is havingWork-in-ProgressThis issue or pull request is being worked on currently

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions