cleanup: Engine._LOG_MAX_LINES is defined once and read nowhere

[LeyckerS]

This issue is reserved for someone who has never had a pull request merged on GitHub before. If you have contributed before, please leave it — the roadmap has plenty of other work.

You are deleting one line. The point is to walk you through the process once.

The problem

moon_engine.py defines a constant on the Engine class:

    _LOG_MAX_LINES = 2000

Nothing reads it. Searching the whole repository — every .py and every .js file — finds exactly one occurrence, which is the definition itself.

It is left over from an earlier design. The log ring is bounded by collections.deque(maxlen=6000) in __init__, which is the limit that actually applies, so this constant is not even the real number. Leaving it there suggests a cap that does not exist.

The change

File: moon_engine.py

Delete the line _LOG_MAX_LINES = 2000 and the blank line that follows it, so that _get() is followed directly by log().

Please do not reformat or touch anything else in the file — a pull request that changes things the issue did not ask for gets sent back, even when the extra changes are harmless.

How to check you were right

Before you delete it, confirm for yourself that nothing uses it. From the repository folder:

grep -rn "_LOG_MAX_LINES" .

You should see exactly one line of output. Say in your pull request that you ran this and what it showed — checking the claim rather than trusting the issue is exactly the habit that matters here, and it has caught mistakes in my own issues before.

How to do it, step by step

1. Click Fork at the top right of this repository.
2. In your copy, open moon_engine.py and click the pencil icon to edit.
3. Find _LOG_MAX_LINES = 2000, delete that line and the empty line under it.
4. Under Commit changes, write something like cleanup: drop the unused _LOG_MAX_LINES constant, then Propose changes.
5. Click Create pull request, write Closes #80, and submit.

CI will byte-compile the file and run the test suite automatically. If something goes red, say so here — that is normal and it is not a problem.

Before you start

Comment here saying you are taking it. Then go ahead; no need to wait for a reply.

[mazi-eth]

Can you please assign this issue to me

[LeyckerS]

@mazi-eth — assigned, it is yours. And you are in the right place: this is one of three issues held back specifically for people who have not had a pull request merged anywhere yet, and you qualify. No one will race you for it.

The whole change is deleting these two lines from moon_engine.py:

    _LOG_MAX_LINES = 2000

plus the blank line after it. That is the entire task. It is defined once and read nowhere — the log ring is bounded by collections.deque(maxlen=6000) instead, so this constant does nothing.

You can do this entirely in the browser, no install:

1. Open moon_engine.py and click the pencil icon (top right of the file). GitHub forks the repository for you automatically.
2. Find _LOG_MAX_LINES — press Ctrl+F in the editor box, not the browser's find.
3. Delete the line and the blank line after it.
4. Scroll down, write a commit message — cleanup: remove the unused _LOG_MAX_LINES constant is fine — and choose "Create a new branch for this commit and start a pull request".
5. On the next screen, put Closes #80 in the description and click Create.

That is it. CI will run on its own, and the first time it may sit waiting for me to approve it — that is a GitHub setting for new contributors, not anything you did wrong.

One thing that will make this a better contribution than the diff suggests. If you are curious why a constant like this exists at all: moon_engine.py was once generated from a tkinter GUI that no longer exists in the repository. git log --all -- moon_tk.py build_engine.py shows where it went. Mentioning that in the pull request — that it is left over from the generated era, not just currently unused — is the kind of thing that turns a deletion into an explanation. Entirely optional.

If you get stuck at any step, say so here. That is what the issue is for, and asking is not a failure.