Docs on docker env are wrong?

[shu-kit]

https://github.com/LibreBooking/librebooking/blob/develop/docs/source/BASIC-CONFIGURATION.rst#docker-installation
https://librebooking.readthedocs.io/en/latest/BASIC-CONFIGURATION.html#docker-installation

-> I think the env migrated from LB_DB_* to LB_DATABASE_* - is that true? At least I had to change this to get it running and I had to dig around a bit so updating the docs would probably make it easier to jump in :)

[santifpinformatica]

Does it override your config.php file?

I set the following in the environment:
- LB_DB_HOST=db
- LB_DATABASE_HOSTSPEC=db

And even though they appear as environment variables, it doesn't override them. From what I can see, the entrypoint looks for them in JSON format:

sed
-i /config/config.php
-e "s:(['database']['user'].) '.':\1 '${LB_DATABASE_USER}':"
-e "s:(['database']['password'].) '.':\1 '${LB_DATABASE_PASSWORD}':"
-e "s:(['database']['name'].) '.':\1 '${LB_DATABASE_NAME}':"
-e "s:(['install.password'].) '.':\1 '${LB_INSTALL_PASSWORD}':"
-e "s:(['default.timezone'].) '.':\1 '${LB_DEFAULT_TIMEZONE}':"
-e "s:(['database']['hostspec'].) '.':\1 '${LB_DATABASE_HOSTSPEC}':"
-e "s:(['logging']['folder'].) '.':\1 '${LB_LOGGING_FOLDER}':"
-e "s:(['logging']['level'].) '.':\1 '${LB_LOGGING_LEVEL}':"
-e "s:(['logging']['sql'].) '.':\1 '${LB_LOGGING_SQL}':"

Also, even if both environment variables are set, unless I manually edit the PHP file, it doesn't detect them; LB_DB_HOST doesn't override the value in config.php

I'm using image: librebooking/librebooking:develop

[shukon]

Works for me with LB_APP_TITLE, LB_DEFAULT_LANGUAGE and LB_RESERVATION_START_TIME_CONSTRAINT. Haven't and won't check the others, but those propagate to the config.php.

[colisee]

@santifpinformatica : please refer to the file RUN.md inside the librebooking/docker repository. If you still have issues, please create one inside the librebooking/docker repository.

@JohnVillalovos : I believe that the librebooking/librebooking repo should not contain documentation that relates to containers. It should only mention that container technology is available and point the reader to the librebooking/docker repo. Likewise, I would suggest you specify in the issue template, that problems/questions relating to containers be created inside the librebooking/docker repo.