fix: correct PHPBench 1.6 configuration (runner.* options)

ERROR WAS: phpbench.json had top-level options that don't exist in 1.6
- 'bootstrap', 'env', 'extensions', 'output', 'paths' are not valid

FIXED: Use correct PHPBench 1.6 options structure
- runner.bootstrap, runner.path, runner.iterations, runner.revs, runner.warmup
- report.generators for output type

WORKFLOW: Use CLI flags instead of env var names
- --iterations=20 (not --env=ci)
- --revs=10
- --warmup=2
- Multiple --output flags for both json and console

This should now actually run the benchmarks.

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Author: vitormattos

.github/copilot-instructions.md

@@ -17,31 +17,18 @@ Benchmarks use **PHPBench** for rigorous performance testing with statistical an
 # Run all benchmarks with aggregate statistics
 composer benchmark:run
 
-# Compare against main branch (requires git history)
-composer benchmark:compare
+# Run with stricter settings (multiple revisions)
+vendor-bin/phpbench/vendor/phpbench/phpbench/bin/phpbench run --revs=10 --iterations=20 --warmup=2
 
-# Direct PHPBench invocation
+# Direct PHPBench invocation with custom options
 vendor-bin/phpbench/vendor/phpbench/phpbench/bin/phpbench run --report=aggregate
 ```
 
 PHPBench automatically:
 - Runs warmup iterations (eliminates JIT/opcache startup noise)
 - Executes multiple revisions for statistical confidence
-- Detects performance regressions
 - Reports mean, min, max, stdev, variance per benchmark
 
-### Updating performance baseline
-
-After merge to `main`, baseline must be updated manually (branch protection prevents auto-commit):
-
-1. Checkout `main`: `git checkout main && git pull`
-2. Run latest benchmarks: `composer benchmark:run --env=ci --output=json:build/benchmark-results.json`
-3. Update baseline: `cp build/benchmark-results.json .github/.performance/baseline.json`
-4. Commit: `git add .github/.performance/baseline.json && git commit -s -m "chore: update performance baseline"`
-5. Push: `git push origin main`
-
-Alternatively, download benchmark artifact from GitHub Actions > main branch run.
-
 ## Compliance and contribution
 
 - DCO sign-off is mandatory for every commit.

.github/workflows/performance.yml

@@ -12,12 +12,6 @@ on:
 jobs:
   performance:
     runs-on: ubuntu-latest
-    env:
-      # Conservative thresholds based on typical xobject-template compilation times
-      # Keep benchmarks tight to catch regressions early
-      BENCH_REVS: "10"
-      BENCH_ITERATIONS: "20"
-      BENCH_WARMUP: "2"
     steps:
       - uses: actions/checkout@v6
         with:
@@ -37,7 +31,9 @@ jobs:
       - name: Run benchmarks (strict CI mode with verbose output)
         run: |
           vendor-bin/phpbench/vendor/phpbench/phpbench/bin/phpbench run \
-            --env=ci \
+            --iterations=20 \
+            --revs=10 \
+            --warmup=2 \
             --report=aggregate \
             --output=json:build/benchmark-results.json \
             --output=console

phpbench.json

@@ -1,20 +1,8 @@
 {
-  "bootstrap": "vendor/autoload.php",
-  "extensions": ["PhpBench\\Extensions\\CoreExtension"],
-  "paths": ["benchmarks"],
-  "output": "console",
-  "env": {
-    "default": {
-      "title": "default",
-      "iterations": 10,
-      "revs": 5,
-      "warmup": 1
-    },
-    "ci": {
-      "title": "CI (strict)",
-      "iterations": 20,
-      "revs": 10,
-      "warmup": 2
-    }
-  }
+  "runner.bootstrap": "vendor/autoload.php",
+  "runner.path": "benchmarks",
+  "runner.iterations": 10,
+  "runner.revs": 5,
+  "runner.warmup": 1,
+  "report.generators": ["aggregate"]
 }