Add solver params; update main function API#3
Merged
Luis-Varona merged 1 commit intomainfrom Jun 6, 2025
Merged
Conversation
Added fields to the solver structs where needed (or, at least, indicated with a TODO that fields should be added instead of leaving the struct trivial). Updated the main function API to assert out of the gate that the matrix is square and to copy to avoid shared mutability. Also made the DEFAULT_SOLVER behavior more elegant with a default arg. Finally, corrected the (unfinished) approach docstring in types.jl.
|
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fields to the solver structs where needed (or, at least, indicated with a
TODOthat fields should be added instead of leaving the struct trivial). Updated the main function API to assert out of the gate that the matrix is square and to copy to avoid shared mutability. Also made theDEFAULT_SOLVERbehavior more elegant with a default arg. Finally, corrected the (unfinished) approach docstring intypes.jl.