You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use the PowerAsNumber and PowerNumberLimits features instead of PowerInWatts for the MicrowaveOvenControl cluster, and handle the PowerSetting field in SetCookingParameters accordingly
Copy file name to clipboardExpand all lines: CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -44,6 +44,7 @@ If you like this project and find it useful, please consider giving it a star on
44
44
### Fixed
45
45
46
46
-[irrigationSystem]: Remove the non-functional `singleZone` option; single-zone systems must now use `addZone` like any other zone.
47
+
-[microwaveOven]: Use the `PowerAsNumber` and `PowerNumberLimits` features instead of `PowerInWatts` for the `MicrowaveOvenControl` cluster, and handle the `PowerSetting` field in `SetCookingParameters` accordingly.
47
48
48
49
<ahref="https://www.buymeacoffee.com/luligugithub"><imgsrc="https://matterbridge.io/assets/bmc-button.svg"alt="Buy me a coffee"width="80"></a>
Copy file name to clipboardExpand all lines: docs/CHANGELOG.html
+1Lines changed: 1 addition & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -165,6 +165,7 @@ <h3 id="changed">Changed</h3>
165
165
<h3id="fixed">Fixed</h3>
166
166
<ul>
167
167
<li>[irrigationSystem]: Remove the non-functional <code>singleZone</code> option; single-zone systems must now use <code>addZone</code> like any other zone.</li>
168
+
<li>[microwaveOven]: Use the <code>PowerAsNumber</code> and <code>PowerNumberLimits</code> features instead of <code>PowerInWatts</code> for the <code>MicrowaveOvenControl</code> cluster, and handle the <code>PowerSetting</code> field in <code>SetCookingParameters</code> accordingly.</li>
168
169
</ul>
169
170
<p><ahref="https://www.buymeacoffee.com/luligugithub"><imgsrc="https://matterbridge.io/assets/bmc-button.svg" alt="Buy me a coffee" width="80"></a></p>
device.log.info(`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting powerSetting to ${request.powerSetting}`);
204
+
this.state.powerSetting=request.powerSetting;
194
205
}else{
195
-
device.log.info(`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no wattSettingIndex so set to the highest Watt setting for the selected CookMode`);
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no cookMode so set to Normal`);
212
214
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no cookTime so set to 30sec.`);
213
-
expect(loggerLogSpy).toHaveBeenCalledWith(
214
-
LogLevel.INFO,
215
-
`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no wattSettingIndex so set to the highest Watt setting for the selected CookMode`,
216
-
);
215
+
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no powerSetting so set to maxPower`);
217
216
218
217
// Test setCookingParameters - valid cookMode only
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting cookMode to 2`);
222
221
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no cookTime so set to 30sec.`);
223
-
expect(loggerLogSpy).toHaveBeenCalledWith(
224
-
LogLevel.INFO,
225
-
`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no wattSettingIndex so set to the highest Watt setting for the selected CookMode`,
226
-
);
222
+
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no powerSetting so set to maxPower`);
227
223
228
-
// Test setCookingParameters - no cookMode provided but valid cookTime and wattSettingIndex
224
+
// Test setCookingParameters - no cookMode provided but valid cookTime and powerSetting
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no cookMode so set to Normal`);
232
228
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting cookTime to 120`);
233
-
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting selectedWattIndex to 3`);
229
+
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting powerSetting to 30`);
234
230
235
231
// Test setCookingParameters - invalid cookTime (<0) -> default to 30sec
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting cookMode to 7`);
239
235
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no cookTime so set to 30sec.`);
240
-
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting selectedWattIndex to 0`);
236
+
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting powerSetting to 10`);
241
237
242
238
// Test setCookingParameters - cookTime > maxCookTime -> default to 30sec
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no cookMode so set to Normal`);
246
242
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no cookTime so set to 30sec.`);
247
-
expect(loggerLogSpy).toHaveBeenCalledWith(
248
-
LogLevel.INFO,
249
-
`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no wattSettingIndex so set to the highest Watt setting for the selected CookMode`,
250
-
);
243
+
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no powerSetting so set to maxPower`);
251
244
252
-
// Test setCookingParameters - invalid wattSettingIndex (out of range) -> default to highest supported index
245
+
// Test setCookingParameters - invalid powerSetting (out of range) -> default to maxPower
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting cookMode to 3`);
256
249
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting cookTime to 45`);
257
-
expect(loggerLogSpy).toHaveBeenCalledWith(
258
-
LogLevel.INFO,
259
-
`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no wattSettingIndex so set to the highest Watt setting for the selected CookMode`,
260
-
);
250
+
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called with no powerSetting so set to maxPower`);
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting cookMode to 4`);
266
256
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting cookTime to 90`);
267
-
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting selectedWattIndex to 2`);
257
+
expect(loggerLogSpy).toHaveBeenCalledWith(LogLevel.INFO,`MatterbridgeMicrowaveOvenControlServer: setCookingParameters called setting powerSetting to 50`);
268
258
269
259
// Test setCookingParameters - startAfterSetting false (no change expected)
0 commit comments