Use the Matter Auto fallback when SetTarget omits speed

Author: Luligu

CHANGELOG.md

@@ -34,6 +34,7 @@ If you like this project and find it useful, please consider giving it a star on
 ### Added
 
 - [closureControl]: Refactor `MoveTo` target-state fallbacks and set the main state to `Stopped` when the closure is already at the requested target, or `Moving` otherwise.
+- [closureDimension]: Use the Matter `Auto` fallback when `SetTarget` omits speed.
 
 ### Changed
 

docs/CHANGELOG.html

@@ -155,6 +155,7 @@ <h2 id="3105-dev-branch">[3.10.5] - Dev branch</h2>
 <h3 id="added">Added</h3>
 <ul>
 <li>[closureControl]: Refactor <code>MoveTo</code> target-state fallbacks and set the main state to <code>Stopped</code> when the closure is already at the requested target, or <code>Moving</code> otherwise.</li>
+<li>[closureDimension]: Use the Matter <code>Auto</code> fallback when <code>SetTarget</code> omits speed.</li>
 </ul>
 <h3 id="changed">Changed</h3>
 <ul>

packages/core/src/devices/closurePanel.ts

@@ -61,9 +61,8 @@ export class MatterbridgeClosureDimensionServer extends ClosureDimensionServer.w
       ...previousTarget,
       ...(request?.position !== undefined ? { position: request.position } : null),
       ...(request?.latch !== undefined ? { latch: request.latch } : null),
-      speed: request?.speed ?? previousTarget.speed ?? ThreeLevelAuto.Auto,
+      speed: request?.speed ?? ThreeLevelAuto.Auto,
     };
-
     this.state.targetState = nextTarget;
   };
 

packages/core/vitest/devices/closurePanel.test.ts

@@ -85,8 +85,12 @@ describe('Matterbridge ' + NAME, () => {
     await device.invokeBehaviorCommand('closureDimension', 'ClosureDimension.setTarget', { position: 5000 });
     expect(device.getAttribute(ClosureDimension.id, 'targetState')).toMatchObject({ position: 5000 });
 
-    // Exercise latch/speed optional fields.
-    await device.invokeBehaviorCommand('closureDimension', 'ClosureDimension.setTarget', { latch: true, speed: 2 });
+    await device.invokeBehaviorCommand('closureDimension', 'ClosureDimension.setTarget', { latch: true, speed: ThreeLevelAuto.Medium });
+    expect(device.getAttribute(ClosureDimension.id, 'targetState')).toMatchObject({ speed: ThreeLevelAuto.Medium });
+
+    // An omitted position retains its previous target, while an omitted speed falls back to Auto.
+    await device.invokeBehaviorCommand('closureDimension', 'ClosureDimension.setTarget', { latch: true });
+    expect(device.getAttribute(ClosureDimension.id, 'targetState')).toEqual({ position: 5000, latch: true, speed: ThreeLevelAuto.Auto });
 
     await device.invokeBehaviorCommand('closureDimension', 'ClosureDimension.step', {
       direction: ClosureDimension.StepDirection.Increase,