fix: address second-round review issues from PR ZhuLinsen#1053

- performance_tracker: guard record_prediction/get_analyst_weights/backfill_result with _db_available flag; use ANALYST_PERF_DB env var instead of hardcoded path
- backfill_performance: unpack (df, source) tuple from get_daily_data() call
- ReportOverview: gate MasterVotingDisk with Object.keys check; fix ExpertLeaderboard guard from .length to Object.keys().length
- analysis_service: use getattr for dashboard access to avoid AttributeError on SimpleNamespace
- tests: add analysis_mode=None to submit_tasks_batch assertions; accept **kwargs in thread-safety test mock

Author: xielevi

.env.example

@@ -553,3 +553,6 @@ ADMIN_AUTH_ENABLED=false
 # 东财接口补丁：东财/Efinance/Akshare 东方财富接口频繁失败（RemoteDisconnected、连接被关闭）时建议开启
 # 开启后会注入 NID 令牌与随机 User-Agent，降低被东财限流概率
 # ENABLE_EASTMONEY_PATCH=false
+
+# 专家战绩数据库路径（默认：workspace/analyst_performance.db，只读容器可指向 /tmp 等可写路径）
+# ANALYST_PERF_DB=workspace/analyst_performance.db

apps/dsa-web/src/components/report/ReportOverview.tsx

@@ -345,11 +345,13 @@ export const ReportOverview: React.FC<ReportOverviewProps> = ({
             </Card>
           )}
 
-          {/* 专家共识投票 */}
-          <MasterVotingDisk reports={details?.ensembleReports} />
-          
+          {/* 专家共识投票：仅在有集成报告时挂载 */}
+          {details?.ensembleReports && Object.keys(details.ensembleReports).length > 0 && (
+            <MasterVotingDisk reports={details.ensembleReports} />
+          )}
+
           {/* 专家胜率榜单：仅在有集成报告时展示，避免只读容器触发 DB 请求 */}
-          {details?.ensembleReports && details.ensembleReports.length > 0 && (
+          {details?.ensembleReports && Object.keys(details.ensembleReports).length > 0 && (
             <ExpertLeaderboard />
           )}
         </div>

scripts/backfill_performance.py

@@ -36,7 +36,7 @@ def get_5d_return(fetcher: DataFetcherManager, ticker: str, pred_date_str: str)
         pred_date = datetime.strptime(pred_date_str, "%Y-%m-%d")
         window_end = pred_date + timedelta(days=15)  # 多取一些，保证覆盖节假日
 
-        df = fetcher.get_daily_data(
+        df, _source = fetcher.get_daily_data(
             ticker,
             start_date=pred_date_str,
             end_date=window_end.strftime("%Y-%m-%d"),

src/services/analysis_service.py

@@ -173,7 +173,7 @@ def _build_analysis_response(
                 "technical_analysis": result.technical_analysis,
                 "fundamental_analysis": result.fundamental_analysis,
                 "risk_warning": result.risk_warning,
-                "ensemble_reports": result.dashboard.get("ensemble_reports") if result.dashboard else None,
+                "ensemble_reports": getattr(result, "dashboard", None) and result.dashboard.get("ensemble_reports"),
                 "radar_data": result.get_radar_data() if hasattr(result, "get_radar_data") else None,
             }
         }

src/services/performance_tracker.py

@@ -10,8 +10,11 @@ class PerformanceTracker:
     """
     专家战绩追踪器：负责持久化大师们的预测结果，并计算动态权重。
     """
-    def __init__(self, db_path: str = "workspace/analyst_performance.db"):
-        self.db_path = db_path
+    def __init__(self, db_path: str = ""):
+        self.db_path = db_path or os.environ.get(
+            "ANALYST_PERF_DB",
+            os.path.join("workspace", "analyst_performance.db"),
+        )
         self._db_available = False
         try:
             os.makedirs(os.path.dirname(self.db_path), exist_ok=True)
@@ -42,7 +45,11 @@ def _init_db(self):
     def record_prediction(self, analyst_id: str, ticker: str, signal: str, confidence: int) -> int:
         """
         记录一次专家的预测，返回新插入记录的 row ID。
+        DB 不可用时返回 -1 并记录警告，不抛出异常。
         """
+        if not self._db_available:
+            logger.warning("PerformanceTracker: DB unavailable, skipping record_prediction for %s/%s", analyst_id, ticker)
+            return -1
         date_str = datetime.now().strftime("%Y-%m-%d")
         with sqlite3.connect(self.db_path) as conn:
             cursor = conn.cursor()
@@ -58,10 +65,14 @@ def get_analyst_weights(self, lookback_days: int = 30) -> Dict[str, float]:
         计算各大师的动态权重，并进行归一化处理。
         算法：raw_weight = (accuracy + 0.1) ^ 1.5，归一化后所有权重之和为 1.0。
         如果没有历史战绩，使用等权基准值（1.0）参与归一化，确保新专家不被惩罚。
+        DB 不可用时直接返回等权权重。
         """
-        raw_weights = {}
         analysts = ["warren_buffett", "li_lu", "paul_tudor_jones", "jensen_huang", "nassim_taleb"]
+        if not self._db_available:
+            equal = round(1.0 / len(analysts), 4)
+            return {aid: equal for aid in analysts}
 
+        raw_weights = {}
         with sqlite3.connect(self.db_path) as conn:
             conn.row_factory = sqlite3.Row
             cursor = conn.cursor()
@@ -151,7 +162,11 @@ def backfill_result(self, record_id: int, actual_return: float):
         - signal=bearish 且 return < -1% -> 1 (Correct)
         - signal=neutral 且 |return| < 2% -> 1 (Correct)
         - 其他 -> 0 (Wrong)
+        DB 不可用时跳过并记录警告。
         """
+        if not self._db_available:
+            logger.warning("PerformanceTracker: DB unavailable, skipping backfill_result for record %s", record_id)
+            return
         with sqlite3.connect(self.db_path, isolation_level='IMMEDIATE') as conn:
             cursor = conn.cursor()
             cursor.execute("SELECT signal FROM track_record WHERE id = ? AND is_correct IS NULL", (record_id,))

tests/test_analysis_api_contract.py

@@ -652,6 +652,7 @@ def test_trigger_analysis_accepts_us_suffix_code(self) -> None:
             report_type="detailed",
             force_refresh=False,
             notify=True,
+            analysis_mode=None,
         )
 
     def test_trigger_analysis_accepts_hk_suffix_code_from_autocomplete(self) -> None:
@@ -687,6 +688,7 @@ def test_trigger_analysis_accepts_hk_suffix_code_from_autocomplete(self) -> None
             report_type="detailed",
             force_refresh=False,
             notify=True,
+            analysis_mode=None,
         )
 
     def test_trigger_analysis_accepts_hk_prefixed_code(self) -> None:
@@ -722,6 +724,7 @@ def test_trigger_analysis_accepts_hk_prefixed_code(self) -> None:
             report_type="detailed",
             force_refresh=False,
             notify=True,
+            analysis_mode=None,
         )
 
     def test_trigger_analysis_allows_stock_names_with_star_and_hyphen(self) -> None:
@@ -757,6 +760,7 @@ def test_trigger_analysis_allows_stock_names_with_star_and_hyphen(self) -> None:
             report_type="detailed",
             force_refresh=False,
             notify=True,
+            analysis_mode=None,
         )
 
     def test_trigger_analysis_accepts_resolvable_free_text_input(self) -> None:
@@ -792,6 +796,7 @@ def test_trigger_analysis_accepts_resolvable_free_text_input(self) -> None:
             report_type="detailed",
             force_refresh=False,
             notify=True,
+            analysis_mode=None,
         )
 
     def test_trigger_analysis_preserves_batch_metadata(self) -> None:
@@ -826,6 +831,7 @@ def test_trigger_analysis_preserves_batch_metadata(self) -> None:
             report_type="detailed",
             force_refresh=False,
             notify=True,
+            analysis_mode=None,
         )
 
     def test_trigger_analysis_rejects_cross_request_duplicate_for_equivalent_code_shapes(self) -> None:
@@ -916,6 +922,7 @@ def test_trigger_analysis_batch_does_not_apply_single_stock_name_to_all_tasks(se
             report_type="detailed",
             force_refresh=False,
             notify=True,
+            analysis_mode=None,
         )
 
     def test_spa_fallback_returns_json_404_for_bare_api_path(self) -> None:

tests/test_pipeline_single_notify_thread_safety.py

@@ -72,7 +72,7 @@ def test_process_single_stock_serializes_direct_notification_path(self):
 
         notify_barrier = threading.Barrier(2)
 
-        def _analyze(code, report_type, query_id):
+        def _analyze(code, report_type, query_id, **kwargs):
             notify_barrier.wait(timeout=10)
             return _make_result(code)