Merged
Conversation
30 tasks
24 tasks
ffreyer
commented
Jun 20, 2025
Collaborator
Author
I think it's better to leave this for the future. Right now it's not a breaking change, so we don't need to discuss it. It's also not finalized yet. We should figure out what to do with the Camera type (remove it? keep it as an output? keep it as an input?) and make sure the interface is user friendly before we start pushing it I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(incomplete) TODO;
pop!(attr, :name)replacementShould we mentionscene.computecamera matrices?Should we suggest avoidingshared_attributes()?