Refactor legality settings management

Author: Manu098vm

TeraFinder.Core/Utils/LegalityUtil.cs

@@ -0,0 +1,30 @@
+using PKHeX.Core;
+
+namespace TeraFinder.Core;
+
+public static class LegalityUtil
+{
+    public static LegalitySettings StoreLegalitySettings() => new()
+    {
+        CheckActiveHandler = ParseSettings.Settings.Handler.CheckActiveHandler,
+        ZeroHeightWeight = ParseSettings.Settings.HOMETransfer.ZeroHeightWeight
+    };
+
+    public static void SetDefaultlegalitySettings() => SetLegalitySettings(new()
+    {
+        CheckActiveHandler = false,
+        ZeroHeightWeight = Severity.Fishy
+    });
+
+    public static void SetLegalitySettings(LegalitySettings settings)
+    {
+        ParseSettings.Settings.Handler.CheckActiveHandler = settings.CheckActiveHandler;
+        ParseSettings.Settings.HOMETransfer.ZeroHeightWeight = settings.ZeroHeightWeight;
+    }
+
+    public struct LegalitySettings
+    {
+        public required bool CheckActiveHandler;
+        public required Severity ZeroHeightWeight;
+    }
+}

TeraFinder.Plugins/Utils/GridUtil.cs

@@ -163,16 +163,18 @@ public static void SaveSelectedPk9(this DataGridView dataGrid, CalculatorForm f,
                     {
                         if (enc.CanBeCaught)
                         {
-                            var checkActiveHandler = ParseSettings.Settings.Handler.CheckActiveHandler;
-                            ParseSettings.Settings.Handler.CheckActiveHandler = false;
+                            var settings = LegalityUtil.StoreLegalitySettings();
+                            LegalityUtil.SetDefaultlegalitySettings();
+
                             if (!enc.GeneratePK9(result.Value, id32, version, f.Editor.SAV.OT, f.Editor.SAV.Language, f.Editor.SAV.Gender, out var pk9, out var la))
                             {
                                 var la_encounter = la.Results.Where(l => l.Identifier is CheckIdentifier.Encounter).FirstOrDefault();
                                 if (content is RaidContent.Event or RaidContent.Event_Mighty)
                                     MessageBox.Show($"{strings["GridUtil.ErrorParsing"]}\n{strings["GridUtil.MissingData"]} [{enc.Identifier}].\n{strings["GridUtil.CheckWiki"]}");
                                 else
                                     MessageBox.Show($"{strings["GridUtil.ErrorParsing"]} {strings["GridUtil.Report"]}\n{la.Report()}");
-                                ParseSettings.Settings.Handler.CheckActiveHandler = checkActiveHandler;
+
+                                LegalityUtil.SetLegalitySettings(settings);
                                 return;
                             }
 
@@ -199,7 +201,7 @@ public static void SaveSelectedPk9(this DataGridView dataGrid, CalculatorForm f,
                                 MessageBox.Show($"{strings["GridUtil.Exported"]} {sfd.FileName}");
                             }
 
-                            ParseSettings.Settings.Handler.CheckActiveHandler = checkActiveHandler;
+                            LegalityUtil.SetLegalitySettings(settings);
                         }
                         else
                         {
@@ -383,8 +385,9 @@ public static void SendSelectedPk9Editor(this DataGridView dataGrid, CalculatorF
                     var id32 = TidUtil.GetID32(Convert.ToUInt32(f.txtTID.Text, 10), Convert.ToUInt32(f.txtSID.Text, 10));
 
                     var encounters = f.Editor.GetCurrentEncounters(content, map);
-                    var checkActiveHandler = ParseSettings.Settings.Handler.CheckActiveHandler;
-                    ParseSettings.Settings.Handler.CheckActiveHandler = false;
+
+                    var settings = LegalityUtil.StoreLegalitySettings();
+                    LegalityUtil.SetDefaultlegalitySettings();
 
                     if (EncounterRaidTF9.TryGenerateTeraDetails(seed, encounters, version, progress, eventProgress, content, map, id32, groupid, out var enc, out var result))
                     {
@@ -398,11 +401,11 @@ public static void SendSelectedPk9Editor(this DataGridView dataGrid, CalculatorF
                                 else
                                     MessageBox.Show($"{strings["GridUtil.ErrorParsing"]} {strings["GridUtil.Report"]}\n{la.Report()}");
 
-                                ParseSettings.Settings.Handler.CheckActiveHandler = checkActiveHandler;
+                                LegalityUtil.SetLegalitySettings(settings);
                                 return;
                             }
 
-                            ParseSettings.Settings.Handler.CheckActiveHandler = checkActiveHandler;
+                            LegalityUtil.SetLegalitySettings(settings);
                             f.Editor.PKMEditor!.PopulateFields(pk9!, true);
                         }
                         else

TeraFinder.Tests/GenerateEntities.cs

@@ -13,7 +13,7 @@ public class GenerateEntities
         [Fact]
         public void TestEncounterTeraTF9Standard()
         {
-            ParseSettings.Settings.Handler.CheckActiveHandler = false;
+            LegalityUtil.SetDefaultlegalitySettings();
             for (var map = TeraRaidMapParent.Paldea; map <= TeraRaidMapParent.Blueberry; map++)
             {
                 var encounters = ResourcesUtil.GetAllTeraEncounters(map).standard;
@@ -26,7 +26,7 @@ public void TestEncounterTeraTF9Standard()
         [Fact]
         public void TestEncounterTeraTF9Black()
         {
-            ParseSettings.Settings.Handler.CheckActiveHandler = false;
+            LegalityUtil.SetDefaultlegalitySettings();
             for (var map = TeraRaidMapParent.Paldea; map <= TeraRaidMapParent.Blueberry; map++)
             {
                 var encounters = ResourcesUtil.GetAllTeraEncounters(map).black;
@@ -38,7 +38,7 @@ public void TestEncounterTeraTF9Black()
         [Fact]
         public void TestEncounterEventTF9()
         {
-            ParseSettings.Settings.Handler.CheckActiveHandler = false;
+            LegalityUtil.SetDefaultlegalitySettings();
             var (eventsData, mightyData) = ResourcesUtil.GetAllEventEncounters();
             var events = SeedCheckerUtil.GroupEventEncounters(eventsData);
             var mighty = SeedCheckerUtil.GroupEventEncounters(mightyData);