Skip to content

Commit 54de40c

Browse files
committed
Refactor measure as suggested by co-pilot
1 parent 24a252a commit 54de40c

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

src/controllers/measure.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,16 @@ export const attachLookupTableToMeasure = async (req: Request, res: Response, ne
8787
res.json(result);
8888
return;
8989
}
90+
await updateRevisionTasks(dataset, dataset.measure.id, 'measure');
9091
build = await BuildLog.startBuild(dataset.draftRevision, CubeBuildType.FullCube, userId);
9192
result.extension = {
9293
build_id: build.id
9394
};
94-
await updateRevisionTasks(dataset, dataset.measure.id, 'measure');
95+
void createAllCubeFiles(dataset.id, dataset.draftRevision!.id, userId, CubeBuildType.FullCube, build).catch(
96+
(err) => {
97+
logger.error(err, 'Something went wrong trying to build the cube when attaching a measure lookup');
98+
}
99+
);
95100
res.status((result as ViewErrDTO).status || 200);
96101
res.json(result);
97102
} catch (err) {
@@ -101,10 +106,6 @@ export const attachLookupTableToMeasure = async (req: Request, res: Response, ne
101106
} finally {
102107
void cleanupTmpFile(tmpFile);
103108
}
104-
105-
void createAllCubeFiles(dataset.id, dataset.draftRevision!.id, userId, CubeBuildType.FullCube, build).catch((err) => {
106-
logger.error(err, 'Something went wrong trying to build the cube when attaching a measure lookup');
107-
});
108109
};
109110

110111
export const getPreviewOfMeasure = async (req: Request, res: Response, next: NextFunction): Promise<void> => {

0 commit comments

Comments
 (0)