refactor(types): clear interfaceGenerator and classGenerator

334 -> 307, continuing the noUncheckedIndexedAccess adoption on develop now that
1.6.0 is published.

interfaceGenerator: the base-field index skips a field whose name has no last
segment; the slice-binding lookup reads the first slice once and keys off it
rather than testing .length and then indexing; the Omit<> post-pass guards the
interface entry, the captured base type and the property-name capture.

classGenerator: the binding-code skeleton returns when bindingCodes yields no
primary code, since there is no value to emit without one; the coding-profile
branch keys off profileUrls?.[0]; the pattern-CodeableConcept branch takes the
first coding through optional indexing; the complex-skeleton lookup holds the
mapped expression instead of indexing the record twice.

Both shape emitted classes and interfaces rather than validators, so output was
diffed directly against the previous commit for us-core@9.0.0. The only
difference across the package is the valueDateTime timestamp inside a random()
literal, which differs between any two runs.

No `!` anywhere. Typecheck, lint and 748 tests green.

Author: quotentiroler

src/generator/emitters/class/classGenerator.ts

@@ -199,7 +199,10 @@ export function generateClass(className: string, interfaceName: string, baseReso
           .filter((s): s is string => typeof s === 'string' && s.length > 0);
         const uniqueSystems = Array.from(new Set(systems));
         const singleSystem = uniqueSystems.length === 1 ? JSON.stringify(uniqueSystems[0]) : undefined;
+        // bindingCodes is non-empty per the guard above, but indexing does not say
+        // so; without a code there is no skeleton value to emit.
         const primary = rf.bindingCodes[0];
+        if (!primary) continue;
         if (rf.type === 'CodeableConcept') {
           const expr = singleSystem
             ? `skeletonCodeableConcept(${singleSystem}, ${codesArray})`
@@ -364,8 +367,8 @@ export function generateClass(className: string, interfaceName: string, baseReso
           }
 
           // Check profile URLs for known coding profiles
-          if (slice.profileUrls && slice.profileUrls.length > 0) {
-            const profileUrl = slice.profileUrls[0];
+          const profileUrl = slice.profileUrls?.[0];
+          if (profileUrl) {
             const profileUrlLower = profileUrl.toLowerCase();
             // ISiK SNOMED-CT coding profile
             if (profileUrlLower.includes('snomedctcoding') || profileUrlLower.includes('snomed')) {
@@ -396,7 +399,7 @@ export function generateClass(className: string, interfaceName: string, baseReso
             }
             code = JSON.stringify(slice.binding.sampleCode.code);
             codeResolved = true;
-          } else if (sliceBindingMatchesParent && slice.binding?.codes && slice.binding.codes.length > 0) {
+          } else if (sliceBindingMatchesParent && slice.binding?.codes?.[0]) {
             // Fallback to first code from the binding's codes array
             const firstCode = slice.binding.codes[0];
             if (firstCode.system) {
@@ -467,8 +470,8 @@ export function generateClass(className: string, interfaceName: string, baseReso
       // Handle CodeableConcept with pattern constraint - use the pattern instead of skeleton
       if (rf.type === 'CodeableConcept' && rf.patternConstraint && typeof rf.patternConstraint === 'object') {
         const pc = rf.patternConstraint as { coding?: Array<{ system?: string; code?: string; display?: string }> };
-        if (pc.coding && Array.isArray(pc.coding) && pc.coding.length > 0) {
-          const firstCoding = pc.coding[0];
+        const firstCoding = Array.isArray(pc.coding) ? pc.coding[0] : undefined;
+        if (firstCoding) {
           const systemStr = JSON.stringify(firstCoding.system || TS.NULL_FLAVOR);
           const codeStr = JSON.stringify(firstCoding.code || 'UNK');
           const displayStr = firstCoding.display ? `, ${JSON.stringify(firstCoding.display)}` : '';
@@ -533,8 +536,9 @@ export function generateClass(className: string, interfaceName: string, baseReso
       }
       // Complex type skeletons (also check baseType for profiled types like CodeableConcept-uv-ips)
       const skeletonType = COMPLEX_SKELETON_MAP[rf.type] ? rf.type : (rf.baseType && COMPLEX_SKELETON_MAP[rf.baseType] ? rf.baseType : undefined);
-      if (skeletonType) {
-        const expr = COMPLEX_SKELETON_MAP[skeletonType];
+      const skeletonExpr = skeletonType ? COMPLEX_SKELETON_MAP[skeletonType] : undefined;
+      if (skeletonType && skeletonExpr) {
+        const expr = skeletonExpr;
         const initExpr = buildValueExpression(rf, expr);
         requiredInits.push(`${propKey(rf.name)}: ${initExpr}`);
         continue;

src/generator/emitters/interface/interfaceGenerator.ts

@@ -86,7 +86,8 @@ export function generateInterfaces(
     const baseFieldAnyArray = new Map<string, boolean>();
     for (const bf of baseFields) {
         const parts = bf.name.split('.');
-        const seg = parts[parts.length - 1];
+        const seg = parts.at(-1);
+        if (!seg) continue;
         if (!baseFieldByLastSegment.has(seg)) baseFieldByLastSegment.set(seg, bf);
         // Track the widest array flag across direct children only (not nested duplicates)
         if (bf.isArray && parts.length === 2) baseFieldAnyArray.set(seg, true);
@@ -112,10 +113,11 @@ export function generateInterfaces(
             );
 
             // Use the first slice binding if available (slices typically have more specific constraints)
-            if (slicesForThisField.length > 0 && slicesForThisField[0].binding) {
-                binding = slicesForThisField[0].binding;
+            const firstSlice = slicesForThisField[0];
+            if (firstSlice?.binding) {
+                binding = firstSlice.binding;
                 isSlicedField = true;
-                debug(`Using binding from slice ${slicesForThisField[0].sliceName} for ${field.name}`);
+                debug(`Using binding from slice ${firstSlice.sliceName} for ${field.name}`);
             }
         }
 
@@ -238,20 +240,21 @@ export function generateInterfaces(
     // This must run after all interfaces + extension unions are assembled.
     for (let i = 0; i < interfaces.length; i++) {
         const iface = interfaces[i];
+        if (!iface) continue;
         // Match "export interface Foo extends Bar {" or "export interface Foo extends Omit<Bar, ...> {"
         const extendsMatch = iface.match(/^export interface (\S+) extends (Omit<)?(\S+?)([,>])? \{/);
         if (!extendsMatch) continue;
         const alreadyOmit = !!extendsMatch[2];
         const baseType = extendsMatch[3];
         // Only wrap FHIR base types (not local profile interfaces)
-        if (!isFhirType(baseType)) continue;
+        if (!baseType || !isFhirType(baseType)) continue;
         // Extract all declared property names from the interface body
         const bodyStart = iface.indexOf('{');
         const body = iface.slice(bodyStart + 1);
         const propNames: string[] = [];
         for (const line of body.split('\n')) {
-            const m = line.match(/^\s+(\w+)[?:]/);
-            if (m && m[1] !== 'resourceType') propNames.push(m[1]);
+            const propName = line.match(/^\s+(\w+)[?:]/)?.[1];
+            if (propName && propName !== 'resourceType') propNames.push(propName);
         }
         if (propNames.length === 0) continue;
         const omitKeys = propNames.map(p => `'${p}'`).join(' | ');
@@ -306,7 +309,7 @@ export function generateInterfaces(
         logger.debug('[DEBUG FINAL INTERFACES]', {
             interfaceName,
             interfaceCount: interfaces.length,
-            interfaceNames: interfaces.map(i => i.split('\n')[0]).filter(n => n.includes('ConditionDeBasis02'))
+            interfaceNames: interfaces.map(i => i.split('\n')[0] ?? '').filter(n => n.includes('ConditionDeBasis02'))
         });
     }