Skip to content

MAT-9816: Add admin user profile library delete coverage - #3095

Open
edrubio-icf wants to merge 1 commit into
masterfrom
mat-9816-admin-user-profile-library-delete
Open

MAT-9816: Add admin user profile library delete coverage#3095
edrubio-icf wants to merge 1 commit into
masterfrom
mat-9816-admin-user-profile-library-delete

Conversation

@edrubio-icf

Copy link
Copy Markdown
Contributor

Summary

Adds Cypress coverage for MAT-9816 Admin User Profile library deletion and MAT-9892 admin single-instance library deletion.

Changes

  • Added requestAdminCqlLibraryDeleteById(...) to TestData.
  • Added MAT-9892 service coverage for deleting a single version by document ID and validating owner HARP ID protection.
  • Added Admin User Profile library Delete action-state coverage:
    • No selection disabled.
    • Latest draft/version enabled.
    • Historical version disabled.
    • Multiple selection disabled.
    • Owned and Shared Libraries.
    • QI-Core and QDM coverage.
  • Added Admin User Profile delete-dialog coverage:
    • Draft/version-specific confirmation text.
    • Warning, separators, red delete button.
    • Cancel and close-X behavior.
  • Added regular-user delete-dialog Cancel and close-X regression coverage without duplicating existing successful-delete coverage.
  • Updated the Cypress refactor backlog with the resolved MAT-9892 admin-scope finding.

Validation

  • npm run compile
  • npm run quality:no-focused-tests
  • git diff --check
  • DEV: AdminUserProfileLibraryDeleteActions.cy.ts — 5 passing.
  • DEV: CQLLibraryDeleteDialog.cy.ts — 2 passing.
  • DEV: MAT-9892 service scenarios passed.

Known DEV Gaps

The active Admin User Profile confirmation tests document two product issues:

  • Owned draft deletion returns 403 for an admin instead of 200.
  • Shared version deletion calls the correct MAT-9892 endpoint but sends the selected shared user’s HARP ID instead of the actual library owner’s HARP ID, resulting in 409.

Risk

Low. This PR changes Cypress coverage and shared test helpers only.

Documentation

Updated docs/quality/test-refactor-backlog.md.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 99 high · 1 minor

Alerts:
⚠ 100 issues (≤ 0 issues of at least minor severity)

Results:
100 new issues

Category Results
ErrorProne 99 high
CodeStyle 1 minor

View in Codacy

🟢 Metrics 20 complexity · 12 duplication

Metric Results
Complexity 20
Duplication 12

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant