Skip to content

Commit 5975c02

Browse files
MAT-8732 refactored code
1 parent 4150e9a commit 5975c02

2 files changed

Lines changed: 16 additions & 17 deletions

File tree

src/main/java/cms/gov/madie/measure/resources/AdminController.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -160,14 +160,17 @@ public void resetTestCaseValidationQueue(
160160
} else if (TestCaseValidationStatus.VALIDATING
161161
.toString()
162162
.equalsIgnoreCase(testCase.getValidationStatus())) {
163-
measureRepository.setValidationStatusToPending(
164-
testCase.getId(), measure.getId());
165-
// submit the test case after updating its status
166-
testCaseValidationService.submitOnSaveValidationTask(
167-
measure.getId(),
168-
testCase,
169-
accessToken,
170-
ModelType.valueOfName(measure.getModel()));
163+
Measure updatedMeasure =
164+
measureRepository.setValidationStatusToPending(
165+
testCase.getId(), measure.getId());
166+
if (updatedMeasure != null) {
167+
// submit the test case after updating its status
168+
testCaseValidationService.submitOnSaveValidationTask(
169+
measure.getId(),
170+
testCase,
171+
accessToken,
172+
ModelType.valueOfName(measure.getModel()));
173+
}
171174
}
172175
});
173176
}

src/test/java/cms/gov/madie/measure/resources/AdminControllerMvcTest.java

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -741,7 +741,6 @@ public void updateTestCaseValidationStatusProcessesValidatingTestCases() throws
741741
when(measureRepository.findAllByModel(ModelType.QI_CORE_6_0_0.getValue()))
742742
.thenReturn(List.of(measure));
743743

744-
// Mock the repository behavior to update the validation status to PENDING
745744
doAnswer(
746745
invocation -> {
747746
String testCaseId = invocation.getArgument(0, String.class);
@@ -752,7 +751,7 @@ public void updateTestCaseValidationStatusProcessesValidatingTestCases() throws
752751
.get(0)
753752
.setValidationStatus(TestCaseValidationStatus.PENDING.toString());
754753
}
755-
return null;
754+
return measure;
756755
})
757756
.when(measureRepository)
758757
.setValidationStatusToPending(anyString(), anyString());
@@ -768,7 +767,10 @@ public void updateTestCaseValidationStatusProcessesValidatingTestCases() throws
768767

769768
verify(testCaseValidationService, times(1))
770769
.submitOnSaveValidationTask(
771-
eq("M1"), any(TestCase.class), eq("test-okta"), eq(ModelType.QI_CORE_6_0_0));
770+
eq("M1"),
771+
eq(measure.getTestCases().get(0)),
772+
eq("test-okta"),
773+
eq(ModelType.QI_CORE_6_0_0));
772774
assertEquals(
773775
TestCaseValidationStatus.PENDING.toString(),
774776
measure.getTestCases().get(0).getValidationStatus());
@@ -929,12 +931,6 @@ public void updateTestCaseValidationStatusProcessesMultipleTestCasesWithDifferen
929931
.header("Authorization", "test-okta"))
930932
.andExpect(status().isOk());
931933

932-
verify(testCaseValidationService, times(1))
933-
.submitOnSaveValidationTask(
934-
eq("M1"),
935-
eq(measure.getTestCases().get(0)),
936-
eq("test-okta"),
937-
eq(ModelType.QI_CORE_6_0_0));
938934
verify(testCaseValidationService, times(1))
939935
.submitOnSaveValidationTask(
940936
eq("M1"),

0 commit comments

Comments
 (0)