fix(slurmCI): make archiveImage jobIdFile read non-fatal

If cat fails (file missing, allocation never wrote it), the export
should be best-effort — not hard-fail the pipeline step. Move the
jobId read inside the existing try/catch along with the export sh().

Also promote the unresolved-path check to an else-if before the try,
avoiding an unnecessary sh invocation when the path is known bad.

Signed-off-by: NirWolfer <nwolfer@nvidia.com>

Author: NirWolfer

vars/slurmCI.groovy

@@ -94,34 +94,32 @@ int call(ctx, oneStep, config) {
             def containerName = args.containerName
             if (!jobIdFile || !containerName) {
                 echo "archiveImage: skipping export — jobIdFile or containerName is null (step '${oneStep.name}')"
+            } else if (resolvedOutputPath.contains('${')) {
+                echo "archiveImage: skipping export — outputPath contains unresolved variables: ${resolvedOutputPath}"
             } else {
-                def jobId = ''
-                withEnv(["ARCHIVE_JOB_ID_FILE=${jobIdFile}"]) {
-                    jobId = sh(script: 'cat "$ARCHIVE_JOB_ID_FILE"', returnStdout: true).trim()
-                }
-                jobId = jobId.replaceAll(/[^0-9]/, '')
-                if (resolvedOutputPath.contains('${')) {
-                    echo "archiveImage: skipping export — outputPath contains unresolved variables: ${resolvedOutputPath}"
-                } else {
-                    try {
-                        withEnv([
-                            "ARCHIVE_CONTAINER=${containerName}",
-                            "ARCHIVE_OUTPUT=${resolvedOutputPath}",
-                            "ARCHIVE_JOB_ID=${jobId}",
-                            "ARCHIVE_ENROOT_DATA_PATH=${env.ENROOT_DATA_PATH ?: ''}",
-                        ]) {
-                            sh(label: "archiveImage: export '${containerName}' -> ${resolvedOutputPath}", script: '''
+                try {
+                    def jobId = ''
+                    withEnv(["ARCHIVE_JOB_ID_FILE=${jobIdFile}"]) {
+                        jobId = sh(script: 'cat "$ARCHIVE_JOB_ID_FILE"', returnStdout: true).trim()
+                    }
+                    jobId = jobId.replaceAll(/[^0-9]/, '')
+                    withEnv([
+                        "ARCHIVE_CONTAINER=${containerName}",
+                        "ARCHIVE_OUTPUT=${resolvedOutputPath}",
+                        "ARCHIVE_JOB_ID=${jobId}",
+                        "ARCHIVE_ENROOT_DATA_PATH=${env.ENROOT_DATA_PATH ?: ''}",
+                    ]) {
+                        sh(label: "archiveImage: export '${containerName}' -> ${resolvedOutputPath}", script: '''
 #!/bin/bash
 set -euo pipefail
 mkdir -p "$(dirname "$ARCHIVE_OUTPUT")"
 scctl --raw-errors client connect -- srun --jobid="$ARCHIVE_JOB_ID" --ntasks=1 --oversubscribe env ENROOT_DATA_PATH="$ARCHIVE_ENROOT_DATA_PATH" enroot export --output "$ARCHIVE_OUTPUT" "pyxis_$ARCHIVE_CONTAINER"
 echo "Export complete: $ARCHIVE_OUTPUT"
 echo "To debug: see docs/ci/crash-debug.md"
 ''')
-                        }
-                    } catch (e) {
-                        echo "archiveImage: export failed (non-fatal): ${e.message}"
                     }
+                } catch (e) {
+                    echo "archiveImage: export failed (non-fatal): ${e.message}"
                 }
             }
         }