Skip to content

Commit df857cc

Browse files
authored
Merge pull request #2163 from ATKabli/fix/rerank-label-dashless-model
fix: crash in --llm-rerank output for model names without a dash
2 parents b6eae9b + d64ad8d commit df857cc

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

benchmarks/locomo_bench.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@ def run_benchmark(
665665
palace_cache = json.load(f)
666666
print(f" Palace cache: {len(palace_cache)} room assignments loaded")
667667

668-
rerank_label = f" + LLM re-rank ({llm_model.split('-')[1]})" if llm_rerank_enabled else ""
668+
rerank_label = f" + LLM re-rank ({llm_model})" if llm_rerank_enabled else ""
669669

670670
print(f"\n{'=' * 60}")
671671
print(" MemPal × LoCoMo Benchmark")

benchmarks/longmemeval_bench.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3015,7 +3015,7 @@ def run_benchmark(
30153015

30163016
if unique_sessions and api_key and not skip_precompute:
30173017
print(
3018-
f" Diary ingest: pre-computing {len(unique_sessions)} sessions with {llm_model.split('-')[1]}..."
3018+
f" Diary ingest: pre-computing {len(unique_sessions)} sessions with {llm_model}..."
30193019
)
30203020
done = 0
30213021
cache_path = Path(diary_cache_file) if diary_cache_file else None
@@ -3051,9 +3051,8 @@ def run_benchmark(
30513051
print(f" Data: {Path(data_file).name}")
30523052
print(f" Questions: {len(data)}")
30533053
print(f" Granularity: {granularity}")
3054-
model_short = llm_model.split("-")[1] if "-" in llm_model else llm_model
3055-
rerank_label = f" + LLM re-rank ({model_short})" if llm_rerank_enabled else ""
3056-
diary_label = f" [diary ingest: {model_short}]" if mode == "diary" else ""
3054+
rerank_label = f" + LLM re-rank ({llm_model})" if llm_rerank_enabled else ""
3055+
diary_label = f" [diary ingest: {llm_model}]" if mode == "diary" else ""
30573056
print(f" Mode: {mode}{diary_label}{rerank_label}")
30583057
print(f"{'─' * 60}\n")
30593058

0 commit comments

Comments
 (0)