fix(mcp): purge stale closets on drawer update and delete

Closets are mined once from a source file's content and only rebuilt by
re-mining that file. tool_update_drawer and tool_delete_drawer never
touched them, so a corrected or deleted drawer left a closet quoting the
old text indefinitely, and search boosts ranking by source_file, so a
stale closet could outrank the corrected drawer.

Purge the matching source's closets through _purge_source_closets, the
helper delete_by_source already uses for this reason. update_drawer
purges only when content changes; a wing/room move alone leaves the
quoted text correct.

Fixes #2325

Author: AmirF194

CHANGELOG.md

@@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 ### Bug Fixes
 
 - **A palace with no database is no longer reported as one that passed its integrity check.** `sqlite_integrity_errors` answers `[]` when `chroma.sqlite3` is absent, and the MCP gate published that as `checked: true, ok: true`. Absence is now decided by `ENOENT` alone, which proves that nothing resolves under the path, and reported as the not-applicable shape #1931 introduced, `checked: false`/`ok: null` plus a reason. Every state that is not proven absent reaches the probe, and a probe that cannot open the file reports `PRAGMA quick_check failed`, which trips the existing `-32002` refusal: a dangling symlink, a database under an unreadable directory, a symlink loop, a name the filesystem rejects, an embedded NUL in the path, and, on POSIX, a palace path whose parent is a file. A palace directory named with a byte that is not valid UTF-8 reached the probe and, up to Python 3.12, raised out of it, which `mempalace mine` and `mempalace repair` never guarded against; it is now reported like every other unreadable path. `/statusz` reads an absent verdict as healthy, so the new `ok: null` does not turn a fresh install red, and non-chroma backends stop reporting themselves unhealthy, which they had done since the #1931 fix. The size-limited startup skip still publishes a clean verdict; the only change there is that it no longer inherits the previous probe's absence reason. (#2290)
+- **`update_drawer` and `delete_drawer` no longer strand stale closets at the mutated drawer's source.** Closets are the AAAK search-index layer, built once from a source file's raw content at mine time, and neither per-drawer mutation tool ever touched them: correcting a drawer in place left its closet quoting the pre-correction text indefinitely, and deleting a drawer left its closet's `->drawer_id` pointer dangling. `search_memories` boosts ranking by `source_file` and previews the closet document verbatim, so a retracted instruction could keep out-ranking its own corrected drawer. Both tools now purge the matching source's closets through the existing `_purge_source_closets` helper (already used by `delete_by_source`, #1722) rather than rebuild them, since closets are LLM-derived from file content this call path does not have: `delete_drawer` purges unconditionally, `update_drawer` only when `content` actually changes (a wing/room move alone leaves the quoted text correct). Rebuilding stale closets from the stored drawers, rather than only purging them, is a separate, larger change. (#2325)
 
 ---
 

mempalace/mcp_server.py

@@ -3218,13 +3218,24 @@ def tool_delete_drawer(drawer_id: str):
         col.delete(ids=record["ids"])
         _invalidate_overview_caches()
 
-        logger.info("Deleted drawer: %s (%s rows)", drawer_id, len(record["ids"]))
+        # Closets are keyed by source_file, not drawer_id (#1722), so a
+        # drawer-only delete strands a closet quoting the now-deleted text (#2325).
+        source_file = record["metadata"].get("source_file")
+        closets_deleted = _purge_source_closets(source_file, commit=True) if source_file else 0
+
+        logger.info(
+            "Deleted drawer: %s (%s rows, %s closet(s) purged)",
+            drawer_id,
+            len(record["ids"]),
+            closets_deleted,
+        )
 
         return {
             "success": True,
             "drawer_id": drawer_id,
             "deleted_ids": record["ids"],
             "chunks_deleted": len(record["ids"]),
+            "closets_deleted": closets_deleted,
         }
     except Exception as e:
         return {"success": False, "error": str(e)}
@@ -3833,6 +3844,13 @@ def tool_update_drawer(drawer_id: str, content: str = None, wing: str = None, ro
             },
         )
 
+        # A closet quotes the source file, not the stored drawer, so it only
+        # goes stale on a content change; wing/room alone leaves it correct (#2325).
+        closets_deleted = 0
+        source_file = old_meta.get("source_file")
+        if content is not None and source_file:
+            closets_deleted = _purge_source_closets(source_file, commit=True)
+
         chunk_size = max(1, int(getattr(_config, "chunk_size", 800) or 800))
         should_chunk = bool(record.get("chunked")) or len(new_doc) > chunk_size
 
@@ -3862,6 +3880,7 @@ def tool_update_drawer(drawer_id: str, content: str = None, wing: str = None, ro
                 "room": new_meta.get("room", ""),
                 "chunks": len(chunk_ids),
                 "chunk_ids": chunk_ids,
+                "closets_deleted": closets_deleted,
             }
 
         update_kwargs = {"ids": [record["ids"][0]]}
@@ -3879,6 +3898,7 @@ def tool_update_drawer(drawer_id: str, content: str = None, wing: str = None, ro
             "drawer_id": drawer_id,
             "wing": new_meta.get("wing", ""),
             "room": new_meta.get("room", ""),
+            "closets_deleted": closets_deleted,
         }
     except Exception as e:
         return {"success": False, "error": str(e)}

tests/test_mcp_server.py

@@ -2227,6 +2227,31 @@ def test_delete_drawer_not_found(self, monkeypatch, config, palace_path, seeded_
         result = tool_delete_drawer("nonexistent_drawer")
         assert result["success"] is False
 
+    def test_delete_drawer_purges_matching_closets(
+        self, monkeypatch, config, palace_path, seeded_collection, kg
+    ):
+        """Deleting a drawer purges its source's closets too, so the AAAK
+        index keeps no stale pointer at the now-deleted drawer (#2325)."""
+        _patch_mcp_server(monkeypatch, config, kg)
+        from mempalace.mcp_server import tool_delete_drawer
+        from mempalace.palace import get_closets_collection
+
+        closets_col = get_closets_collection(palace_path, create=True)
+        closets_col.add(
+            ids=["auth_closet_01"],
+            documents=["topic: JWT session tokens"],
+            metadatas=[{"source_file": "auth.py"}],
+        )
+
+        result = tool_delete_drawer("drawer_proj_backend_aaa")
+        assert result["success"] is True
+        assert result["closets_deleted"] == 1
+
+        # Re-acquire: the staleness reconnect drops chromadb's path-keyed
+        # System cache (#2002), so a handle taken before the call is dead now.
+        closets_col = get_closets_collection(palace_path, create=False)
+        assert closets_col.get(include=[])["ids"] == []
+
     def test_check_duplicate_handles_none_metadata(self, monkeypatch, config, kg):
         """tool_check_duplicate must tolerate None entries in the result lists
         that ChromaDB 1.5.x returns for partially-flushed rows.
@@ -2880,6 +2905,52 @@ def test_update_drawer_wing_and_room(
         assert result["wing"] == "new_wing"
         assert result["room"] == "new_room"
 
+    def test_update_drawer_content_purges_matching_closets(
+        self, monkeypatch, config, palace_path, seeded_collection, kg
+    ):
+        """Correcting a drawer's content purges its source's closets, which
+        otherwise keep quoting the pre-correction text indefinitely (#2325)."""
+        _patch_mcp_server(monkeypatch, config, kg)
+        from mempalace.mcp_server import tool_update_drawer
+        from mempalace.palace import get_closets_collection
+
+        closets_col = get_closets_collection(palace_path, create=True)
+        closets_col.add(
+            ids=["auth_closet_01"],
+            documents=["topic: JWT session tokens"],
+            metadatas=[{"source_file": "auth.py"}],
+        )
+
+        result = tool_update_drawer("drawer_proj_backend_aaa", content="[RETRACTED]")
+        assert result["success"] is True
+        assert result["closets_deleted"] == 1
+
+        closets_col = get_closets_collection(palace_path, create=False)
+        assert closets_col.get(include=[])["ids"] == []
+
+    def test_update_drawer_wing_and_room_does_not_purge_closets(
+        self, monkeypatch, config, palace_path, seeded_collection, kg
+    ):
+        """A wing/room move alone leaves the quoted text correct, so it must
+        not purge closets the way a content edit does (#2325)."""
+        _patch_mcp_server(monkeypatch, config, kg)
+        from mempalace.mcp_server import tool_update_drawer
+        from mempalace.palace import get_closets_collection
+
+        closets_col = get_closets_collection(palace_path, create=True)
+        closets_col.add(
+            ids=["auth_closet_01"],
+            documents=["topic: JWT session tokens"],
+            metadatas=[{"source_file": "auth.py"}],
+        )
+
+        result = tool_update_drawer("drawer_proj_backend_aaa", wing="new_wing", room="new_room")
+        assert result["success"] is True
+        assert result["closets_deleted"] == 0
+
+        closets_col = get_closets_collection(palace_path, create=False)
+        assert len(closets_col.get(include=[])["ids"]) == 1
+
     def test_update_drawer_not_found(self, monkeypatch, config, palace_path, seeded_collection, kg):
         _patch_mcp_server(monkeypatch, config, kg)
         from mempalace.mcp_server import tool_update_drawer