Knock on updates from requested changes

Author: mo-rickywong

components/science/source/algorithm/sci_geometric_constants_mod.x90

@@ -157,11 +157,10 @@ contains
     implicit none
 
     type(config_type), intent(in) :: config
+    type(mesh_type),   intent(in) :: mesh
     integer(i_def),    intent(in) :: space_id
     logical(l_def),    intent(in) :: use_fe
 
-    type(mesh_type), intent(in), pointer :: mesh
-
     type(inventory_by_local_mesh_type), intent(inout) :: long_inventory
     type(inventory_by_local_mesh_type), intent(inout) :: lat_inventory
 
@@ -595,7 +594,7 @@ contains
 
     implicit none
 
-    type(mesh_type), intent(in), pointer :: mesh
+    type(mesh_type), intent(in) :: mesh
 
     logical(kind=l_def)                   :: constant_exists
     type(field_type),             pointer :: detj_at_w3

components/science/source/algorithm/sci_mapping_constants_mod.x90

@@ -153,7 +153,8 @@ contains
 
     implicit none
 
-    type(mesh_type), pointer, intent(in) :: mesh
+    type(mesh_type), intent(in) :: mesh
+
     type(operator_type),         pointer :: project_xdot_to_w2
     type(operator_type),         pointer :: project_ydot_to_w2
     type(operator_type),         pointer :: project_zdot_to_w2
@@ -883,6 +884,7 @@ contains
     implicit none
 
     type(mesh_type), intent(in) :: mesh
+
     type(operator_type),        pointer :: proj_op
     logical(kind=l_def)                 :: constant_exists
 
@@ -940,7 +942,7 @@ contains
     implicit none
 
     type(config_type), intent(in) :: config
-    type(mesh_type), intent(in) :: mesh
+    type(mesh_type),   intent(in) :: mesh
 
     type(operator_type),      pointer :: u_lat_map_op
     logical(kind=l_def)               :: constant_exists
@@ -1000,7 +1002,7 @@ contains
     implicit none
 
     type(config_type), intent(in) :: config
-    type(mesh_type),   intent(in), pointer :: mesh
+    type(mesh_type),   intent(in) :: mesh
 
     type(operator_type),      pointer :: u_lon_sample_op
     logical(kind=l_def)               :: constant_exists

infrastructure/source/function_space/function_space_collection_mod.F90

@@ -95,10 +95,11 @@ function get_fs( self,            &
 
     class(function_space_collection_type), intent(inout) :: self
 
-    type(mesh_type), intent(in), pointer  :: mesh
-    integer(i_def),  intent(in)           :: element_order_h
-    integer(i_def),  intent(in)           :: element_order_v
-    integer(i_def),  intent(in)           :: lfric_fs
+    type(mesh_type), intent(in) :: mesh
+    integer(i_def),  intent(in) :: element_order_h
+    integer(i_def),  intent(in) :: element_order_v
+    integer(i_def),  intent(in) :: lfric_fs
+
     integer(i_def),  intent(in), optional :: ndata
     logical(l_def),  intent(in), optional :: ndata_first