Purge old rose stem commands and options (#437)

Author: stevemullerworth

components/lfric-xios/Makefile

@@ -107,25 +107,6 @@ integration-tests/%: export TEST_DIR      = integration-test
 integration-tests/%: export WORKING_DIR  := $(WORKING_DIR)/integration-tests
 integration-tests: integration-tests/run
 
-##############################################################################
-# Test suite rules
-#
-.PHONY: launch-suite-gscan
-launch-suite-gscan: gscan_processes := $(shell ps --no-headers -o command -C cylc-gscan)
-launch-suite-gscan: ALWAYS
-	$(Q)-if [[ "$(gscan_processes)" != *"--name=$(SUITE_GROUP_NAME)"* ]]; then \
-          cylc gscan  $(DOUBLE_VERBOSE_ARG) --name=$(SUITE_GROUP_NAME) &           \
-          usleep 1                                                                ;\
-        fi
-
-.PHONY: test-suite
-test-suite: SUITE_BASE_NAME = $(notdir $(realpath $(shell pwd)/$(CORE_ROOT_DIR)))-$(PROJECT_NAME)
-test-suite: SUITE_CONFIG = rose-stem
-test-suite: launch-suite-gscan launch-test-suite
-	$(Q)echo > /dev/null
-
-print-%  : ; @echo $* = $($*)
-
 ##############################################################################
 # Clean
 #

documentation/source/getting_started/installation/build_and_run.rst

@@ -89,14 +89,17 @@ time you will want to commit changes to the upstream repository. A
 ``.gitignore`` file, found at the top-level of the directory tree, should
 prevent you inadvertently including build artefacts in your commit if you ever
 run a ``git add .`` command. But do use ``git status`` to be sure of what your
-changeset includes. Note that it is always safer to use ``git add <filename>`` on the specific files you want to add/change.
+changeset includes. Note that it is always safer to use ``git add <filename>``
+on the specific files you want to add/change.
 
 Running ``make clean`` will remove the working, test and bin directories.
 
 After building an application from the command line, it can be useful to do a
 quick test to ensure it can run. Most applications in the lfric and lfric_apps
 repository hold a simple example configuration in their ``example`` directory
-(which is also included in the ``.gitignore`` file, so if you want to add or change files in the ``example`` directory, you will need to use ``git add -f ...``).
+(which is also included in the ``.gitignore`` file, so if you want to add or
+change files in the ``example`` directory, you will need to use ``git add -f
+...``).
 
 After building, go into to the example directory and run the application, as
 follows:
@@ -115,15 +118,16 @@ Running the Cylc test suite
 
 To run the test suites, Cylc and Rose need to be installed.
 
-The ``rose stem`` command selects the group of tests to run. Then ``cylc play``
-starts the suite running. For example, to run the developer tests for all the
-applications and components within an LFRic working copy, run the following from
-the top-level of the working copy:
+The tests are defined in the ``rose-stem`` directory within the the top-level of
+the clone of the repository. To run the developer tests for all the
+applications, ``cd`` to the top-level directory and run the following:
 
 .. code-block::
 
-   rose stem --group=developer
-   cylc play <working_copy_name>
+   cylc vip -z group=developer -n NAME ./rose-stem
+
+The ``NAME`` argument defines the name of the suite, which will be the name of
+the top-level directory created or used within the ``~/cylc-run`` directory.
 
 Building the documentation
 --------------------------

documentation/source/how_to_use_it/build_and_test/use_of_make.rst

@@ -16,9 +16,6 @@ directory), build and run any unit tests, and build and run any
 integration tests. The Makefile supports options to execute any of
 these choices individually.
 
-The Makefile can be used to run the Rose Stem system test
-suite: run ``make test-suite``.
-
 Each Makefile takes other optional arguments, for example to
 obtain verbose output or to choose different sets of compile
 options. Each application or component will describe the options

infrastructure/build/lfric.mk

@@ -24,18 +24,9 @@
 #              files" performance, i.e. probably not Lustre.
 #              Default: ./working
 # VERBOSE: Set in order to see actual commands issued by the build system.
-# PURGE_SUITES: Set to non-zero value to clean out exisiting rose suites of
-#               same name. (this is also the default action)
-#               Set to zero to not clean out existing rose suite.
 # TEST_SUITE_TARGETS: Space separated list of target identifiers to be used
 #                     when launching the test suite. Default is "meto-azspice
 #                     meto-ex1a"
-# SUITE_GROUP_ABRV: Set to a non-zero value to cause the names of the rose
-#                   stem groups to always be abbreviated in the suite name.
-#                   Set to zero to cause the names to always be unabbreviated.
-#                   The default is abbreviated for multi-group runs, but
-#                   unabbreviated for single-group runs.
-#
 ##############################################################################
 
 .SECONDEXPANSION:
@@ -158,13 +149,6 @@ endif
 
 export Q QUIET_ARG VERBOSE_REDIRECT
 
-# Set flag to perform a fresh rose stem suite
-
-CLEAN_OPT ?= '--new'
-ifeq '$(PURGE_SUITES)' '0'
-  CLEAN_OPT =
-endif
-
 # We only want to send terminal control characters if there is a terminal to
 # interpret them...
 #
@@ -202,13 +186,7 @@ define ANNOUNCE_BODY
 *******************************************************************************
 Error
 
-The Cylc 7 test suite is no longer in use, please use the Cylc 8 suite.
-
-New commands:
-
-export CYLC_VERSION=8
-rose stem --group=developer
-cylc play <working_copy_name>
+The Cylc 7 test suite is no longer in use.
 
 *******************************************************************************
 
@@ -263,18 +241,6 @@ api-documentation: ALWAYS
 	      echo OUTPUT_DIRECTORY=$(DOCUMENT_DIR) ) \
 	    | doxygen - $(VERBOSE_REDIRECT)
 
-##############################################################################
-# Launch test suite
-#
-# SUITE_CONFIG    - Path to rose-stem directory.
-# SUITE_BASE_NAME - Name for suites.
-# SUITE_GROUP_NAME_ABRV - Name(s) of the rose stem group(s) with abbreviations applied.
-#
-.PHONY: launch-test-suite
-launch-test-suite:
-	$(error $(ANNOUNCE_BODY) )
-
-
 ##############################################################################
 # Generate configuration source.
 #