Skip to content

Commit da893e4

Browse files
authored
fix: adjust volume bar transparency (#28577)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** PR to update volume bar transparency in token details AC. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: update volume bar transparency ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-3036 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk visual-only change limited to chart volume study inputs; no data, auth, or business logic is affected. > > **Overview** > **Updates volume bar rendering in AdvancedChart.** When volume is shown as an overlay, the Volume study now sets `volume.transparency` to `70` (previously always `0`), keeping non-overlay volume fully opaque. > > Regenerates `chartLogicString.ts` from `chartLogic.js` (including a no-op formatting simplification in the message pending-queue guard) so the WebView-injected script stays in sync. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 2a2a32d. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 71c555f commit da893e4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/components/UI/Charts/AdvancedChart/webview/chartLogic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2865,7 +2865,7 @@ function createVolumeStudy(useOverlay) {
28652865
'volume ma.display': 0,
28662866
'volume.color.0': theme.errorColor,
28672867
'volume.color.1': theme.successColor,
2868-
'volume.transparency': 0,
2868+
'volume.transparency': useOverlay ? 70 : 0,
28692869
};
28702870
var promise = useOverlay
28712871
? chart.createStudy('Volume', true, false, {}, inputs, {

app/components/UI/Charts/AdvancedChart/webview/chartLogicString.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2874,7 +2874,7 @@ function createVolumeStudy(useOverlay) {
28742874
'volume ma.display': 0,
28752875
'volume.color.0': theme.errorColor,
28762876
'volume.color.1': theme.successColor,
2877-
'volume.transparency': 0,
2877+
'volume.transparency': useOverlay ? 70 : 0,
28782878
};
28792879
var promise = useOverlay
28802880
? chart.createStudy('Volume', true, false, {}, inputs, {

0 commit comments

Comments
 (0)