Skip to content

fix: media playback issue ai insights#28148

Merged
joaosantos15 merged 5 commits intomainfrom
TSA-328-video-playback-issue
Mar 31, 2026
Merged

fix: media playback issue ai insights#28148
joaosantos15 merged 5 commits intomainfrom
TSA-328-video-playback-issue

Conversation

@joaosantos15
Copy link
Copy Markdown
Contributor

@joaosantos15 joaosantos15 commented Mar 31, 2026 •
edited by cursor bot
Loading

Description

Prevent the Market Insights background animation from interrupting audio already playing on the device.

The screen uses a muted react-native-video animation, but on iOS that video can still take over the app audio session and stop music playback from Bluetooth headphones or device speakers. This change configures the background video to obey the silent switch and mix with other audio so opening Market Insights no longer pauses the user’s music.

The test mock for react-native-video was also updated to forward props so the view test can assert the audio-session configuration.

Changelog

CHANGELOG entry: Fixed an issue where opening Market Insights could pause audio already playing on the device.

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches media playback configuration (react-native-video) which can affect audio behavior across platforms, but the change is small and covered by a targeted unit test.

Overview
Prevents the Market Insights muted background animation from taking over the app audio session by configuring react-native-video to ignoreSilentSwitch="obey" and mixWithOthers="mix".

Updates the react-native-video Jest mock to forward arbitrary props, and adds a view test asserting the new audio-mixing configuration on the background video.

Written by Cursor Bugbot for commit 96bed41. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-social-ai Social & AI team label Mar 31, 2026
@joaosantos15 joaosantos15 marked this pull request as ready for review March 31, 2026 10:24
@metamaskbot metamaskbot requested a review from a team as a code owner March 31, 2026 11:07
@joaosantos15 joaosantos15 enabled auto-merge March 31, 2026 13:41
@github-actions github-actions bot added the risk-medium Moderate testing recommended · Possible bug introduction risk label Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

❌ E2E Fixture Validation — Failed
The fixture validation job failed. Review the logs

@github-actions github-actions bot added risk-low Low testing needed · Low bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 31, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 31, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR makes three narrow changes:

  1. MarketInsightsView.tsx: Adds ignoreSilentSwitch="obey" and mixWithOthers="mix" props to a background video component. This is a minor audio behavior fix — the video will now respect the device's silent switch and mix audio with other apps (e.g., music) rather than interrupting it. No UI layout, navigation, state management, or user flow changes.

  2. MarketInsightsView.test.tsx: Adds a unit test verifying the new video props are correctly applied.

  3. app/mocks/react-native-video.tsx: Updates the mock to spread all props through (...rest) so the new props can be asserted in unit tests. This is a test-infrastructure change scoped to unit tests only, not E2E infrastructure.

Why no E2E tags are needed:

  • No E2E tests validate video audio behavior or these specific props
  • No user flows, navigation paths, confirmations, or critical wallet operations are affected
  • The change is fully covered by the new unit test
  • MarketInsights is part of the Trending tab (SmokeWalletPlatform), but this audio fix doesn't affect any testable UI behavior in E2E scenarios
  • Risk is low — purely a UX audio fix with no functional impact on wallet operations

Performance Test Selection:
Adding two audio configuration props to a background video component has no measurable performance impact. No rendering performance, data loading, state management, or critical user flows are affected.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 31, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joaosantos15 joaosantos15 added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit 88afe15 Mar 31, 2026
61 of 63 checks passed
@joaosantos15 joaosantos15 deleted the TSA-328-video-playback-issue branch March 31, 2026 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2026
@weitingsun weitingsun added release-7.73.0 Issue or pull request that will be included in release 7.73.0 and removed release-100.10.0 labels Mar 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

@xavier-brochard xavier-brochard xavier-brochard left review comments

Assignees

No one assigned

Labels

release-7.73.0 Issue or pull request that will be included in release 7.73.0 risk-low Low testing needed · Low bug introduction risk size-S team-social-ai Social & AI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joaosantos15 @xavier-brochard @tommasini @metamaskbot @weitingsun